| Message ID | 1533924845-1466-1-git-send-email-avienamo@nvidia.com |
|---|---|
| Headers | show |
| Series | Tegra SDHCI support HS400 on Tegra210 and Tegra186 | expand |
On Fri, Aug 10, 2018 at 09:13:57PM +0300, Aapo Vienamo wrote: > Hi all, > This series implements support for HS400 signaling on Tegra210 and > Tegra186. This includes programming the DQS trimmer values, implementing > enhanced strobe and HS400 delay line calibration. > > This series depends on the "Tegra SDHCI add support for HS200 and UHS > signaling" series. > > Changelog: > v2: > - Document in dt-bindings which controllers support HS400 > - Use val instead of reg in tegra_sdhci_set_dqs_trim() > - Change "dt" to "DT" in "mmc: tegra: Parse and program DQS trim > value" commit message > - Add spaces around << in tegra_sdhci_set_dqs_trim() > - Make the "mmc: tegra: Implement HS400 enhanced strobe" commit > message more detailed > - Remove a debug print from tegra_sdhci_hs400_enhanced_strobe() > - Add blank lines around if-else-block in > tegra_sdhci_hs400_enhanced_strobe() > - Use val instead of reg in tegra_sdhci_hs400_enhanced_strobe() > - Make commit message of "mmc: tegra: Implement HS400 delay line > calibration" more detailed > > Aapo Vienamo (8): > dt-bindings: mmc: Add DQS trim value to Tegra SDHCI > mmc: tegra: Parse and program DQS trim value > mmc: tegra: Implement HS400 enhanced strobe > mmc: tegra: Implement HS400 delay line calibration > arm64: dts: tegra186: Add SDMMC4 DQS trim value > arm64: dts: tegra210: Add SDMMC4 DQS trim value > arm64: dts: tegra186: Enable HS400 > arm64: dts: tegra210: Enable HS400 > > .../bindings/mmc/nvidia,tegra20-sdhci.txt | 4 ++ > arch/arm64/boot/dts/nvidia/tegra186.dtsi | 2 + > arch/arm64/boot/dts/nvidia/tegra210.dtsi | 2 + > drivers/mmc/host/sdhci-tegra.c | 84 +++++++++++++++++++++- > 4 files changed, 89 insertions(+), 3 deletions(-) Ulf, Adrian, Aapo just reminded me of this small series that also has a dependency on the UHS signalling series posted earlier. I think it's easiest if I just stash this on top of the existing branch that I have and send this along with the rest as part of a pull request early after v4.19-rc1. Thierry
On 24 August 2018 at 11:11, Thierry Reding <thierry.reding@gmail.com> wrote: > On Fri, Aug 10, 2018 at 09:13:57PM +0300, Aapo Vienamo wrote: >> Hi all, >> This series implements support for HS400 signaling on Tegra210 and >> Tegra186. This includes programming the DQS trimmer values, implementing >> enhanced strobe and HS400 delay line calibration. >> >> This series depends on the "Tegra SDHCI add support for HS200 and UHS >> signaling" series. >> >> Changelog: >> v2: >> - Document in dt-bindings which controllers support HS400 >> - Use val instead of reg in tegra_sdhci_set_dqs_trim() >> - Change "dt" to "DT" in "mmc: tegra: Parse and program DQS trim >> value" commit message >> - Add spaces around << in tegra_sdhci_set_dqs_trim() >> - Make the "mmc: tegra: Implement HS400 enhanced strobe" commit >> message more detailed >> - Remove a debug print from tegra_sdhci_hs400_enhanced_strobe() >> - Add blank lines around if-else-block in >> tegra_sdhci_hs400_enhanced_strobe() >> - Use val instead of reg in tegra_sdhci_hs400_enhanced_strobe() >> - Make commit message of "mmc: tegra: Implement HS400 delay line >> calibration" more detailed >> >> Aapo Vienamo (8): >> dt-bindings: mmc: Add DQS trim value to Tegra SDHCI >> mmc: tegra: Parse and program DQS trim value >> mmc: tegra: Implement HS400 enhanced strobe >> mmc: tegra: Implement HS400 delay line calibration >> arm64: dts: tegra186: Add SDMMC4 DQS trim value >> arm64: dts: tegra210: Add SDMMC4 DQS trim value >> arm64: dts: tegra186: Enable HS400 >> arm64: dts: tegra210: Enable HS400 >> >> .../bindings/mmc/nvidia,tegra20-sdhci.txt | 4 ++ >> arch/arm64/boot/dts/nvidia/tegra186.dtsi | 2 + >> arch/arm64/boot/dts/nvidia/tegra210.dtsi | 2 + >> drivers/mmc/host/sdhci-tegra.c | 84 +++++++++++++++++++++- >> 4 files changed, 89 insertions(+), 3 deletions(-) > > Ulf, Adrian, > > Aapo just reminded me of this small series that also has a dependency on > the UHS signalling series posted earlier. I think it's easiest if I just > stash this on top of the existing branch that I have and send this along > with the rest as part of a pull request early after v4.19-rc1. Yep, that would be convenient for me. Although, we first need some input from Adrian. Kind regards Uffe
On Fri, Aug 10, 2018 at 09:13:57PM +0300, Aapo Vienamo wrote: > Hi all, > This series implements support for HS400 signaling on Tegra210 and > Tegra186. This includes programming the DQS trimmer values, implementing > enhanced strobe and HS400 delay line calibration. > > This series depends on the "Tegra SDHCI add support for HS200 and UHS > signaling" series. > > Changelog: > v2: > - Document in dt-bindings which controllers support HS400 > - Use val instead of reg in tegra_sdhci_set_dqs_trim() > - Change "dt" to "DT" in "mmc: tegra: Parse and program DQS trim > value" commit message > - Add spaces around << in tegra_sdhci_set_dqs_trim() > - Make the "mmc: tegra: Implement HS400 enhanced strobe" commit > message more detailed > - Remove a debug print from tegra_sdhci_hs400_enhanced_strobe() > - Add blank lines around if-else-block in > tegra_sdhci_hs400_enhanced_strobe() > - Use val instead of reg in tegra_sdhci_hs400_enhanced_strobe() > - Make commit message of "mmc: tegra: Implement HS400 delay line > calibration" more detailed > > Aapo Vienamo (8): > dt-bindings: mmc: Add DQS trim value to Tegra SDHCI > mmc: tegra: Parse and program DQS trim value > mmc: tegra: Implement HS400 enhanced strobe > mmc: tegra: Implement HS400 delay line calibration > arm64: dts: tegra186: Add SDMMC4 DQS trim value > arm64: dts: tegra210: Add SDMMC4 DQS trim value > arm64: dts: tegra186: Enable HS400 > arm64: dts: tegra210: Enable HS400 > > .../bindings/mmc/nvidia,tegra20-sdhci.txt | 4 ++ > arch/arm64/boot/dts/nvidia/tegra186.dtsi | 2 + > arch/arm64/boot/dts/nvidia/tegra210.dtsi | 2 + > drivers/mmc/host/sdhci-tegra.c | 84 +++++++++++++++++++++- > 4 files changed, 89 insertions(+), 3 deletions(-) Adrian, any chance you could take a brief look at these? They are a prerequisite for the 2-patch series ("[PATCH 0/2] Tegra SDHCI rerun pad calibration periodically") that you already acked. Thanks, Thierry
On 27/08/18 13:08, Thierry Reding wrote: > On Fri, Aug 10, 2018 at 09:13:57PM +0300, Aapo Vienamo wrote: >> Hi all, >> This series implements support for HS400 signaling on Tegra210 and >> Tegra186. This includes programming the DQS trimmer values, implementing >> enhanced strobe and HS400 delay line calibration. >> >> This series depends on the "Tegra SDHCI add support for HS200 and UHS >> signaling" series. >> >> Changelog: >> v2: >> - Document in dt-bindings which controllers support HS400 >> - Use val instead of reg in tegra_sdhci_set_dqs_trim() >> - Change "dt" to "DT" in "mmc: tegra: Parse and program DQS trim >> value" commit message >> - Add spaces around << in tegra_sdhci_set_dqs_trim() >> - Make the "mmc: tegra: Implement HS400 enhanced strobe" commit >> message more detailed >> - Remove a debug print from tegra_sdhci_hs400_enhanced_strobe() >> - Add blank lines around if-else-block in >> tegra_sdhci_hs400_enhanced_strobe() >> - Use val instead of reg in tegra_sdhci_hs400_enhanced_strobe() >> - Make commit message of "mmc: tegra: Implement HS400 delay line >> calibration" more detailed >> >> Aapo Vienamo (8): >> dt-bindings: mmc: Add DQS trim value to Tegra SDHCI >> mmc: tegra: Parse and program DQS trim value >> mmc: tegra: Implement HS400 enhanced strobe >> mmc: tegra: Implement HS400 delay line calibration >> arm64: dts: tegra186: Add SDMMC4 DQS trim value >> arm64: dts: tegra210: Add SDMMC4 DQS trim value >> arm64: dts: tegra186: Enable HS400 >> arm64: dts: tegra210: Enable HS400 >> >> .../bindings/mmc/nvidia,tegra20-sdhci.txt | 4 ++ >> arch/arm64/boot/dts/nvidia/tegra186.dtsi | 2 + >> arch/arm64/boot/dts/nvidia/tegra210.dtsi | 2 + >> drivers/mmc/host/sdhci-tegra.c | 84 +++++++++++++++++++++- >> 4 files changed, 89 insertions(+), 3 deletions(-) > > Adrian, > > any chance you could take a brief look at these? They are a prerequisite > for the 2-patch series ("[PATCH 0/2] Tegra SDHCI rerun pad calibration > periodically") that you already acked. Sure, I'll try and have a look today.
On 27/08/18 13:26, Adrian Hunter wrote: > On 27/08/18 13:08, Thierry Reding wrote: >> On Fri, Aug 10, 2018 at 09:13:57PM +0300, Aapo Vienamo wrote: >>> Hi all, >>> This series implements support for HS400 signaling on Tegra210 and >>> Tegra186. This includes programming the DQS trimmer values, implementing >>> enhanced strobe and HS400 delay line calibration. >>> >>> This series depends on the "Tegra SDHCI add support for HS200 and UHS >>> signaling" series. >>> >>> Changelog: >>> v2: >>> - Document in dt-bindings which controllers support HS400 >>> - Use val instead of reg in tegra_sdhci_set_dqs_trim() >>> - Change "dt" to "DT" in "mmc: tegra: Parse and program DQS trim >>> value" commit message >>> - Add spaces around << in tegra_sdhci_set_dqs_trim() >>> - Make the "mmc: tegra: Implement HS400 enhanced strobe" commit >>> message more detailed >>> - Remove a debug print from tegra_sdhci_hs400_enhanced_strobe() >>> - Add blank lines around if-else-block in >>> tegra_sdhci_hs400_enhanced_strobe() >>> - Use val instead of reg in tegra_sdhci_hs400_enhanced_strobe() >>> - Make commit message of "mmc: tegra: Implement HS400 delay line >>> calibration" more detailed >>> >>> Aapo Vienamo (8): >>> dt-bindings: mmc: Add DQS trim value to Tegra SDHCI >>> mmc: tegra: Parse and program DQS trim value >>> mmc: tegra: Implement HS400 enhanced strobe >>> mmc: tegra: Implement HS400 delay line calibration >>> arm64: dts: tegra186: Add SDMMC4 DQS trim value >>> arm64: dts: tegra210: Add SDMMC4 DQS trim value >>> arm64: dts: tegra186: Enable HS400 >>> arm64: dts: tegra210: Enable HS400 >>> >>> .../bindings/mmc/nvidia,tegra20-sdhci.txt | 4 ++ >>> arch/arm64/boot/dts/nvidia/tegra186.dtsi | 2 + >>> arch/arm64/boot/dts/nvidia/tegra210.dtsi | 2 + >>> drivers/mmc/host/sdhci-tegra.c | 84 +++++++++++++++++++++- >>> 4 files changed, 89 insertions(+), 3 deletions(-) >> >> Adrian, >> >> any chance you could take a brief look at these? They are a prerequisite >> for the 2-patch series ("[PATCH 0/2] Tegra SDHCI rerun pad calibration >> periodically") that you already acked. > > Sure, I'll try and have a look today. > These are fine. For the sdhci-tegra patches (patches 2 - 4): Acked-by: Adrian Hunter <adrian.hunter@intel.com>
On Fri, Aug 10, 2018 at 09:13:57PM +0300, Aapo Vienamo wrote: > Hi all, > This series implements support for HS400 signaling on Tegra210 and > Tegra186. This includes programming the DQS trimmer values, implementing > enhanced strobe and HS400 delay line calibration. > > This series depends on the "Tegra SDHCI add support for HS200 and UHS > signaling" series. > > Changelog: > v2: > - Document in dt-bindings which controllers support HS400 > - Use val instead of reg in tegra_sdhci_set_dqs_trim() > - Change "dt" to "DT" in "mmc: tegra: Parse and program DQS trim > value" commit message > - Add spaces around << in tegra_sdhci_set_dqs_trim() > - Make the "mmc: tegra: Implement HS400 enhanced strobe" commit > message more detailed > - Remove a debug print from tegra_sdhci_hs400_enhanced_strobe() > - Add blank lines around if-else-block in > tegra_sdhci_hs400_enhanced_strobe() > - Use val instead of reg in tegra_sdhci_hs400_enhanced_strobe() > - Make commit message of "mmc: tegra: Implement HS400 delay line > calibration" more detailed > > Aapo Vienamo (8): > dt-bindings: mmc: Add DQS trim value to Tegra SDHCI > mmc: tegra: Parse and program DQS trim value > mmc: tegra: Implement HS400 enhanced strobe > mmc: tegra: Implement HS400 delay line calibration > arm64: dts: tegra186: Add SDMMC4 DQS trim value > arm64: dts: tegra210: Add SDMMC4 DQS trim value > arm64: dts: tegra186: Enable HS400 > arm64: dts: tegra210: Enable HS400 > > .../bindings/mmc/nvidia,tegra20-sdhci.txt | 4 ++ > arch/arm64/boot/dts/nvidia/tegra186.dtsi | 2 + > arch/arm64/boot/dts/nvidia/tegra210.dtsi | 2 + > drivers/mmc/host/sdhci-tegra.c | 84 +++++++++++++++++++++- > 4 files changed, 89 insertions(+), 3 deletions(-) For patches 1-4: Acked-by: Thierry Reding <treding@nvidia.com>
On 10 August 2018 at 20:13, Aapo Vienamo <avienamo@nvidia.com> wrote: > Hi all, > This series implements support for HS400 signaling on Tegra210 and > Tegra186. This includes programming the DQS trimmer values, implementing > enhanced strobe and HS400 delay line calibration. > > This series depends on the "Tegra SDHCI add support for HS200 and UHS > signaling" series. > > Changelog: > v2: > - Document in dt-bindings which controllers support HS400 > - Use val instead of reg in tegra_sdhci_set_dqs_trim() > - Change "dt" to "DT" in "mmc: tegra: Parse and program DQS trim > value" commit message > - Add spaces around << in tegra_sdhci_set_dqs_trim() > - Make the "mmc: tegra: Implement HS400 enhanced strobe" commit > message more detailed > - Remove a debug print from tegra_sdhci_hs400_enhanced_strobe() > - Add blank lines around if-else-block in > tegra_sdhci_hs400_enhanced_strobe() > - Use val instead of reg in tegra_sdhci_hs400_enhanced_strobe() > - Make commit message of "mmc: tegra: Implement HS400 delay line > calibration" more detailed > > Aapo Vienamo (8): > dt-bindings: mmc: Add DQS trim value to Tegra SDHCI > mmc: tegra: Parse and program DQS trim value > mmc: tegra: Implement HS400 enhanced strobe > mmc: tegra: Implement HS400 delay line calibration > arm64: dts: tegra186: Add SDMMC4 DQS trim value > arm64: dts: tegra210: Add SDMMC4 DQS trim value > arm64: dts: tegra186: Enable HS400 > arm64: dts: tegra210: Enable HS400 > > .../bindings/mmc/nvidia,tegra20-sdhci.txt | 4 ++ > arch/arm64/boot/dts/nvidia/tegra186.dtsi | 2 + > arch/arm64/boot/dts/nvidia/tegra210.dtsi | 2 + > drivers/mmc/host/sdhci-tegra.c | 84 +++++++++++++++++++++- > 4 files changed, 89 insertions(+), 3 deletions(-) > > -- > 2.7.4 > Applied patch 1->4 for next, thanks! Kind regards Uffe