mbox series

[SRU,Bionic/Cosmic,0/2] Fix regression on acpi-lpss

Message ID 20180801081742.12590-1-kai.heng.feng@canonical.com
Headers show
Series Fix regression on acpi-lpss | expand

Message

Kai-Heng Feng Aug. 1, 2018, 8:17 a.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/1774950

[Impact]
Systems with acpi-lpss can't do S3/S4 on Bionic.

[Test]
Users confirmed these patches work for them.

[Fix]
Commit a192aa923b66a (ACPI / LPSS: Consolidate runtime PM and system
sleep handling) applies quirks for both runtime and system suspend.
This causes problems for some systems, so avoid using quirks on S3 and
S4.

[Regression Potential]
Low. These patches are in upstream stable, and it brings back driver's
old behavior.

Rafael J. Wysocki (2):
  ACPI / LPSS: Avoid PM quirks on suspend and resume from S3
  ACPI / LPSS: Avoid PM quirks on suspend and resume from hibernation

 drivers/acpi/acpi_lpss.c | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

Comments

Seth Forshee Aug. 1, 2018, 1:38 p.m. UTC | #1 
On Wed, Aug 01, 2018 at 04:17:40PM +0800, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1774950
> 
> [Impact]
> Systems with acpi-lpss can't do S3/S4 on Bionic.
> 
> [Test]
> Users confirmed these patches work for them.
> 
> [Fix]
> Commit a192aa923b66a (ACPI / LPSS: Consolidate runtime PM and system
> sleep handling) applies quirks for both runtime and system suspend.
> This causes problems for some systems, so avoid using quirks on S3 and
> S4.
> 
> [Regression Potential]
> Low. These patches are in upstream stable, and it brings back driver's
> old behavior.

Clean cherry picks, positive testing.

Acked-by: Seth Forshee <seth.forshee@canonical.com>

Patch 1 already made it to cosmic via upstream stable. Applied patch 2
to cosmic/master-next and unstable/master, thanks!
Khalid Elmously Aug. 21, 2018, 6:01 a.m. UTC | #2 
to bionic/master-next


On 2018-08-01 16:17:40 , Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1774950
> 
> [Impact]
> Systems with acpi-lpss can't do S3/S4 on Bionic.
> 
> [Test]
> Users confirmed these patches work for them.
> 
> [Fix]
> Commit a192aa923b66a (ACPI / LPSS: Consolidate runtime PM and system
> sleep handling) applies quirks for both runtime and system suspend.
> This causes problems for some systems, so avoid using quirks on S3 and
> S4.
> 
> [Regression Potential]
> Low. These patches are in upstream stable, and it brings back driver's
> old behavior.
> 
> Rafael J. Wysocki (2):
>   ACPI / LPSS: Avoid PM quirks on suspend and resume from S3
>   ACPI / LPSS: Avoid PM quirks on suspend and resume from hibernation
> 
>  drivers/acpi/acpi_lpss.c | 14 +++++++++++++-
>  1 file changed, 13 insertions(+), 1 deletion(-)
> 
> -- 
> 2.17.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team