mbox series

[v4,0/5] Add Actions Semi S700 pinctrl support

Message ID 20180731194743.13678-1-sravanhome@gmail.com
Headers show
Series Add Actions Semi S700 pinctrl support | expand

Message

saravanan sekar July 31, 2018, 7:47 p.m. UTC
This patchset adds pinctrl support for Actions Semi S700 SoC.
Pinmux functions are only accessible for pin groups while pinconf
parameters are available for both pin groups and individual pins.

pinctrl driver is verified using the Cubieboard7.

common functionalities from s900 is moved for all Actions Semi
SoC's usage.
Common pad control configurations are moved to SoC specific

dts entry for pinctrl depends on clock driver which is still under review:
https://patchwork.kernel.org/patch/10533959/

Thanks,
Saravanan
Parthiban

Changelog in v2
- GPIO Interrupt support is added
- Device tree entry for GPIO and Interrupt configured
- GPIO and pinctrl define reorder, commit message findings fixed

depends on owl GPIO Interrupt support
https://patchwork.kernel.org/patch/10483477/

Chnagelog in v3
- Fixed 0-DAY bisectibility error

Chnagelog in v4
- Fixed 0-DAY sparse warnings on static declaration

Saravanan Sekar (5):
  pinctrl: actions: define constructor generic to Actions Semi SoC's
  pinctrl: actions: define pad control configurtion to SoC specific
  dt-bindings: pinctrl: Add bindings for Actions Semi S700 SoC
  pinctrl: actions: Add Actions Semi S700 pinctrl driver
  arm64: dts: actions: Add pinctrl node for Actions Semi S700

 .../bindings/pinctrl/actions,s700-pinctrl.txt |  170 ++
 arch/arm64/boot/dts/actions/s700.dtsi         |   16 +
 drivers/pinctrl/actions/Kconfig               |    6 +
 drivers/pinctrl/actions/Makefile              |    1 +
 drivers/pinctrl/actions/pinctrl-owl.c         |   71 +-
 drivers/pinctrl/actions/pinctrl-owl.h         |  142 +-
 drivers/pinctrl/actions/pinctrl-s700.c        | 1925 +++++++++++++++++
 drivers/pinctrl/actions/pinctrl-s900.c        |  205 +-
 8 files changed, 2337 insertions(+), 199 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/pinctrl/actions,s700-pinctrl.txt
 create mode 100644 drivers/pinctrl/actions/pinctrl-s700.c

Comments

Linus Walleij Aug. 29, 2018, 7:35 a.m. UTC | #1
On Tue, Jul 31, 2018 at 9:48 PM Saravanan Sekar <sravanhome@gmail.com> wrote:

> This patchset adds pinctrl support for Actions Semi S700 SoC.
> Pinmux functions are only accessible for pin groups while pinconf
> parameters are available for both pin groups and individual pins.
>
> pinctrl driver is verified using the Cubieboard7.
>
> common functionalities from s900 is moved for all Actions Semi
> SoC's usage.
> Common pad control configurations are moved to SoC specific
>
> dts entry for pinctrl depends on clock driver which is still under review:
> https://patchwork.kernel.org/patch/10533959/

So what is the status of this patch set?

I am happy to apply it once you have the right buildtime dependencies
and Manivannan's ACK on the patch set! (Looks good to me.)

Maybe you want to rebase on v4.19-rc1 and resend as v5 before
I do that though?

Yours,
Linus Walleij
Manivannan Sadhasivam Aug. 29, 2018, 7:41 a.m. UTC | #2
On Wed, Aug 29, 2018 at 09:35:38AM +0200, Linus Walleij wrote:
> On Tue, Jul 31, 2018 at 9:48 PM Saravanan Sekar <sravanhome@gmail.com> wrote:
> 
> > This patchset adds pinctrl support for Actions Semi S700 SoC.
> > Pinmux functions are only accessible for pin groups while pinconf
> > parameters are available for both pin groups and individual pins.
> >
> > pinctrl driver is verified using the Cubieboard7.
> >
> > common functionalities from s900 is moved for all Actions Semi
> > SoC's usage.
> > Common pad control configurations are moved to SoC specific
> >
> > dts entry for pinctrl depends on clock driver which is still under review:
> > https://patchwork.kernel.org/patch/10533959/
> 
> So what is the status of this patch set?
>

Oops. This one slipped through the cracks...

> I am happy to apply it once you have the right buildtime dependencies
> and Manivannan's ACK on the patch set! (Looks good to me.)
> 

Sadly mutt played its part on this patchset and 1,3 patches got
deleted accidentally.

> Maybe you want to rebase on v4.19-rc1 and resend as v5 before
> I do that though?
> 

Parthiban,

Can you please rebase and send the next iteration as Linus said. I'll take a
look.

Sorry for the late reply.

Regards,
Mani

> Yours,
> Linus Walleij
Parthiban Nallathambi Aug. 29, 2018, 7:55 a.m. UTC | #3
Hi Mani,

On 08/29/2018 09:41 AM, Manivannan Sadhasivam wrote:
> On Wed, Aug 29, 2018 at 09:35:38AM +0200, Linus Walleij wrote:
>> On Tue, Jul 31, 2018 at 9:48 PM Saravanan Sekar <sravanhome@gmail.com> wrote:
>>
>>> This patchset adds pinctrl support for Actions Semi S700 SoC.
>>> Pinmux functions are only accessible for pin groups while pinconf
>>> parameters are available for both pin groups and individual pins.
>>>
>>> pinctrl driver is verified using the Cubieboard7.
>>>
>>> common functionalities from s900 is moved for all Actions Semi
>>> SoC's usage.
>>> Common pad control configurations are moved to SoC specific
>>>
>>> dts entry for pinctrl depends on clock driver which is still under review:
>>> https://patchwork.kernel.org/patch/10533959/
>>
>> So what is the status of this patch set?
>>
> 
> Oops. This one slipped through the cracks...
> 
>> I am happy to apply it once you have the right buildtime dependencies
>> and Manivannan's ACK on the patch set! (Looks good to me.)
>>
> 
> Sadly mutt played its part on this patchset and 1,3 patches got
> deleted accidentally.
> 
>> Maybe you want to rebase on v4.19-rc1 and resend as v5 before
>> I do that though?
>>
> 
> Parthiban,
> 
> Can you please rebase and send the next iteration as Linus said. I'll take a
> look.

Sure, will send it today after rebase.

> 
> Sorry for the late reply.
> 
> Regards,
> Mani
> 
>> Yours,
>> Linus Walleij