mbox series

[SRU,Trusty,0/3] BUG: scheduling while atomic on VMware 6.0 and late.

Message ID 20180731135000.6114-1-eric.desrochers@canonical.com
Headers show
Series BUG: scheduling while atomic on VMware 6.0 and late. | expand

Message

Eric Desrochers July 31, 2018, 1:49 p.m. UTC
A "BUG: scheduling while atomic" situation randomly occur when VMware guess is running Ubuntu kernel 3.13 series and hosted on VMware 6.0 and later,
with VMCI (Virtual Machine Communication Interface) turned on.

Upstream discussion confirms the need of the 3 upstream commits : https://patchwork.kernel.org/patch/9948741/
The VMware author of the patch suggested a backport from upstream of 3 patches he made.

The patches has been tested for more than 3 weeks now with a user affected by this situation, without any problem on both VMware < & > than VMware 6.0, and it run smootly for both with no new occurence ofthe bug. No regression found for Vmware < 6.0 and no occurence of a crash for VMware > 6.0

BugLink: https://bugs.launchpad.net/bugs/1780470

Eric Desrochers (1):
  VSOCK: Detach QP check should filter out non matching QPs.

Jorgen Hansen (2):
  VSOCK: sock_put wasn't safe to call in interrupt context
  VSOCK: Fix lockdep issue.

 net/vmw_vsock/vmci_transport.c | 173 ++++++++++++++++-----------------
 net/vmw_vsock/vmci_transport.h |   4 +-
 2 files changed, 86 insertions(+), 91 deletions(-)

Comments

Stefan Bader Aug. 16, 2018, 9:08 a.m. UTC | #1
On 31.07.2018 15:49, Eric Desrochers wrote:
> A "BUG: scheduling while atomic" situation randomly occur when VMware guess is running Ubuntu kernel 3.13 series and hosted on VMware 6.0 and later,
> with VMCI (Virtual Machine Communication Interface) turned on.
> 
> Upstream discussion confirms the need of the 3 upstream commits : https://patchwork.kernel.org/patch/9948741/
> The VMware author of the patch suggested a backport from upstream of 3 patches he made.
> 
> The patches has been tested for more than 3 weeks now with a user affected by this situation, without any problem on both VMware < & > than VMware 6.0, and it run smootly for both with no new occurence ofthe bug. No regression found for Vmware < 6.0 and no occurence of a crash for VMware > 6.0
> 
> BugLink: https://bugs.launchpad.net/bugs/1780470
> 
> Eric Desrochers (1):
>   VSOCK: Detach QP check should filter out non matching QPs.
> 
> Jorgen Hansen (2):
>   VSOCK: sock_put wasn't safe to call in interrupt context
>   VSOCK: Fix lockdep issue.
> 
>  net/vmw_vsock/vmci_transport.c | 173 ++++++++++++++++-----------------
>  net/vmw_vsock/vmci_transport.h |   4 +-
>  2 files changed, 86 insertions(+), 91 deletions(-)
> 
Based on successful testing and limited risk due to changes being made only to a
very specific driver.

Acked-by: Stefan Bader <stefan.bader@canonical.com>
Kleber Sacilotto de Souza Aug. 21, 2018, 12:57 p.m. UTC | #2
On 07/31/18 15:49, Eric Desrochers wrote:
> A "BUG: scheduling while atomic" situation randomly occur when VMware guess is running Ubuntu kernel 3.13 series and hosted on VMware 6.0 and later,
> with VMCI (Virtual Machine Communication Interface) turned on.
> 
> Upstream discussion confirms the need of the 3 upstream commits : https://patchwork.kernel.org/patch/9948741/
> The VMware author of the patch suggested a backport from upstream of 3 patches he made.
> 
> The patches has been tested for more than 3 weeks now with a user affected by this situation, without any problem on both VMware < & > than VMware 6.0, and it run smootly for both with no new occurence ofthe bug. No regression found for Vmware < 6.0 and no occurence of a crash for VMware > 6.0
> 
> BugLink: https://bugs.launchpad.net/bugs/1780470
> 
> Eric Desrochers (1):
>   VSOCK: Detach QP check should filter out non matching QPs.
> 
> Jorgen Hansen (2):
>   VSOCK: sock_put wasn't safe to call in interrupt context
>   VSOCK: Fix lockdep issue.
> 
>  net/vmw_vsock/vmci_transport.c | 173 ++++++++++++++++-----------------
>  net/vmw_vsock/vmci_transport.h |   4 +-
>  2 files changed, 86 insertions(+), 91 deletions(-)
> 

With the "backported from ..." fix for patch 3/3:

Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
Kleber Sacilotto de Souza Aug. 24, 2018, 10:19 a.m. UTC | #3
On 07/31/18 15:49, Eric Desrochers wrote:
> A "BUG: scheduling while atomic" situation randomly occur when VMware guess is running Ubuntu kernel 3.13 series and hosted on VMware 6.0 and later,
> with VMCI (Virtual Machine Communication Interface) turned on.
> 
> Upstream discussion confirms the need of the 3 upstream commits : https://patchwork.kernel.org/patch/9948741/
> The VMware author of the patch suggested a backport from upstream of 3 patches he made.
> 
> The patches has been tested for more than 3 weeks now with a user affected by this situation, without any problem on both VMware < & > than VMware 6.0, and it run smootly for both with no new occurence ofthe bug. No regression found for Vmware < 6.0 and no occurence of a crash for VMware > 6.0
> 
> BugLink: https://bugs.launchpad.net/bugs/1780470
> 
> Eric Desrochers (1):
>   VSOCK: Detach QP check should filter out non matching QPs.
> 
> Jorgen Hansen (2):
>   VSOCK: sock_put wasn't safe to call in interrupt context
>   VSOCK: Fix lockdep issue.
> 
>  net/vmw_vsock/vmci_transport.c | 173 ++++++++++++++++-----------------
>  net/vmw_vsock/vmci_transport.h |   4 +-
>  2 files changed, 86 insertions(+), 91 deletions(-)
> 

Applied to trusty/master-next branch, with the authorship and
"backported from ... " fixes on patch 3/3.

Thanks,
Kleber