| Message ID | 1532114623-81911-1-git-send-email-aditya@kobol.io |
|---|---|
| Headers | show |
| Series | gpio: mvebu: Add support for multiple PWM lines | expand |
Hoping for some review from Gergory, Ralph or Richard who all seem to use this driver! Yours, Linus Walleij On Fri, Jul 20, 2018 at 9:24 PM Aditya Prayoga <aditya@kobol.io> wrote: > > Hi everyone, > > Helios4, an Armada 388 based NAS SBC, provides 2 (4-pins) fan connectors. > The PWM pins on both connector are connected to GPIO on bank 1. Current gpio- > mvebu does not allow more than one PWM on the same bank. > > Aditya > > --- > > Aditya Prayoga (2): > gpio: mvebu: Add support for multiple PWM lines per GPIO chip > gpio: mvebu: Allow to use non-default PWM counter > > drivers/gpio/gpio-mvebu.c | 111 ++++++++++++++++++++++++++++++++++++++-------- > 1 file changed, 92 insertions(+), 19 deletions(-) > > -- > 2.7.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-pwm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Linus and Adita On dim., juil. 29 2018, Linus Walleij <linus.walleij@linaro.org> wrote: > Hoping for some review from Gergory, Ralph or Richard who all seem > to use this driver! Would it be possible to resend the series adding me in CC? I would like to comment the patches, but unfortunately it seems that I was in none of the mailing list where the series had been sent. I found the patches on patchwork, and started to have a look on it for example, in the patch "gpio: mvebu: Add support for multiple PWM lines per GPIO chip", I wonder why the id is stored as it was not used at all. Having the patch inlined in an email would male the review easier. Thanks, Gregory > > Yours, > Linus Walleij > > On Fri, Jul 20, 2018 at 9:24 PM Aditya Prayoga <aditya@kobol.io> wrote: >> >> Hi everyone, >> >> Helios4, an Armada 388 based NAS SBC, provides 2 (4-pins) fan connectors. >> The PWM pins on both connector are connected to GPIO on bank 1. Current gpio- >> mvebu does not allow more than one PWM on the same bank. >> >> Aditya >> >> --- >> >> Aditya Prayoga (2): >> gpio: mvebu: Add support for multiple PWM lines per GPIO chip >> gpio: mvebu: Allow to use non-default PWM counter >> >> drivers/gpio/gpio-mvebu.c | 111 ++++++++++++++++++++++++++++++++++++++-------- >> 1 file changed, 92 insertions(+), 19 deletions(-) >> >> -- >> 2.7.4 >>
On 03/08/2018 11:36, Gregory CLEMENT wrote: > Hi Linus and Adita > > On dim., juil. 29 2018, Linus Walleij <linus.walleij@linaro.org> wrote: > >> Hoping for some review from Gergory, Ralph or Richard who all seem >> to use this driver! > > Would it be possible to resend the series adding me in CC? I would > like to comment the patches, but unfortunately it seems that I was in > none of the mailing list where the series had been sent. > > I found the patches on patchwork, and started to have a look on it for > example, in the patch "gpio: mvebu: Add support for multiple PWM lines > per GPIO chip", I wonder why the id is stored as it was not used at all. > > Having the patch inlined in an email would male the review easier. Same for me :) -- To unsubscribe from this list: send the line "unsubscribe linux-pwm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 03/08/2018 11:42, Richard Genoud wrote: > On 03/08/2018 11:36, Gregory CLEMENT wrote: >> Hi Linus and Adita >> >> On dim., juil. 29 2018, Linus Walleij <linus.walleij@linaro.org> wrote: >> >>> Hoping for some review from Gergory, Ralph or Richard who all seem >>> to use this driver! >> >> Would it be possible to resend the series adding me in CC? I would >> like to comment the patches, but unfortunately it seems that I was in >> none of the mailing list where the series had been sent. >> >> I found the patches on patchwork, and started to have a look on it for >> example, in the patch "gpio: mvebu: Add support for multiple PWM lines >> per GPIO chip", I wonder why the id is stored as it was not used at all. >> >> Having the patch inlined in an email would male the review easier. > Same for me :) > Sorry, for the noise, but please use my gmail address. Thanks ! Richard -- To unsubscribe from this list: send the line "unsubscribe linux-pwm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html