mbox series

[0/4] Add dependency checking

Message ID 20180711122925.24278-1-punit.agrawal@arm.com
Headers show
Series Add dependency checking | expand

Message

Punit Agrawal July 11, 2018, 12:29 p.m. UTC 
Hi,

While investigating failures from nightly runs, I came across some
tests that don't explicitly check for dependencies.

Add appropriate check for dependencies so the tests are reported as an
issue with the configuration rather than a test failure. These set of
patches transitions ~50-60 tests from reporting failures to a
configuration issue.

Thanks,
Punit

Punit Agrawal (4):
  controllers/cgroup_fj_common.sh: Check for dependencies during setup
  quota_remount_test01: Add explicit check for dependencies
  memcg_lib.sh: Check for killall
  controllers/pids.sh: Check for killall

 testcases/kernel/controllers/cgroup_fj/cgroup_fj_common.sh | 1 +
 testcases/kernel/controllers/memcg/functional/memcg_lib.sh | 3 +++
 testcases/kernel/controllers/pids/pids.sh                  | 1 +
 testcases/kernel/fs/quota_remount/quota_remount_test01.sh  | 4 ++++
 4 files changed, 9 insertions(+)

Comments

Jan Stancek July 16, 2018, 3:52 p.m. UTC | #1 
----- Original Message -----
> Hi,
> 
> While investigating failures from nightly runs, I came across some
> tests that don't explicitly check for dependencies.
> 
> Add appropriate check for dependencies so the tests are reported as an
> issue with the configuration rather than a test failure. These set of
> patches transitions ~50-60 tests from reporting failures to a
> configuration issue.
> 
> Thanks,
> Punit
> 

Hi,

Pushed with the exception of patch 2.

Switching quota_remount_test01.sh away from apicmds will
likely need more changes, e.g. it should use at least 
tst_exit().

If we take the effort to port this test to shell library,
it should be "tst_test.h" one.

If you're up to rewriting test for tst_test.h, that would
be preffered. Otherwise, I rather use some shell check
and avoid including "test.h" for the sole purpose of having
tst_check_cmds.

Regards,
Jan
Punit Agrawal July 16, 2018, 4:20 p.m. UTC | #2 
Jan Stancek <jstancek@redhat.com> writes:

> ----- Original Message -----
>> Hi,
>> 
>> While investigating failures from nightly runs, I came across some
>> tests that don't explicitly check for dependencies.
>> 
>> Add appropriate check for dependencies so the tests are reported as an
>> issue with the configuration rather than a test failure. These set of
>> patches transitions ~50-60 tests from reporting failures to a
>> configuration issue.
>> 
>> Thanks,
>> Punit
>> 
>
> Hi,
>
> Pushed with the exception of patch 2.

Thanks for merging the patches.

> Switching quota_remount_test01.sh away from apicmds will
> likely need more changes, e.g. it should use at least 
> tst_exit().
>
> If we take the effort to port this test to shell library,
> it should be "tst_test.h" one.
>
> If you're up to rewriting test for tst_test.h, that would
> be preffered. Otherwise, I rather use some shell check
> and avoid including "test.h" for the sole purpose of having
> tst_check_cmds.

Ok, makes sense to use a shell check. I'll send an updated patch.

I won't be able to get to rewriting the test anytime soon but I'd really
like to eliminate the false positives on the nightly runs so we can
start paying attention to the real failures on new development.

Regards,
Punit