mbox series

[V2,nf,0/3] netfilter: nf_tables: fix set destroying bugs

Message ID 20180710142018.18290-1-ap420073@gmail.com
Headers show
Series netfilter: nf_tables: fix set destroying bugs | expand

Message

Taehee Yoo July 10, 2018, 2:20 p.m. UTC 
This patch series fixes nft_set_hash and nft_set_rbtree bugs.

First patch adds rcu_barrier in the nft_rhash_destroy() to wait completion of
call_rcu by GC.

Second patch fixes bugs in nft_set_rbtree.c
 - add null check routine
 - add rcu_barrier in destroy routine

Last patch adds default set->size value.
 - all types of set have 65535 as default size.

V2:
 - Drops patch "netfilter: nft_set_hash: fix panic when destroying set".
  Requested by Florian Westphal
 - Do not add interval check routine in nft_set_rbtree.
  Requested by Pablo Neira Ayuso
 - Add default set->size value instead add check set->size routine.
  Requested by Florian Westphal

Taehee Yoo (3):
  netfilter: nft_set_hash: add rcu_barrier() in the nft_rhash_destroy()
  netfilter: nft_set_rbtree: fix panic when destroying set by GC
  netfilter: nf_tables: add default set size

 net/netfilter/nf_tables_api.c  | 13 ++++++++-----
 net/netfilter/nft_dynset.c     |  6 +-----
 net/netfilter/nft_set_hash.c   |  1 +
 net/netfilter/nft_set_rbtree.c |  9 ++++++---
 4 files changed, 16 insertions(+), 13 deletions(-)

Comments

Pablo Neira Ayuso July 17, 2018, 5:03 p.m. UTC | #1 
On Tue, Jul 10, 2018 at 11:20:18PM +0900, Taehee Yoo wrote:
> This patch series fixes nft_set_hash and nft_set_rbtree bugs.
> 
> First patch adds rcu_barrier in the nft_rhash_destroy() to wait completion of
> call_rcu by GC.
> 
> Second patch fixes bugs in nft_set_rbtree.c
>  - add null check routine
>  - add rcu_barrier in destroy routine
> 
> Last patch adds default set->size value.
>  - all types of set have 65535 as default size.

Series applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html