mbox series

[SRU,Bionic,0/1] Fix for LP: #1753941

Message ID 20180710111345.28481-1-kleber.souza@canonical.com
Headers show
Series Fix for LP: #1753941 | expand

Message

Kleber Sacilotto de Souza July 10, 2018, 11:13 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1753941

== SRU Justification ==
The ubuntu_bpf_jit test will fail with the following 5 test cases:

test_bpf: #292 BPF_MAXINSNS: Ctx heavy transformations FAIL to prog_create err=-524 len=4096
test_bpf: #293 BPF_MAXINSNS: Call heavy transformations FAIL to prog_create err=-524 len=4096
test_bpf: #298 BPF_MAXINSNS: ld_abs+get_processor_id FAIL to prog_create err=-524 len=4096
test_bpf: #299 BPF_MAXINSNS: ld_abs+vlan_push/pop FAIL to select_runtime err=-524
test_bpf: #300 BPF_MAXINSNS: jump around ld_abs FAIL to select_runtime err=-524

test_bpf: Summary: 337 PASSED, 5 FAILED, [329/329 JIT'ed]

And modprobe error can be found in the report as well:
modprobe: ERROR: could not insert 'test_bpf': Invalid argument

Issue can be reproduce on both zVM and Ubuntu on LPAR s390x systems.

== Fix ==
3203c9010060 ("test_bpf: flag tests that cannot be jited on s390")

A backport of the fix is needed to compile out "BPF_MAXINSNS:
ld_abs+vlan_push/pop" and "BPF_MAXINSNS: jump around ld_abs" testcases. They
have been removed from lib/test_bpf.c with 93731ef086ce ("bpf: migrate ebpf
ld_abs/ld_ind tests to test_verifier"), however, backporting this patch would
require pulling other patches as prereqs.

== Regression Potential ==
None, the fix is in a test module and only masks failing testcases on s390 only.

== Test Case ==
Load the test_bpf module, it should load without errors.

Kleber Sacilotto de Souza (1):
  test_bpf: flag tests that cannot be jited on s390

 lib/test_bpf.c | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

Comments

Kleber Sacilotto de Souza July 31, 2018, 2:38 p.m. UTC | #1
On 07/10/18 13:13, Kleber Sacilotto de Souza wrote:
> BugLink: https://bugs.launchpad.net/bugs/1753941
> 
> == SRU Justification ==
> The ubuntu_bpf_jit test will fail with the following 5 test cases:
> 
> test_bpf: #292 BPF_MAXINSNS: Ctx heavy transformations FAIL to prog_create err=-524 len=4096
> test_bpf: #293 BPF_MAXINSNS: Call heavy transformations FAIL to prog_create err=-524 len=4096
> test_bpf: #298 BPF_MAXINSNS: ld_abs+get_processor_id FAIL to prog_create err=-524 len=4096
> test_bpf: #299 BPF_MAXINSNS: ld_abs+vlan_push/pop FAIL to select_runtime err=-524
> test_bpf: #300 BPF_MAXINSNS: jump around ld_abs FAIL to select_runtime err=-524
> 
> test_bpf: Summary: 337 PASSED, 5 FAILED, [329/329 JIT'ed]
> 
> And modprobe error can be found in the report as well:
> modprobe: ERROR: could not insert 'test_bpf': Invalid argument
> 
> Issue can be reproduce on both zVM and Ubuntu on LPAR s390x systems.
> 
> == Fix ==
> 3203c9010060 ("test_bpf: flag tests that cannot be jited on s390")
> 
> A backport of the fix is needed to compile out "BPF_MAXINSNS:
> ld_abs+vlan_push/pop" and "BPF_MAXINSNS: jump around ld_abs" testcases. They
> have been removed from lib/test_bpf.c with 93731ef086ce ("bpf: migrate ebpf
> ld_abs/ld_ind tests to test_verifier"), however, backporting this patch would
> require pulling other patches as prereqs.
> 
> == Regression Potential ==
> None, the fix is in a test module and only masks failing testcases on s390 only.
> 
> == Test Case ==
> Load the test_bpf module, it should load without errors.
> 
> Kleber Sacilotto de Souza (1):
>   test_bpf: flag tests that cannot be jited on s390
> 
>  lib/test_bpf.c | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 

Applied to bionic/master-next branch.

Thanks,
Kleber