| Message ID | cover.1530766981.git.viresh.kumar@linaro.org |
|---|---|
| Headers | show |
| Series | dt: thermal: Fix broken cooling-maps | expand |
On 05/07/2018 07:09, Viresh Kumar wrote: > Each CPU can (and does) participate in cooling down the system but the > DT only captures the CPU0 in the cooling maps. Things work by chance as > under normal circumstances its the CPU0 which is used by the operating > systems to probe the cooling devices. But as soon as that ordering > changes and any other CPU is used to bring up the cooling device, we > will start seeing errors. > > On the other hand, the hardware is partially defined in DT in these > cases and we must do a better job by capturing all devices. > > Add all devices (CPUs here) in the cooling maps which are also affected > by the trip point. > > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org> > --- > arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi > index 247024df714f..919d36b91bf3 100644 > --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi > +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi > @@ -886,7 +886,14 @@ > cooling-maps { > map0 { > trip = <&target>; > - cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > + cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&cpu2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&cpu4 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&cpu5 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&cpu6 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&cpu7 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > }; > }; > }; >
Hi Viresh, On 2018/7/5 6:09, Viresh Kumar wrote: > Hi, > > This is an attempt to fix the broken or partially defined DT bindings > for cooling-maps. We should list every device that participates in > cooling down at a certain trip point, instead of just the first in the > list as that depends on certain ordering of events to work properly. > > The first patch extends the binding to allow a list of phandles in > "cooling-device" property and the second patch fixes one of the > platform's DT. > > This will be followed up by fixing all platform DT bindings that have > these issues after this set is accepted. > > The kernel also requires some changes to handle the phandle list, but > wouldn't break with these changes as it reads the first phandle in the > list for now. We can update that separately. > > -- > viresh > > Viresh Kumar (2): > dt-bindings: thermal: Allow multiple devices to share cooling map > arm64: dts: hi6220: Add all CPUs in cooling maps > > Documentation/devicetree/bindings/thermal/thermal.txt | 11 +++-------- > arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 9 ++++++++- > 2 files changed, 11 insertions(+), 9 deletions(-) > Thanks! Applied both to the hisilicon dt tree. Best Regards, Wei -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 18-07-18, 16:34, Wei Xu wrote: > Hi Viresh, > > On 2018/7/5 6:09, Viresh Kumar wrote: > > Hi, > > > > This is an attempt to fix the broken or partially defined DT bindings > > for cooling-maps. We should list every device that participates in > > cooling down at a certain trip point, instead of just the first in the > > list as that depends on certain ordering of events to work properly. > > > > The first patch extends the binding to allow a list of phandles in > > "cooling-device" property and the second patch fixes one of the > > platform's DT. > > > > This will be followed up by fixing all platform DT bindings that have > > these issues after this set is accepted. > > > > The kernel also requires some changes to handle the phandle list, but > > wouldn't break with these changes as it reads the first phandle in the > > list for now. We can update that separately. > > > > -- > > viresh > > > > Viresh Kumar (2): > > dt-bindings: thermal: Allow multiple devices to share cooling map > > arm64: dts: hi6220: Add all CPUs in cooling maps > > > > Documentation/devicetree/bindings/thermal/thermal.txt | 11 +++-------- > > arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 9 ++++++++- > > 2 files changed, 11 insertions(+), 9 deletions(-) > > > > Thanks! > Applied both to the hisilicon dt tree. Hi Wei, I expected the first patch to go via the thermal tree as it is for the thermal core maintainers. Second patch can very well go from your tree, but only after the 1st one is applied by thermal maintainers.
Hi Viresh, On 2018/7/19 3:40, Viresh Kumar wrote: > On 18-07-18, 16:34, Wei Xu wrote: >> Hi Viresh, >> >> On 2018/7/5 6:09, Viresh Kumar wrote: >>> Hi, >>> >>> This is an attempt to fix the broken or partially defined DT bindings >>> for cooling-maps. We should list every device that participates in >>> cooling down at a certain trip point, instead of just the first in the >>> list as that depends on certain ordering of events to work properly. >>> >>> The first patch extends the binding to allow a list of phandles in >>> "cooling-device" property and the second patch fixes one of the >>> platform's DT. >>> >>> This will be followed up by fixing all platform DT bindings that have >>> these issues after this set is accepted. >>> >>> The kernel also requires some changes to handle the phandle list, but >>> wouldn't break with these changes as it reads the first phandle in the >>> list for now. We can update that separately. >>> >>> -- >>> viresh >>> >>> Viresh Kumar (2): >>> dt-bindings: thermal: Allow multiple devices to share cooling map >>> arm64: dts: hi6220: Add all CPUs in cooling maps >>> >>> Documentation/devicetree/bindings/thermal/thermal.txt | 11 +++-------- >>> arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 9 ++++++++- >>> 2 files changed, 11 insertions(+), 9 deletions(-) >>> >> >> Thanks! >> Applied both to the hisilicon dt tree. > > Hi Wei, > > I expected the first patch to go via the thermal tree as it is for the > thermal core maintainers. Second patch can very well go from your > tree, but only after the 1st one is applied by thermal maintainers. > OK. I will drop them in the pull request and apply the dts patch later. Best Regards, Wei -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 05-07-18, 10:39, Viresh Kumar wrote: > Hi, > > This is an attempt to fix the broken or partially defined DT bindings > for cooling-maps. We should list every device that participates in > cooling down at a certain trip point, instead of just the first in the > list as that depends on certain ordering of events to work properly. > > The first patch extends the binding to allow a list of phandles in > "cooling-device" property and the second patch fixes one of the > platform's DT. > > This will be followed up by fixing all platform DT bindings that have > these issues after this set is accepted. > > The kernel also requires some changes to handle the phandle list, but > wouldn't break with these changes as it reads the first phandle in the > list for now. We can update that separately. @Zhang: Are you going to apply this for 4.19-rc1 ? There are lot of patches that I am holding up until this gets merged.
On 二, 2018-07-31 at 10:21 +0530, Viresh Kumar wrote: > On 05-07-18, 10:39, Viresh Kumar wrote: > > > > Hi, > > > > This is an attempt to fix the broken or partially defined DT > > bindings > > for cooling-maps. We should list every device that participates in > > cooling down at a certain trip point, instead of just the first in > > the > > list as that depends on certain ordering of events to work > > properly. > > > > The first patch extends the binding to allow a list of phandles in > > "cooling-device" property and the second patch fixes one of the > > platform's DT. > > > > This will be followed up by fixing all platform DT bindings that > > have > > these issues after this set is accepted. > > > > The kernel also requires some changes to handle the phandle list, > > but > > wouldn't break with these changes as it reads the first phandle in > > the > > list for now. We can update that separately. > @Zhang: Are you going to apply this for 4.19-rc1 ? There are lot of > patches that > I am holding up until this gets merged, > I suppose this patch should go via Eduardo' tree. Eduardo, can you please take a look at this patch set? thanks, rui -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 31-07-18, 14:00, Zhang Rui wrote: > I suppose this patch should go via Eduardo' tree. > Eduardo, can you please take a look at this patch set? Zhang, Since Eduardo isn't replying, will it be possible for you to pick it up as I don't want to miss 4.19-rc1.
On 五, 2018-08-03 at 14:10 +0530, Viresh Kumar wrote: > On 31-07-18, 14:00, Zhang Rui wrote: > > > > I suppose this patch should go via Eduardo' tree. > > Eduardo, can you please take a look at this patch set? > Zhang, > > Since Eduardo isn't replying, will it be possible for you to pick it > up as I > don't want to miss 4.19-rc1. > Okay, I will keep queue it in my tree first. thanks, rui -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html