| Message ID | 20180703083808.15858-1-kai.heng.feng@canonical.com |
|---|---|
| Headers | show |
| Series | Fix "xhci_hcd 0000:00:14.0: Root hub is not suspended" | expand |
On 03.07.2018 11:38, Kai-Heng Feng wrote: > BugLink: https://bugs.launchpad.net/bugs/1779823 > > [Impact] > Runtime suspended xHC keeps spewing out this message: > xhci_hcd 0000:00:14.0: Root hub is not suspended > > [Test] > With the fix, the message stops. > > [Fix] > Only decrement PM counter when DBC was started. > > [Regression Potential] > Low. It fixes the overlooked logic. > > Kai-Heng Feng (1): > usb: xhci: dbc: Don't decrement runtime PM counter if DBC is not > started > > Lu Baolu (1): > usb: xhci: dbc: Fix lockdep warning > > drivers/usb/host/xhci-dbgcap.c | 32 ++++++++++++++++++++------------ > drivers/usb/host/xhci-dbgtty.c | 20 ++++++++++++-------- > 2 files changed, 32 insertions(+), 20 deletions(-) applied to oem-b oem-next
Clean cherry-pick.
Acked-by: Po-Hsu Lin <po-hsu.lin@canonical.com>
On Tue, Jul 03, 2018 at 04:38:06PM +0800, Kai-Heng Feng wrote: > BugLink: https://bugs.launchpad.net/bugs/1779823 > > [Impact] > Runtime suspended xHC keeps spewing out this message: > xhci_hcd 0000:00:14.0: Root hub is not suspended > > [Test] > With the fix, the message stops. > > [Fix] > Only decrement PM counter when DBC was started. > > [Regression Potential] > Low. It fixes the overlooked logic. Clean cherry picks, looks reasonable. Acked-by: Seth Forshee <seth.forshee@canonical.com> Patch 1 was in 4.16. Applied patch 2 to cosmic/master-next and unstable/master, thanks!
On 07/03/18 10:38, Kai-Heng Feng wrote: > BugLink: https://bugs.launchpad.net/bugs/1779823 > > [Impact] > Runtime suspended xHC keeps spewing out this message: > xhci_hcd 0000:00:14.0: Root hub is not suspended > > [Test] > With the fix, the message stops. > > [Fix] > Only decrement PM counter when DBC was started. > > [Regression Potential] > Low. It fixes the overlooked logic. > > Kai-Heng Feng (1): > usb: xhci: dbc: Don't decrement runtime PM counter if DBC is not > started > > Lu Baolu (1): > usb: xhci: dbc: Fix lockdep warning > > drivers/usb/host/xhci-dbgcap.c | 32 ++++++++++++++++++++------------ > drivers/usb/host/xhci-dbgtty.c | 20 ++++++++++++-------- > 2 files changed, 32 insertions(+), 20 deletions(-) > Applied to bionic/master-next branch. Thanks, Kleber
BugLink: https://bugs.launchpad.net/bugs/1779823 [Impact] Runtime suspended xHC keeps spewing out this message: xhci_hcd 0000:00:14.0: Root hub is not suspended [Test] With the fix, the message stops. [Fix] Only decrement PM counter when DBC was started. [Regression Potential] Low. It fixes the overlooked logic. Kai-Heng Feng (1): usb: xhci: dbc: Don't decrement runtime PM counter if DBC is not started Lu Baolu (1): usb: xhci: dbc: Fix lockdep warning drivers/usb/host/xhci-dbgcap.c | 32 ++++++++++++++++++++------------ drivers/usb/host/xhci-dbgtty.c | 20 ++++++++++++-------- 2 files changed, 32 insertions(+), 20 deletions(-)