mbox series

[0/1,SRU,Bionic] Fix Nvidia fails after switching its mode

Message ID 20180626075530.9200-1-acelan.kao@canonical.com
Headers show
Series Fix Nvidia fails after switching its mode | expand

Message

AceLan Kao June 26, 2018, 7:55 a.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/1778658

[Impact]
Switch Nvidia mode requires rebooting the system. It's because of
losing some of its states while switching mode if runtime PM is enabled.
It's a generic issue that would happen on some other devices, too.
This patch restores devices' config space on runtime resume.

[Test]
Test and verify it on machines with Nvidia discrete graphics.

[Fix]
Fix by saving and restoring config space over a runtime suspend cycle
even if the device is not bound.

[Regression Potential]
Low. It just saves and restores states during suspending and resuming.

Rafael J. Wysocki (1):
  PCI: Restore config space on runtime resume despite being unbound

 drivers/pci/pci-driver.c | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)

Comments

Anthony Wong June 28, 2018, 3:18 p.m. UTC | #1 
On Tue, Jun 26, 2018 at 03:55:29PM +0800, AceLan Kao wrote:
> BugLink: https://bugs.launchpad.net/bugs/1778658
> 
> [Impact]
> Switch Nvidia mode requires rebooting the system. It's because of
> losing some of its states while switching mode if runtime PM is enabled.
> It's a generic issue that would happen on some other devices, too.
> This patch restores devices' config space on runtime resume.
> 
> [Test]
> Test and verify it on machines with Nvidia discrete graphics.
> 
> [Fix]
> Fix by saving and restoring config space over a runtime suspend cycle
> even if the device is not bound.
> 
> [Regression Potential]
> Low. It just saves and restores states during suspending and resuming.
> 
> Rafael J. Wysocki (1):
>   PCI: Restore config space on runtime resume despite being unbound
> 
>  drivers/pci/pci-driver.c | 17 +++++++++++------
>  1 file changed, 11 insertions(+), 6 deletions(-)

Looks good, clean cherry-pick.

Acked-by: Anthony Wong <anthony.wong@canonical.com>
Kleber Sacilotto de Souza July 27, 2018, 1:47 p.m. UTC | #2 
On 06/26/18 09:55, AceLan Kao wrote:
> BugLink: https://bugs.launchpad.net/bugs/1778658
> 
> [Impact]
> Switch Nvidia mode requires rebooting the system. It's because of
> losing some of its states while switching mode if runtime PM is enabled.
> It's a generic issue that would happen on some other devices, too.
> This patch restores devices' config space on runtime resume.
> 
> [Test]
> Test and verify it on machines with Nvidia discrete graphics.
> 
> [Fix]
> Fix by saving and restoring config space over a runtime suspend cycle
> even if the device is not bound.
> 
> [Regression Potential]
> Low. It just saves and restores states during suspending and resuming.
> 
> Rafael J. Wysocki (1):
>   PCI: Restore config space on runtime resume despite being unbound
> 
>  drivers/pci/pci-driver.c | 17 +++++++++++------
>  1 file changed, 11 insertions(+), 6 deletions(-)
> 

Applied to bionic/master-next branch.

Thanks,
Kleber