| Message ID | cover.1528477213.git.joseph.salisbury@canonical.com |
|---|---|
| Headers | show |
| Series | Fixes for LP:1774225 | expand |
On 06/22/18 19:49, Joseph Salisbury wrote: > == SRU Justification == > 6Wind is requesting these three patches. The patches fix a bug that prevents a user > from following an interface that moves to another netns. > > These commits are also needed in Xenial. However, they will be sent in > a separate SRU request due to additional prereq commits being needed for > Xenial. > > == Fixes == > b2d3bcfa26a7 ("net: core: Expose number of link up/down transitions") > c36ac8e23073 ("dev: always advertise the new nsid when the netns iface changes") > 38e01b30563a ("dev: advertise the new ifindex when the netns iface changes") > > == Regression Potential == > Medium due to three patches needed and the changes to core networking. > > == Test Case == > A test kernel was built with these patches and tested by the original bug reporter. > The bug reporter states the test kernel resolved the bug. > > David Decotigny (1): > net: core: Expose number of link up/down transitions > > Nicolas Dichtel (2): > dev: always advertise the new nsid when the netns iface changes > dev: advertise the new ifindex when the netns iface changes > > Documentation/ABI/testing/sysfs-class-net | 24 +++++++++++++++++ > include/linux/netdevice.h | 6 +++-- > include/linux/rtnetlink.h | 5 ++-- > include/uapi/linux/if_link.h | 3 +++ > net/core/dev.c | 22 +++++++++------- > net/core/net-sysfs.c | 25 +++++++++++++++++- > net/core/rtnetlink.c | 44 ++++++++++++++++++++++--------- > net/sched/sch_generic.c | 4 +-- > 8 files changed, 103 insertions(+), 30 deletions(-) > The patches look safe to pull in. Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
On 22.06.2018 19:49, Joseph Salisbury wrote: > == SRU Justification == > 6Wind is requesting these three patches. The patches fix a bug that prevents a user > from following an interface that moves to another netns. > > These commits are also needed in Xenial. However, they will be sent in > a separate SRU request due to additional prereq commits being needed for > Xenial. > > == Fixes == > b2d3bcfa26a7 ("net: core: Expose number of link up/down transitions") > c36ac8e23073 ("dev: always advertise the new nsid when the netns iface changes") > 38e01b30563a ("dev: advertise the new ifindex when the netns iface changes") > > == Regression Potential == > Medium due to three patches needed and the changes to core networking. > > == Test Case == > A test kernel was built with these patches and tested by the original bug reporter. > The bug reporter states the test kernel resolved the bug. > > David Decotigny (1): > net: core: Expose number of link up/down transitions > > Nicolas Dichtel (2): > dev: always advertise the new nsid when the netns iface changes > dev: advertise the new ifindex when the netns iface changes > > Documentation/ABI/testing/sysfs-class-net | 24 +++++++++++++++++ > include/linux/netdevice.h | 6 +++-- > include/linux/rtnetlink.h | 5 ++-- > include/uapi/linux/if_link.h | 3 +++ > net/core/dev.c | 22 +++++++++------- > net/core/net-sysfs.c | 25 +++++++++++++++++- > net/core/rtnetlink.c | 44 ++++++++++++++++++++++--------- > net/sched/sch_generic.c | 4 +-- > 8 files changed, 103 insertions(+), 30 deletions(-) > Acked-by: Stefan Bader <stefan.bader@canonical.com> Joe, could you please add the SRU justification to the bug description, too. Potentially will later need extension to the fix/regression potential sections once this is clear with Xenial. Thanks, Stefan
On 06/22/18 19:49, Joseph Salisbury wrote: > == SRU Justification == > 6Wind is requesting these three patches. The patches fix a bug that prevents a user > from following an interface that moves to another netns. > > These commits are also needed in Xenial. However, they will be sent in > a separate SRU request due to additional prereq commits being needed for > Xenial. > > == Fixes == > b2d3bcfa26a7 ("net: core: Expose number of link up/down transitions") > c36ac8e23073 ("dev: always advertise the new nsid when the netns iface changes") > 38e01b30563a ("dev: advertise the new ifindex when the netns iface changes") > > == Regression Potential == > Medium due to three patches needed and the changes to core networking. > > == Test Case == > A test kernel was built with these patches and tested by the original bug reporter. > The bug reporter states the test kernel resolved the bug. > > David Decotigny (1): > net: core: Expose number of link up/down transitions > > Nicolas Dichtel (2): > dev: always advertise the new nsid when the netns iface changes > dev: advertise the new ifindex when the netns iface changes > > Documentation/ABI/testing/sysfs-class-net | 24 +++++++++++++++++ > include/linux/netdevice.h | 6 +++-- > include/linux/rtnetlink.h | 5 ++-- > include/uapi/linux/if_link.h | 3 +++ > net/core/dev.c | 22 +++++++++------- > net/core/net-sysfs.c | 25 +++++++++++++++++- > net/core/rtnetlink.c | 44 ++++++++++++++++++++++--------- > net/sched/sch_generic.c | 4 +-- > 8 files changed, 103 insertions(+), 30 deletions(-) > Applied to bionic/master-next branch. Thanks, Kleber
== SRU Justification == 6Wind is requesting these three patches. The patches fix a bug that prevents a user from following an interface that moves to another netns. These commits are also needed in Xenial. However, they will be sent in a separate SRU request due to additional prereq commits being needed for Xenial. == Fixes == b2d3bcfa26a7 ("net: core: Expose number of link up/down transitions") c36ac8e23073 ("dev: always advertise the new nsid when the netns iface changes") 38e01b30563a ("dev: advertise the new ifindex when the netns iface changes") == Regression Potential == Medium due to three patches needed and the changes to core networking. == Test Case == A test kernel was built with these patches and tested by the original bug reporter. The bug reporter states the test kernel resolved the bug. David Decotigny (1): net: core: Expose number of link up/down transitions Nicolas Dichtel (2): dev: always advertise the new nsid when the netns iface changes dev: advertise the new ifindex when the netns iface changes Documentation/ABI/testing/sysfs-class-net | 24 +++++++++++++++++ include/linux/netdevice.h | 6 +++-- include/linux/rtnetlink.h | 5 ++-- include/uapi/linux/if_link.h | 3 +++ net/core/dev.c | 22 +++++++++------- net/core/net-sysfs.c | 25 +++++++++++++++++- net/core/rtnetlink.c | 44 ++++++++++++++++++++++--------- net/sched/sch_generic.c | 4 +-- 8 files changed, 103 insertions(+), 30 deletions(-)