mbox series

[0/4] gpio: aspeed: Fixes and support for sharing with co-processor

Message ID 20180612001043.9327-1-benh@kernel.crashing.org
Headers show
Series gpio: aspeed: Fixes and support for sharing with co-processor | expand

Message

Benjamin Herrenschmidt June 12, 2018, 12:10 a.m. UTC
This series cleans up the register accessors a bit, adds missing ones,
fixes the access to the write latch and finally adds an interface
that a co-processor driver can use to change the owner of some of
the GPIO lines and arbitrate access to shared GPIO banks.

Comments

Linus Walleij June 14, 2018, 9:01 a.m. UTC | #1
On Tue, Jun 12, 2018 at 2:10 AM, Benjamin Herrenschmidt
<benh@kernel.crashing.org> wrote:

> This series cleans up the register accessors a bit, adds missing ones,
> fixes the access to the write latch and finally adds an interface
> that a co-processor driver can use to change the owner of some of
> the GPIO lines and arbitrate access to shared GPIO banks.

I'm pretty happy with the series as long as they have Joel's consent/ACK
which seems doable. See comment about using gpiolib internals which I
do not think is necessary.

Yours,
Linus Walleij
Benjamin Herrenschmidt June 14, 2018, 11:42 p.m. UTC | #2
On Thu, 2018-06-14 at 11:01 +0200, Linus Walleij wrote:
> On Tue, Jun 12, 2018 at 2:10 AM, Benjamin Herrenschmidt
> <benh@kernel.crashing.org> wrote:
> 
> > This series cleans up the register accessors a bit, adds missing ones,
> > fixes the access to the write latch and finally adds an interface
> > that a co-processor driver can use to change the owner of some of
> > the GPIO lines and arbitrate access to shared GPIO banks.
> 
> I'm pretty happy with the series as long as they have Joel's consent/ACK
> which seems doable. See comment about using gpiolib internals which I
> do not think is necessary.

Thanks. Yes I need to address Joel's comments, I was waiting for your
review before posting a v2.

As for the gpiolib internals, it's unfortunate, see my other email, I'm
happy to change that if you can suggest an alternative approach...

Cheers,
Ben.