mbox series

[RFC,0/2] mkfs.ubifs: Implement selinux labelling support

Message ID 1528277940-30919-1-git-send-email-riteshh@codeaurora.org
Headers show
Series mkfs.ubifs: Implement selinux labelling support | expand

Message

Ritesh Harjani June 6, 2018, 9:38 a.m. UTC 
Hi All, 

This patchset implements the selinux context labelling support
in mkfs.ubifs utility which was discussed here [1].
Patchset is based upon previous work done by John [2].
Commit texts should explain about the change description.

I have tested this on my 4.9 kernel NAND based internal device with
UBIFS and selinux enabled. With this we are able to set the
respective selinux labels based on the input file_context provided
in mkfs.ubifs command.

[1]:- http://lists.infradead.org/pipermail/linux-mtd/2018-May/081138.html
[2]:- http://lists.infradead.org/pipermail/linux-mtd/2014-February/052136.html

Ritesh Harjani (2):
  mkfs.ubifs: add_xattr is not depending on host XATTR support
  mkfs.ubifs: Implement selinux labelling support in mkfs.ubifs.

 Makefile.am                         |   4 +
 configure.ac                        |  27 +++++
 ubifs-utils/Makemodule.am           |   4 +-
 ubifs-utils/mkfs.ubifs/mkfs.ubifs.c | 197 ++++++++++++++++++++++++++++--------
 4 files changed, 189 insertions(+), 43 deletions(-)

Comments

Ritesh Harjani June 11, 2018, 4:27 a.m. UTC | #1 
Gentle reminder!!

Regards

Ritesh


On 6/6/2018 3:08 PM, Ritesh Harjani wrote:
> Hi All,
>
> This patchset implements the selinux context labelling support
> in mkfs.ubifs utility which was discussed here [1].
> Patchset is based upon previous work done by John [2].
> Commit texts should explain about the change description.
>
> I have tested this on my 4.9 kernel NAND based internal device with
> UBIFS and selinux enabled. With this we are able to set the
> respective selinux labels based on the input file_context provided
> in mkfs.ubifs command.
>
> [1]:- http://lists.infradead.org/pipermail/linux-mtd/2018-May/081138.html
> [2]:- http://lists.infradead.org/pipermail/linux-mtd/2014-February/052136.html
>
> Ritesh Harjani (2):
>    mkfs.ubifs: add_xattr is not depending on host XATTR support
>    mkfs.ubifs: Implement selinux labelling support in mkfs.ubifs.
>
>   Makefile.am                         |   4 +
>   configure.ac                        |  27 +++++
>   ubifs-utils/Makemodule.am           |   4 +-
>   ubifs-utils/mkfs.ubifs/mkfs.ubifs.c | 197 ++++++++++++++++++++++++++++--------
>   4 files changed, 189 insertions(+), 43 deletions(-)
>
Richard Weinberger June 11, 2018, 7 a.m. UTC | #2 
Am Montag, 11. Juni 2018, 06:27:20 CEST schrieb Ritesh Harjani:
> Gentle reminder!!

"gentle" with two exclamation marks? ...

Please give David at least a full week before pushing.

Thanks,
//richard
Ritesh Harjani June 11, 2018, 11:23 a.m. UTC | #3 
On 6/11/2018 12:30 PM, Richard Weinberger wrote:
> Am Montag, 11. Juni 2018, 06:27:20 CEST schrieb Ritesh Harjani:
>> Gentle reminder!!
> "gentle" with two exclamation marks? ...
This was just out of habit.
>
> Please give David at least a full week before pushing.
Sorry about that. No intention of pushing :)

Thanks
Ritesh
David Oberhollenzer June 14, 2018, 7:33 a.m. UTC | #4 
Hi,


sorry for the delay. I was quite busy during the last week and got a little
less done than I expected. Also, it took me a little more time for closer
inspection, since the patch set conflicted with another big mkfs.ubifs
patch set that I have lying around on my end.

The changes look good to me so far. I pushed it to mtd-utils.git master.


Thanks,

David
Ritesh Harjani June 14, 2018, 11:31 a.m. UTC | #5 
On 6/14/2018 1:03 PM, David Oberhollenzer wrote:
> Hi,
>
>
> sorry for the delay. I was quite busy during the last week and got a little
> less done than I expected. Also, it took me a little more time for closer
> inspection, since the patch set conflicted with another big mkfs.ubifs
> patch set that I have lying around on my end.
Np. Thanks for the review.
>
> The changes look good to me so far. I pushed it to mtd-utils.git master.
Sure thanks.
>
>
> Thanks,
>
> David
>
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/