mbox series

[SRU,Bionic,0/3] Fixes for LP:1768143

Message ID cover.1525385262.git.joseph.salisbury@canonical.com
Headers show
Series Fixes for LP:1768143 | expand

Message

Joseph Salisbury June 1, 2018, 4:07 p.m. UTC
BugLink: http://bugs.launchpad.net/bugs/1768143

== SRU Justification ==
Recently, a couple of fixes went in vmxnet3 driver related to LRO, transmit
reset and rxvlan disabled fix. These fixes are being requested in 
Bionic and Xenial.

The Xenial patches are slightly different, so they will be SRU'd
separatly.

A backport was needed to update version info in vmxnet3_int.h

== Fixes ==
7a4c003d6921 ("vmxnet3: avoid xmit reset due to a race in vmxnet3)"
034f40579389 ("vmxnet3: use correct flag to indicate LRO feature")
65ec0bd1c7c1 ("vmxnet3: fix incorrect dereference when rxvlan is disabled")

== Regression Potential ==
Low.  Limited to vmxnet3 driver.

== Test Case ==
A test kernel was built with these patches and tested by the original bug reporter.
The bug reporter states the test kernel resolved the bug.


Ronak Doshi (3):
  vmxnet3: avoid xmit reset due to a race in vmxnet3
  vmxnet3: use correct flag to indicate LRO feature
  vmxnet3: fix incorrect dereference when rxvlan is disabled

 drivers/net/vmxnet3/vmxnet3_drv.c | 33 +++++++++++++++++++++++----------
 drivers/net/vmxnet3/vmxnet3_int.h |  5 ++---
 2 files changed, 25 insertions(+), 13 deletions(-)

Comments

Kleber Sacilotto de Souza June 5, 2018, 7:12 p.m. UTC | #1
On 06/01/18 09:07, Joseph Salisbury wrote:
> BugLink: http://bugs.launchpad.net/bugs/1768143
> 
> == SRU Justification ==
> Recently, a couple of fixes went in vmxnet3 driver related to LRO, transmit
> reset and rxvlan disabled fix. These fixes are being requested in 
> Bionic and Xenial.
> 
> The Xenial patches are slightly different, so they will be SRU'd
> separatly.
> 
> A backport was needed to update version info in vmxnet3_int.h
> 
> == Fixes ==
> 7a4c003d6921 ("vmxnet3: avoid xmit reset due to a race in vmxnet3)"
> 034f40579389 ("vmxnet3: use correct flag to indicate LRO feature")
> 65ec0bd1c7c1 ("vmxnet3: fix incorrect dereference when rxvlan is disabled")
> 
> == Regression Potential ==
> Low.  Limited to vmxnet3 driver.
> 
> == Test Case ==
> A test kernel was built with these patches and tested by the original bug reporter.
> The bug reporter states the test kernel resolved the bug.
> 
> 
> Ronak Doshi (3):
>   vmxnet3: avoid xmit reset due to a race in vmxnet3
>   vmxnet3: use correct flag to indicate LRO feature
>   vmxnet3: fix incorrect dereference when rxvlan is disabled
> 
>  drivers/net/vmxnet3/vmxnet3_drv.c | 33 +++++++++++++++++++++++----------
>  drivers/net/vmxnet3/vmxnet3_int.h |  5 ++---
>  2 files changed, 25 insertions(+), 13 deletions(-)
> 

Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
Stefan Bader June 5, 2018, 7:27 p.m. UTC | #2
On 01.06.2018 09:07, Joseph Salisbury wrote:
> BugLink: http://bugs.launchpad.net/bugs/1768143
> 
> == SRU Justification ==
> Recently, a couple of fixes went in vmxnet3 driver related to LRO, transmit
> reset and rxvlan disabled fix. These fixes are being requested in 
> Bionic and Xenial.
> 
> The Xenial patches are slightly different, so they will be SRU'd
> separatly.
> 
> A backport was needed to update version info in vmxnet3_int.h
> 
> == Fixes ==
> 7a4c003d6921 ("vmxnet3: avoid xmit reset due to a race in vmxnet3)"
> 034f40579389 ("vmxnet3: use correct flag to indicate LRO feature")
> 65ec0bd1c7c1 ("vmxnet3: fix incorrect dereference when rxvlan is disabled")
> 
> == Regression Potential ==
> Low.  Limited to vmxnet3 driver.
> 
> == Test Case ==
> A test kernel was built with these patches and tested by the original bug reporter.
> The bug reporter states the test kernel resolved the bug.
> 
> 
> Ronak Doshi (3):
>   vmxnet3: avoid xmit reset due to a race in vmxnet3
>   vmxnet3: use correct flag to indicate LRO feature
>   vmxnet3: fix incorrect dereference when rxvlan is disabled
> 
>  drivers/net/vmxnet3/vmxnet3_drv.c | 33 +++++++++++++++++++++++----------
>  drivers/net/vmxnet3/vmxnet3_int.h |  5 ++---
>  2 files changed, 25 insertions(+), 13 deletions(-)
> 
Patches looked technically ok, just should change the "back ported" in the first
patch to "backported". IIRC that is the string some other scripts use to match
and find the origin of a patch.


Acked-by: Stefan Bader <stefan.bader@canonical.com>
Khalid Elmously June 7, 2018, 10:07 p.m. UTC | #3
Applied to Bionic


On 2018-06-01 12:07:25 , Joseph Salisbury wrote:
> BugLink: http://bugs.launchpad.net/bugs/1768143
> 
> == SRU Justification ==
> Recently, a couple of fixes went in vmxnet3 driver related to LRO, transmit
> reset and rxvlan disabled fix. These fixes are being requested in 
> Bionic and Xenial.
> 
> The Xenial patches are slightly different, so they will be SRU'd
> separatly.
> 
> A backport was needed to update version info in vmxnet3_int.h
> 
> == Fixes ==
> 7a4c003d6921 ("vmxnet3: avoid xmit reset due to a race in vmxnet3)"
> 034f40579389 ("vmxnet3: use correct flag to indicate LRO feature")
> 65ec0bd1c7c1 ("vmxnet3: fix incorrect dereference when rxvlan is disabled")
> 
> == Regression Potential ==
> Low.  Limited to vmxnet3 driver.
> 
> == Test Case ==
> A test kernel was built with these patches and tested by the original bug reporter.
> The bug reporter states the test kernel resolved the bug.
> 
> 
> Ronak Doshi (3):
>   vmxnet3: avoid xmit reset due to a race in vmxnet3
>   vmxnet3: use correct flag to indicate LRO feature
>   vmxnet3: fix incorrect dereference when rxvlan is disabled
> 
>  drivers/net/vmxnet3/vmxnet3_drv.c | 33 +++++++++++++++++++++++----------
>  drivers/net/vmxnet3/vmxnet3_int.h |  5 ++---
>  2 files changed, 25 insertions(+), 13 deletions(-)
> 
> -- 
> 2.7.4
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team