mbox series

[SRU,Bionic,0/4] Fixes for LP:1768431

Message ID cover.1527865668.git.joseph.salisbury@canonical.com
Headers show
Series Fixes for LP:1768431 | expand

Message

Joseph Salisbury June 1, 2018, 3:23 p.m. UTC
BugLink: http://bugs.launchpad.net/bugs/1768431

== SRU Justification ==
This SRU was requested by IBM.  It contains one SAUCE patch and three
commits from linux.next. 

IBM requested that we revert a set of SAUCE patches from 18.04 and
replace them with patches from linux-next.  Based on review comments, 
there has been minor changes from the original SAUCE patches and the 
versions in linux-next.

The first SAUCE patch contains all the changes between the current version 
of SAUCE patches for latest cxlflash patches in bionic and the latest 
version accepted by the community. This only has the needed changes and   
makes it so we don't have to revert and re-apply a high number of patches. 
In addition to the SAUCE patch, IBM requested the 3 additional new patches 
from the linux-next tree.

== Fixes ==
UBUNTU: SAUCE: (no-up) cxlflash: OCXL diff between v2 and v3
a3feb6ef50de ("scsi: cxlflash: Synchronize reset and remove ops")
9a597cd4c0ce ("scsi: cxlflash: Remove commmands from pending list on timeout)"
d2d354a606d5 ("scsi: cxlflash: Handle spurious interrupts")

== Regression Potential ==
Medium.  All the patches are specific to the cxlflash driver, but there
are four of them and one is a SAUCE patch.

== Test Case ==
A test kernel was built with these patches and tested by the original bug reporter.
The bug reporter states the test kernel resolved the bug.

Uma Krishnan (4):
  UBUNTU: SAUCE: (no-up) cxlflash: OCXL diff between v2 and v3
  scsi: cxlflash: Synchronize reset and remove ops
  scsi: cxlflash: Remove commmands from pending list on timeout
  scsi: cxlflash: Handle spurious interrupts

 drivers/scsi/cxlflash/common.h  |  1 +
 drivers/scsi/cxlflash/main.c    | 31 ++++++++++++++++++++++++++++---
 drivers/scsi/cxlflash/ocxl_hw.c | 18 +++++++++++++-----
 drivers/scsi/cxlflash/ocxl_hw.h |  1 +
 4 files changed, 43 insertions(+), 8 deletions(-)

Comments

Kleber Sacilotto de Souza June 5, 2018, 6:22 p.m. UTC | #1
On 06/01/18 08:23, Joseph Salisbury wrote:
> BugLink: http://bugs.launchpad.net/bugs/1768431
> 
> == SRU Justification ==
> This SRU was requested by IBM.  It contains one SAUCE patch and three
> commits from linux.next. 
> 
> IBM requested that we revert a set of SAUCE patches from 18.04 and
> replace them with patches from linux-next.  Based on review comments, 
> there has been minor changes from the original SAUCE patches and the 
> versions in linux-next.
> 
> The first SAUCE patch contains all the changes between the current version 
> of SAUCE patches for latest cxlflash patches in bionic and the latest 
> version accepted by the community. This only has the needed changes and   
> makes it so we don't have to revert and re-apply a high number of patches. 
> In addition to the SAUCE patch, IBM requested the 3 additional new patches 
> from the linux-next tree.
> 
> == Fixes ==
> UBUNTU: SAUCE: (no-up) cxlflash: OCXL diff between v2 and v3
> a3feb6ef50de ("scsi: cxlflash: Synchronize reset and remove ops")
> 9a597cd4c0ce ("scsi: cxlflash: Remove commmands from pending list on timeout)"
> d2d354a606d5 ("scsi: cxlflash: Handle spurious interrupts")
> 
> == Regression Potential ==
> Medium.  All the patches are specific to the cxlflash driver, but there
> are four of them and one is a SAUCE patch.
> 
> == Test Case ==
> A test kernel was built with these patches and tested by the original bug reporter.
> The bug reporter states the test kernel resolved the bug.
> 
> Uma Krishnan (4):
>   UBUNTU: SAUCE: (no-up) cxlflash: OCXL diff between v2 and v3
>   scsi: cxlflash: Synchronize reset and remove ops
>   scsi: cxlflash: Remove commmands from pending list on timeout
>   scsi: cxlflash: Handle spurious interrupts
> 
>  drivers/scsi/cxlflash/common.h  |  1 +
>  drivers/scsi/cxlflash/main.c    | 31 ++++++++++++++++++++++++++++---
>  drivers/scsi/cxlflash/ocxl_hw.c | 18 +++++++++++++-----
>  drivers/scsi/cxlflash/ocxl_hw.h |  1 +
>  4 files changed, 43 insertions(+), 8 deletions(-)
> 

The changes look good, scope limited to the driver and tested by the vendor.

Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
Khalid Elmously June 5, 2018, 6:52 p.m. UTC | #2
On 2018-06-01 11:23:53 , Joseph Salisbury wrote:
> BugLink: http://bugs.launchpad.net/bugs/1768431
> 
> == SRU Justification ==
> This SRU was requested by IBM.  It contains one SAUCE patch and three
> commits from linux.next. 
> 
> IBM requested that we revert a set of SAUCE patches from 18.04 and
> replace them with patches from linux-next.  Based on review comments, 
> there has been minor changes from the original SAUCE patches and the 
> versions in linux-next.
> 
> The first SAUCE patch contains all the changes between the current version 
> of SAUCE patches for latest cxlflash patches in bionic and the latest 
> version accepted by the community. This only has the needed changes and   
> makes it so we don't have to revert and re-apply a high number of patches. 
> In addition to the SAUCE patch, IBM requested the 3 additional new patches 
> from the linux-next tree.
> 
> == Fixes ==
> UBUNTU: SAUCE: (no-up) cxlflash: OCXL diff between v2 and v3
> a3feb6ef50de ("scsi: cxlflash: Synchronize reset and remove ops")
> 9a597cd4c0ce ("scsi: cxlflash: Remove commmands from pending list on timeout)"
> d2d354a606d5 ("scsi: cxlflash: Handle spurious interrupts")
> 
> == Regression Potential ==
> Medium.  All the patches are specific to the cxlflash driver, but there
> are four of them and one is a SAUCE patch.
> 
> == Test Case ==
> A test kernel was built with these patches and tested by the original bug reporter.
> The bug reporter states the test kernel resolved the bug.
> 
> Uma Krishnan (4):
>   UBUNTU: SAUCE: (no-up) cxlflash: OCXL diff between v2 and v3
>   scsi: cxlflash: Synchronize reset and remove ops
>   scsi: cxlflash: Remove commmands from pending list on timeout
>   scsi: cxlflash: Handle spurious interrupts
> 
>  drivers/scsi/cxlflash/common.h  |  1 +
>  drivers/scsi/cxlflash/main.c    | 31 ++++++++++++++++++++++++++++---
>  drivers/scsi/cxlflash/ocxl_hw.c | 18 +++++++++++++-----
>  drivers/scsi/cxlflash/ocxl_hw.h |  1 +
>  4 files changed, 43 insertions(+), 8 deletions(-)
>
Acked-by: Khalid Elmously <khalid.elmously@canonical.com>
Khalid Elmously June 6, 2018, 11:31 p.m. UTC | #3
Applied to Bionic


On 2018-06-01 11:23:53 , Joseph Salisbury wrote:
> BugLink: http://bugs.launchpad.net/bugs/1768431
> 
> == SRU Justification ==
> This SRU was requested by IBM.  It contains one SAUCE patch and three
> commits from linux.next. 
> 
> IBM requested that we revert a set of SAUCE patches from 18.04 and
> replace them with patches from linux-next.  Based on review comments, 
> there has been minor changes from the original SAUCE patches and the 
> versions in linux-next.
> 
> The first SAUCE patch contains all the changes between the current version 
> of SAUCE patches for latest cxlflash patches in bionic and the latest 
> version accepted by the community. This only has the needed changes and   
> makes it so we don't have to revert and re-apply a high number of patches. 
> In addition to the SAUCE patch, IBM requested the 3 additional new patches 
> from the linux-next tree.
> 
> == Fixes ==
> UBUNTU: SAUCE: (no-up) cxlflash: OCXL diff between v2 and v3
> a3feb6ef50de ("scsi: cxlflash: Synchronize reset and remove ops")
> 9a597cd4c0ce ("scsi: cxlflash: Remove commmands from pending list on timeout)"
> d2d354a606d5 ("scsi: cxlflash: Handle spurious interrupts")
> 
> == Regression Potential ==
> Medium.  All the patches are specific to the cxlflash driver, but there
> are four of them and one is a SAUCE patch.
> 
> == Test Case ==
> A test kernel was built with these patches and tested by the original bug reporter.
> The bug reporter states the test kernel resolved the bug.
> 
> Uma Krishnan (4):
>   UBUNTU: SAUCE: (no-up) cxlflash: OCXL diff between v2 and v3
>   scsi: cxlflash: Synchronize reset and remove ops
>   scsi: cxlflash: Remove commmands from pending list on timeout
>   scsi: cxlflash: Handle spurious interrupts
> 
>  drivers/scsi/cxlflash/common.h  |  1 +
>  drivers/scsi/cxlflash/main.c    | 31 ++++++++++++++++++++++++++++---
>  drivers/scsi/cxlflash/ocxl_hw.c | 18 +++++++++++++-----
>  drivers/scsi/cxlflash/ocxl_hw.h |  1 +
>  4 files changed, 43 insertions(+), 8 deletions(-)
> 
> -- 
> 2.17.0
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
Thadeu Lima de Souza Cascardo June 26, 2018, 12:27 p.m. UTC | #4
Applied to unstable master branch.

Applied the SAUCE diff for now. It is likely this will be sorted out when we
rebase to 4.18.

Thanks.
Cascardo.

Applied-to: unstable/master