| Message ID | 20180517055014.6607-1-o.rempel@pengutronix.de |
|---|---|
| Headers | show |
| Series | provide power off support for iMX6 with external PMIC | expand |
Hi Rafael, Last version of this patch was send at 17.05.2018. No other comment was provided and this patch is a blocker for other patches in this serie. Can you please give some feedback on it. On 17.05.2018 07:50, Oleksij Rempel wrote: > Export pm_power_off_prepare. It is needed to implement power off on > Freescale/NXP iMX6 based boards with external power management > integrated circuit (PMIC). > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > --- > kernel/reboot.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/kernel/reboot.c b/kernel/reboot.c > index e4ced883d8de..83810d726f3e 100644 > --- a/kernel/reboot.c > +++ b/kernel/reboot.c > @@ -49,6 +49,7 @@ int reboot_force; > */ > > void (*pm_power_off_prepare)(void); > +EXPORT_SYMBOL_GPL(pm_power_off_prepare); > > /** > * emergency_restart - reboot the system >
On Tuesday, June 12, 2018 2:42:12 PM CEST Oleksij Rempel wrote: > This is an OpenPGP/MIME signed message (RFC 4880 and 3156) > --Sj2PRcQlY7eZybdA0sq9wWzJEO8fKS924 > Content-Type: multipart/mixed; boundary="d6BZYFRi4L3iCmOh3nm6wjii3dWC9QFDg"; > protected-headers="v1" > From: Oleksij Rempel <o.rempel@pengutronix.de> > To: Shawn Guo <shawnguo@kernel.org>, Mark Brown <broonie@kernel.org>, > "Rafael J. Wysocki" <rafael.j.wysocki@intel.com> > Cc: kernel@pengutronix.de, devicetree@vger.kernel.org, > linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, > linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>, > Liam Girdwood <lgirdwood@gmail.com>, > Leonard Crestez <leonard.crestez@nxp.com>, Rob Herring <robh+dt@kernel.org>, > Mark Rutland <mark.rutland@arm.com>, > Michael Turquette <mturquette@baylibre.com>, > Stephen Boyd <sboyd@codeaurora.org>, Fabio Estevam <fabio.estevam@nxp.com>, > Russell King <linux@armlinux.org.uk> > Message-ID: <daba73df-037c-2583-3a08-f3f27c4129d1@pengutronix.de> > Subject: Re: [PATCH v7 3/6] kernel/reboot.c: export pm_power_off_prepare > References: <20180517055014.6607-1-o.rempel@pengutronix.de> > <20180517055014.6607-4-o.rempel@pengutronix.de> > In-Reply-To: <20180517055014.6607-4-o.rempel@pengutronix.de> > > --d6BZYFRi4L3iCmOh3nm6wjii3dWC9QFDg > Content-Type: text/plain; charset=utf-8 > Content-Language: en-US > Content-Transfer-Encoding: quoted-printable > > Hi Rafael, > > Last version of this patch was send at 17.05.2018. No other comment was > provided and this patch is a blocker for other patches in this serie. > Can you please give some feedback on it. I would have done that had I not missed the patch. Which probably wouldn't have happened had you CCed it to linux-pm. Anyway, I have no particular problems with exporting pm_power_off_prepare via EXPORT_SYMBOL_GPL(). > > On 17.05.2018 07:50, Oleksij Rempel wrote: > > Export pm_power_off_prepare. It is needed to implement power off on > > Freescale/NXP iMX6 based boards with external power management > > integrated circuit (PMIC). > >=20 > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > > --- > > kernel/reboot.c | 1 + > > 1 file changed, 1 insertion(+) > >=20 > > diff --git a/kernel/reboot.c b/kernel/reboot.c > > index e4ced883d8de..83810d726f3e 100644 > > --- a/kernel/reboot.c > > +++ b/kernel/reboot.c > > @@ -49,6 +49,7 @@ int reboot_force; > > */ > > =20 > > void (*pm_power_off_prepare)(void); > > +EXPORT_SYMBOL_GPL(pm_power_off_prepare); > > =20 > > /** > > * emergency_restart - reboot the system > >=20 > > > --d6BZYFRi4L3iCmOh3nm6wjii3dWC9QFDg-- > > --Sj2PRcQlY7eZybdA0sq9wWzJEO8fKS924 > Content-Type: application/pgp-signature; name="signature.asc" > Content-Description: OpenPGP digital signature > Content-Disposition: attachment; filename="signature.asc" > > > --Sj2PRcQlY7eZybdA0sq9wWzJEO8fKS924-- >
Hi Mark, Rob ACKed DT bindings, Rafael ACKed export of pm_power_off_prepare. I need your OK for regulator patch. On 17.05.2018 07:50, Oleksij Rempel wrote: > On some boards the SoC can use one pin "PMIC_STBY_REQ" to notify th PMIC > about state changes. In this case internal state of PMIC must be > preconfigured for upcomming state change. > It works fine with the current regulator framework, except with the > power-off case. > > This patch is providing an optional pm_power_off_prepare handler > which will configure standby state of the PMIC to disable all power lines. > > In my power consumption test on RIoTBoard, I got the following results: > power off without this patch: 320 mA > power off with this patch: 2 mA > suspend to ram: 40 mA > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > --- > drivers/regulator/pfuze100-regulator.c | 92 ++++++++++++++++++++++++++ > 1 file changed, 92 insertions(+) > > diff --git a/drivers/regulator/pfuze100-regulator.c b/drivers/regulator/pfuze100-regulator.c > index 63922a2167e5..f6c276ed91d8 100644 > --- a/drivers/regulator/pfuze100-regulator.c > +++ b/drivers/regulator/pfuze100-regulator.c > @@ -28,6 +28,7 @@ > #include <linux/regulator/pfuze100.h> > #include <linux/i2c.h> > #include <linux/slab.h> > +#include <linux/kallsyms.h> > #include <linux/regmap.h> > > #define PFUZE_NUMREGS 128 > @@ -42,11 +43,17 @@ > > #define PFUZE100_COINVOL 0x1a > #define PFUZE100_SW1ABVOL 0x20 > +#define PFUZE100_SW1ABMODE 0x23 > #define PFUZE100_SW1CVOL 0x2e > +#define PFUZE100_SW1CMODE 0x31 > #define PFUZE100_SW2VOL 0x35 > +#define PFUZE100_SW2MODE 0x38 > #define PFUZE100_SW3AVOL 0x3c > +#define PFUZE100_SW3AMODE 0x3f > #define PFUZE100_SW3BVOL 0x43 > +#define PFUZE100_SW3BMODE 0x46 > #define PFUZE100_SW4VOL 0x4a > +#define PFUZE100_SW4MODE 0x4d > #define PFUZE100_SWBSTCON1 0x66 > #define PFUZE100_VREFDDRCON 0x6a > #define PFUZE100_VSNVSVOL 0x6b > @@ -57,6 +64,13 @@ > #define PFUZE100_VGEN5VOL 0x70 > #define PFUZE100_VGEN6VOL 0x71 > > +#define PFUZE100_SWxMODE_MASK 0xf > +#define PFUZE100_SWxMODE_APS_APS 0x8 > +#define PFUZE100_SWxMODE_APS_OFF 0x4 > + > +#define PFUZE100_VGENxLPWR BIT(6) > +#define PFUZE100_VGENxSTBY BIT(5) > + > enum chips { PFUZE100, PFUZE200, PFUZE3000 = 3 }; > > struct pfuze_regulator { > @@ -489,6 +503,69 @@ static inline struct device_node *match_of_node(int index) > } > #endif > > +static struct pfuze_chip *syspm_pfuze_chip; > + > +static void pfuze_power_off_prepare(void) > +{ > + dev_info(syspm_pfuze_chip->dev, "Configure standy mode for power off"); > + > + /* Switch from default mode: APS/APS to APS/Off */ > + regmap_update_bits(syspm_pfuze_chip->regmap, PFUZE100_SW1ABMODE, > + PFUZE100_SWxMODE_MASK, PFUZE100_SWxMODE_APS_OFF); > + regmap_update_bits(syspm_pfuze_chip->regmap, PFUZE100_SW1CMODE, > + PFUZE100_SWxMODE_MASK, PFUZE100_SWxMODE_APS_OFF); > + regmap_update_bits(syspm_pfuze_chip->regmap, PFUZE100_SW2MODE, > + PFUZE100_SWxMODE_MASK, PFUZE100_SWxMODE_APS_OFF); > + regmap_update_bits(syspm_pfuze_chip->regmap, PFUZE100_SW3AMODE, > + PFUZE100_SWxMODE_MASK, PFUZE100_SWxMODE_APS_OFF); > + regmap_update_bits(syspm_pfuze_chip->regmap, PFUZE100_SW3BMODE, > + PFUZE100_SWxMODE_MASK, PFUZE100_SWxMODE_APS_OFF); > + regmap_update_bits(syspm_pfuze_chip->regmap, PFUZE100_SW4MODE, > + PFUZE100_SWxMODE_MASK, PFUZE100_SWxMODE_APS_OFF); > + > + regmap_update_bits(syspm_pfuze_chip->regmap, PFUZE100_VGEN1VOL, > + PFUZE100_VGENxLPWR | PFUZE100_VGENxSTBY, > + PFUZE100_VGENxSTBY); > + regmap_update_bits(syspm_pfuze_chip->regmap, PFUZE100_VGEN2VOL, > + PFUZE100_VGENxLPWR | PFUZE100_VGENxSTBY, > + PFUZE100_VGENxSTBY); > + regmap_update_bits(syspm_pfuze_chip->regmap, PFUZE100_VGEN3VOL, > + PFUZE100_VGENxLPWR | PFUZE100_VGENxSTBY, > + PFUZE100_VGENxSTBY); > + regmap_update_bits(syspm_pfuze_chip->regmap, PFUZE100_VGEN4VOL, > + PFUZE100_VGENxLPWR | PFUZE100_VGENxSTBY, > + PFUZE100_VGENxSTBY); > + regmap_update_bits(syspm_pfuze_chip->regmap, PFUZE100_VGEN5VOL, > + PFUZE100_VGENxLPWR | PFUZE100_VGENxSTBY, > + PFUZE100_VGENxSTBY); > + regmap_update_bits(syspm_pfuze_chip->regmap, PFUZE100_VGEN6VOL, > + PFUZE100_VGENxLPWR | PFUZE100_VGENxSTBY, > + PFUZE100_VGENxSTBY); > +} > + > +static int pfuze_power_off_prepare_init(struct pfuze_chip *pfuze_chip) > +{ > + if (pfuze_chip->chip_id != PFUZE100) { > + dev_warn(pfuze_chip->dev, "Requested pm_power_off_prepare handler for not supported chip\n"); > + return -ENODEV; > + } > + > + if (pm_power_off_prepare) { > + dev_warn(pfuze_chip->dev, "pm_power_off_prepare is already registered.\n"); > + return -EBUSY; > + } > + > + if (syspm_pfuze_chip) { > + dev_warn(pfuze_chip->dev, "syspm_pfuze_chip is already set.\n"); > + return -EBUSY; > + } > + > + syspm_pfuze_chip = pfuze_chip; > + pm_power_off_prepare = pfuze_power_off_prepare; > + > + return 0; > +} > + > static int pfuze_identify(struct pfuze_chip *pfuze_chip) > { > unsigned int value; > @@ -659,6 +736,20 @@ static int pfuze100_regulator_probe(struct i2c_client *client, > } > } > > + if (of_property_read_bool(client->dev.of_node, > + "fsl,pmic-stby-poweroff")) > + return pfuze_power_off_prepare_init(pfuze_chip); > + > + return 0; > +} > + > +static int pfuze100_regulator_remove(struct i2c_client *client) > +{ > + if (syspm_pfuze_chip) { > + syspm_pfuze_chip = NULL; > + pm_power_off_prepare = NULL; > + } > + > return 0; > } > > @@ -669,6 +760,7 @@ static struct i2c_driver pfuze_driver = { > .of_match_table = pfuze_dt_ids, > }, > .probe = pfuze100_regulator_probe, > + .remove = pfuze100_regulator_remove, > }; > module_i2c_driver(pfuze_driver); > >
On Tue, Jun 12, 2018 at 04:33:05PM +0200, Rafael J. Wysocki wrote: > On Tuesday, June 12, 2018 2:42:12 PM CEST Oleksij Rempel wrote: > > This is an OpenPGP/MIME signed message (RFC 4880 and 3156) > > --Sj2PRcQlY7eZybdA0sq9wWzJEO8fKS924 > > Content-Type: multipart/mixed; boundary="d6BZYFRi4L3iCmOh3nm6wjii3dWC9QFDg"; > > protected-headers="v1" > > From: Oleksij Rempel <o.rempel@pengutronix.de> > > To: Shawn Guo <shawnguo@kernel.org>, Mark Brown <broonie@kernel.org>, > > "Rafael J. Wysocki" <rafael.j.wysocki@intel.com> > > Cc: kernel@pengutronix.de, devicetree@vger.kernel.org, > > linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, > > linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>, > > Liam Girdwood <lgirdwood@gmail.com>, > > Leonard Crestez <leonard.crestez@nxp.com>, Rob Herring <robh+dt@kernel.org>, > > Mark Rutland <mark.rutland@arm.com>, > > Michael Turquette <mturquette@baylibre.com>, > > Stephen Boyd <sboyd@codeaurora.org>, Fabio Estevam <fabio.estevam@nxp.com>, > > Russell King <linux@armlinux.org.uk> > > Message-ID: <daba73df-037c-2583-3a08-f3f27c4129d1@pengutronix.de> > > Subject: Re: [PATCH v7 3/6] kernel/reboot.c: export pm_power_off_prepare > > References: <20180517055014.6607-1-o.rempel@pengutronix.de> > > <20180517055014.6607-4-o.rempel@pengutronix.de> > > In-Reply-To: <20180517055014.6607-4-o.rempel@pengutronix.de> > > > > --d6BZYFRi4L3iCmOh3nm6wjii3dWC9QFDg > > Content-Type: text/plain; charset=utf-8 > > Content-Language: en-US > > Content-Transfer-Encoding: quoted-printable > > > > Hi Rafael, > > > > Last version of this patch was send at 17.05.2018. No other comment was > > provided and this patch is a blocker for other patches in this serie. > > Can you please give some feedback on it. > > I would have done that had I not missed the patch. > > Which probably wouldn't have happened had you CCed it to linux-pm. > > Anyway, I have no particular problems with exporting pm_power_off_prepare via > EXPORT_SYMBOL_GPL(). Rafael, Can we have your explicit Acked-by tag on this patch? Thanks. Shawn
Hi Rafael, it is two weeks since this email. Probably it was lost some where in the space time continuum. Can you please respond to it :) On 17.06.2018 09:05, Shawn Guo wrote: > On Tue, Jun 12, 2018 at 04:33:05PM +0200, Rafael J. Wysocki wrote: >> On Tuesday, June 12, 2018 2:42:12 PM CEST Oleksij Rempel wrote: >>> This is an OpenPGP/MIME signed message (RFC 4880 and 3156) >>> --Sj2PRcQlY7eZybdA0sq9wWzJEO8fKS924 >>> Content-Type: multipart/mixed; boundary="d6BZYFRi4L3iCmOh3nm6wjii3dWC9QFDg"; >>> protected-headers="v1" >>> From: Oleksij Rempel <o.rempel@pengutronix.de> >>> To: Shawn Guo <shawnguo@kernel.org>, Mark Brown <broonie@kernel.org>, >>> "Rafael J. Wysocki" <rafael.j.wysocki@intel.com> >>> Cc: kernel@pengutronix.de, devicetree@vger.kernel.org, >>> linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, >>> linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>, >>> Liam Girdwood <lgirdwood@gmail.com>, >>> Leonard Crestez <leonard.crestez@nxp.com>, Rob Herring <robh+dt@kernel.org>, >>> Mark Rutland <mark.rutland@arm.com>, >>> Michael Turquette <mturquette@baylibre.com>, >>> Stephen Boyd <sboyd@codeaurora.org>, Fabio Estevam <fabio.estevam@nxp.com>, >>> Russell King <linux@armlinux.org.uk> >>> Message-ID: <daba73df-037c-2583-3a08-f3f27c4129d1@pengutronix.de> >>> Subject: Re: [PATCH v7 3/6] kernel/reboot.c: export pm_power_off_prepare >>> References: <20180517055014.6607-1-o.rempel@pengutronix.de> >>> <20180517055014.6607-4-o.rempel@pengutronix.de> >>> In-Reply-To: <20180517055014.6607-4-o.rempel@pengutronix.de> >>> >>> --d6BZYFRi4L3iCmOh3nm6wjii3dWC9QFDg >>> Content-Type: text/plain; charset=utf-8 >>> Content-Language: en-US >>> Content-Transfer-Encoding: quoted-printable >>> >>> Hi Rafael, >>> >>> Last version of this patch was send at 17.05.2018. No other comment was >>> provided and this patch is a blocker for other patches in this serie. >>> Can you please give some feedback on it. >> >> I would have done that had I not missed the patch. >> >> Which probably wouldn't have happened had you CCed it to linux-pm. >> >> Anyway, I have no particular problems with exporting pm_power_off_prepare via >> EXPORT_SYMBOL_GPL(). > > Rafael, > > Can we have your explicit Acked-by tag on this patch? Thanks. > > Shawn >
2018.05.17: update patches to version v7 This patch series is providing power off support for Freescale/NXP iMX6 based boards with external power management integrated circuit (PMIC). As a first step the PMIC is configured to turn off the system if the standby pin is asserted. On second step we assert the standby pin. For this reason we need to use pm_power_off_prepare. Usage of stnadby pin for power off is described in official iMX6 documentation. 2018.03.05: As this patch set touches multiple subsystems I think it would make sense for Shawn Guo to take the all patch set. The only part which didn't receive an ACK is regulator stuff. So I would hope that Mark Brown can ACK it. Kind regards, Oleksij Rempel 2017.12.06: Adding Linus. Probably there is no maintainer for this patch set. No changes are made, tested on v4.15-rc1. 2017.10.27: Last version of this patch set was send at 20 Jun 2017, this is a rebase against kernel v4.14-rc6. Probably this set got lost. If I forgot to address some comments, please point me. changes: v7: - use EXPORT_SYMBOL_GPL(pm_power_off_prepare) instead of EXPORT_SYMBOL - call imx6q_suspend_finish() directly without cpu_suspend() v6: - rename imx6_pm_poweroff to imx6_pm_stby_poweroff - fix "MPIC_STBY_REQ" typo in the comment. v5: - remove useless includes from pm-imx6.c patch - add Acked-by to "regulator: pfuze100: add fsl,pmic-stby-poweroff property" patch v4: - update comment in "regulator: pfuze100: add fsl,pmic-stby-poweroff ..." patch - add Acked-by to "ARM: imx6q: provide documentation for new ..." patch v3: - set pm_power_off_prepare = NULL on .remove. - documentation and spelling fixes. - use %pf instead of lookup_symbol_name. Oleksij Rempel (6): ARM: imx6q: provide documentation for new fsl,pmic-stby-poweroff property ARM: imx6: register pm_power_off handler if "fsl,pmic-stby-poweroff" is set kernel/reboot.c: export pm_power_off_prepare regulator: pfuze100: add fsl,pmic-stby-poweroff property regulator: pfuze100-regulator: provide pm_power_off_prepare handler ARM: dts: imx6: RIoTboard provide standby on power off option .../devicetree/bindings/clock/imx6q-clock.txt | 8 ++ .../bindings/regulator/pfuze100.txt | 7 ++ arch/arm/boot/dts/imx6dl-riotboard.dts | 5 + arch/arm/mach-imx/pm-imx6.c | 25 +++++ drivers/regulator/pfuze100-regulator.c | 92 +++++++++++++++++++ kernel/reboot.c | 1 + 6 files changed, 138 insertions(+)