| Message ID | 20180516205543.29305-1-laurent@vivier.eu |
|---|---|
| Headers | show |
| Series | linux-user: move socket.h definitions to CPU directories | expand |
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20180516205543.29305-1-laurent@vivier.eu
Subject: [Qemu-devel] [PATCH v2 0/8] linux-user: move socket.h definitions to CPU directories
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/20180516205543.29305-1-laurent@vivier.eu -> patchew/20180516205543.29305-1-laurent@vivier.eu
Switched to a new branch 'test'
7b092e6078 linux-user: define TARGET_SO_REUSEPORT
86735a30c9 linux-user: copy sparc/sockbits.h definitions from linux
d244fe6268 linux-user: update ARCH_HAS_SOCKET_TYPES use
8ccde8d2cb linux-user: move ppc socket.h definitions to ppc/sockbits.h
15f980ff7b linux-user: move socket.h generic definitions to generic/sockbits.h
ba6b2ad9c6 linux-user: move sparc/sparc64 socket.h definitions to sparc/sockbits.h
af1e7c61b2 linux-user: move alpha socket.h definitions to alpha/sockbits.h
2a8985b9a9 linux-user: move mips socket.h definitions to mips/sockbits.h
=== OUTPUT BEGIN ===
Checking PATCH 1/8: linux-user: move mips socket.h definitions to mips/sockbits.h...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#17:
new file mode 100644
ERROR: if this code is redundant consider removing it
#52: FILE: linux-user/mips/sockbits.h:31:
+#if 0
total: 1 errors, 1 warnings, 227 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 2/8: linux-user: move alpha socket.h definitions to alpha/sockbits.h...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#18:
new file mode 100644
total: 0 errors, 1 warnings, 224 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 3/8: linux-user: move sparc/sparc64 socket.h definitions to sparc/sockbits.h...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#74:
new file mode 100644
total: 0 errors, 1 warnings, 146 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 4/8: linux-user: move socket.h generic definitions to generic/sockbits.h...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#13:
new file mode 100644
total: 0 errors, 1 warnings, 148 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 5/8: linux-user: move ppc socket.h definitions to ppc/sockbits.h...
Checking PATCH 6/8: linux-user: update ARCH_HAS_SOCKET_TYPES use...
Checking PATCH 7/8: linux-user: copy sparc/sockbits.h definitions from linux...
Checking PATCH 8/8: linux-user: define TARGET_SO_REUSEPORT...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Splitting out socket.h definitions helps to read the code and to fix the bugs... No code change, except for the last one that ports definitions from linux for sparc as the values are not the correct ones. v2: - move generic socket.h to generic/sockbits.h and include this file from arch without specific values - for ppc, only define the values that differ and include generic/sockbits.h - update ARCH_HAS_SOCKET_TYPES use to be like in the kernel - define TARGET_SO_REUSEPORT Laurent Vivier (8): linux-user: move mips socket.h definitions to mips/sockbits.h linux-user: move alpha socket.h definitions to alpha/sockbits.h linux-user: move sparc/sparc64 socket.h definitions to sparc/sockbits.h linux-user: move socket.h generic definitions to generic/sockbits.h linux-user: move ppc socket.h definitions to ppc/sockbits.h linux-user: update ARCH_HAS_SOCKET_TYPES use linux-user: copy sparc/sockbits.h definitions from linux linux-user: define TARGET_SO_REUSEPORT linux-user/aarch64/sockbits.h | 1 + linux-user/alpha/sockbits.h | 83 +++++++++ linux-user/arm/sockbits.h | 1 + linux-user/cris/sockbits.h | 1 + linux-user/generic/sockbits.h | 60 +++++++ linux-user/hppa/sockbits.h | 33 +--- linux-user/i386/sockbits.h | 1 + linux-user/m68k/sockbits.h | 1 + linux-user/microblaze/sockbits.h | 1 + linux-user/mips/sockbits.h | 110 ++++++++++++ linux-user/mips64/sockbits.h | 1 + linux-user/nios2/sockbits.h | 1 + linux-user/openrisc/sockbits.h | 1 + linux-user/ppc/sockbits.h | 20 +++ linux-user/riscv/sockbits.h | 1 + linux-user/s390x/sockbits.h | 1 + linux-user/sh4/sockbits.h | 1 + linux-user/socket.h | 377 ++++----------------------------------- linux-user/sparc/sockbits.h | 111 ++++++++++++ linux-user/sparc64/sockbits.h | 1 + linux-user/tilegx/sockbits.h | 1 + linux-user/x86_64/sockbits.h | 1 + linux-user/xtensa/sockbits.h | 1 + 23 files changed, 439 insertions(+), 371 deletions(-) create mode 100644 linux-user/aarch64/sockbits.h create mode 100644 linux-user/alpha/sockbits.h create mode 100644 linux-user/arm/sockbits.h create mode 100644 linux-user/cris/sockbits.h create mode 100644 linux-user/generic/sockbits.h create mode 100644 linux-user/i386/sockbits.h create mode 100644 linux-user/m68k/sockbits.h create mode 100644 linux-user/microblaze/sockbits.h create mode 100644 linux-user/mips/sockbits.h create mode 100644 linux-user/mips64/sockbits.h create mode 100644 linux-user/nios2/sockbits.h create mode 100644 linux-user/openrisc/sockbits.h create mode 100644 linux-user/ppc/sockbits.h create mode 100644 linux-user/riscv/sockbits.h create mode 100644 linux-user/s390x/sockbits.h create mode 100644 linux-user/sh4/sockbits.h create mode 100644 linux-user/sparc/sockbits.h create mode 100644 linux-user/sparc64/sockbits.h create mode 100644 linux-user/tilegx/sockbits.h create mode 100644 linux-user/x86_64/sockbits.h create mode 100644 linux-user/xtensa/sockbits.h