Message ID | 1526478129-16465-1-git-send-email-jacopo+renesas@jmondi.org |
---|---|
Headers | show |
Series | arm64: dts: Draak: Enable video inputs and VIN4 | expand |
Hi Jacopo, Thanks for your patch. On 2018-05-16 15:42:08 +0200, Jacopo Mondi wrote: > Describe CVBS video input through analog video decoder ADV7180 > connected to video input interface VIN4. > > The video input signal path is shared with HDMI video input, and > selected by on-board switches SW-53 and SW-54 with CVBS input selected > by the default switches configuration. You are missing your SoB line :-) Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > --- > arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 36 ++++++++++++++++++++++++++ > 1 file changed, 36 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > index d03f194..9aba28f 100644 > --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > @@ -142,6 +142,11 @@ > groups = "usb0"; > function = "usb0"; > }; > + > + vin4_pins_cvbs: vin4 { > + groups = "vin4_data8", "vin4_sync", "vin4_clk"; > + function = "vin4"; > + }; > }; > > &i2c0 { > @@ -154,6 +159,17 @@ > reg = <0x50>; > pagesize = <8>; > }; > + > + analog-video@20 { > + compatible = "adi,adv7180"; > + reg = <0x20>; > + > + port { > + adv7180_out: endpoint { > + remote-endpoint = <&vin4_in>; > + }; > + }; > + }; > }; > > &i2c1 { > @@ -246,3 +262,23 @@ > timeout-sec = <60>; > status = "okay"; > }; > + > +&vin4 { > + pinctrl-0 = <&vin4_pins_cvbs>; > + pinctrl-names = "default"; > + > + status = "okay"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + > + vin4_in: endpoint { > + remote-endpoint = <&adv7180_out>; > + }; > + }; > + }; > +}; > -- > 2.7.4 >
Hi Jacopo, Thanks for your patch. On 2018-05-16 15:42:09 +0200, Jacopo Mondi wrote: > Describe HDMI input connector and ADV7612 HDMI decoder installed on > R-Car Gen3 Draak board. > > The video signal routing to the HDMI decoder to the video input interface > VIN4 is multiplexed with CVBS input path, and enabled/disabled through > on-board switches SW-49, SW-50, SW-51 and SW-52. > > As the default board switches configuration connects CVBS input to VIN4, > leave the HDMI decoder unconnected in DTS. > > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> I'm not sure we have a policy about describing hardware which can't be used without flipping switches. I have no opinion on if we should do that or not I leave that to others, but for the change itself. Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> I think it's good we describe it as it's part of the Draak board itself and not an expansion board which we have seen a lot of :-) Maybe even add a commented out line in the adv7612 port@2 which hints which VIN this is connected to if the switches are flipped? > --- > arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 38 ++++++++++++++++++++++++++ > 1 file changed, 38 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > index 9aba28f..ea99dc9 100644 > --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > @@ -59,6 +59,17 @@ > }; > }; > > + hdmi-in { > + compatible = "hdmi-connector"; > + type = "a"; > + > + port { > + hdmi_con_in: endpoint { > + remote-endpoint = <&adv7612_in>; > + }; > + }; > + }; > + > memory@48000000 { > device_type = "memory"; > /* first 128MB is reserved for secure area. */ > @@ -170,6 +181,33 @@ > }; > }; > }; > + > + hdmi-decoder@4c { > + compatible = "adi,adv7612"; > + reg = <0x4c>; > + default-input = <0>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + adv7612_in: endpoint { > + remote-endpoint = <&hdmi_con_in>; > + }; > + }; > + > + port@2 { > + reg = <2>; > + adv7612_out: endpoint { > + pclk-sample = <0>; > + hsync-active = <0>; > + vsync-active = <0>; > + }; > + }; > + }; > + }; > }; > > &i2c1 { > -- > 2.7.4 >
Hi Niklas, On Thu, May 17, 2018 at 12:23:18AM +0200, Niklas Söderlund wrote: > Hi Jacopo, > > Thanks for your patch. > > On 2018-05-16 15:42:09 +0200, Jacopo Mondi wrote: > > Describe HDMI input connector and ADV7612 HDMI decoder installed on > > R-Car Gen3 Draak board. > > > > The video signal routing to the HDMI decoder to the video input interface > > VIN4 is multiplexed with CVBS input path, and enabled/disabled through > > on-board switches SW-49, SW-50, SW-51 and SW-52. > > > > As the default board switches configuration connects CVBS input to VIN4, > > leave the HDMI decoder unconnected in DTS. > > > > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > > I'm not sure we have a policy about describing hardware which can't be > used without flipping switches. I have no opinion on if we should do > that or not I leave that to others, but for the change itself. > > Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > Thanks > I think it's good we describe it as it's part of the Draak board itself > and not an expansion board which we have seen a lot of :-) Maybe even > add a commented out line in the adv7612 port@2 which hints which VIN > this is connected to if the switches are flipped? The only VIN instance that's on Draak, VIN4. I can add a comment that describes the switch settings that enables the HDMI video capture path. Thanks j > > > --- > > arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 38 ++++++++++++++++++++++++++ > > 1 file changed, 38 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > > index 9aba28f..ea99dc9 100644 > > --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > > +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > > @@ -59,6 +59,17 @@ > > }; > > }; > > > > + hdmi-in { > > + compatible = "hdmi-connector"; > > + type = "a"; > > + > > + port { > > + hdmi_con_in: endpoint { > > + remote-endpoint = <&adv7612_in>; > > + }; > > + }; > > + }; > > + > > memory@48000000 { > > device_type = "memory"; > > /* first 128MB is reserved for secure area. */ > > @@ -170,6 +181,33 @@ > > }; > > }; > > }; > > + > > + hdmi-decoder@4c { > > + compatible = "adi,adv7612"; > > + reg = <0x4c>; > > + default-input = <0>; > > + > > + ports { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + port@0 { > > + reg = <0>; > > + adv7612_in: endpoint { > > + remote-endpoint = <&hdmi_con_in>; > > + }; > > + }; > > + > > + port@2 { > > + reg = <2>; > > + adv7612_out: endpoint { > > + pclk-sample = <0>; > > + hsync-active = <0>; > > + vsync-active = <0>; > > + }; > > + }; > > + }; > > + }; > > }; > > > > &i2c1 { > > -- > > 2.7.4 > > > > -- > Regards, > Niklas Söderlund
On Thu, May 17, 2018 at 09:14:56AM +0200, jacopo mondi wrote: > Hi Niklas, > > On Thu, May 17, 2018 at 12:23:18AM +0200, Niklas Söderlund wrote: > > Hi Jacopo, > > > > Thanks for your patch. > > > > On 2018-05-16 15:42:09 +0200, Jacopo Mondi wrote: > > > Describe HDMI input connector and ADV7612 HDMI decoder installed on > > > R-Car Gen3 Draak board. > > > > > > The video signal routing to the HDMI decoder to the video input interface > > > VIN4 is multiplexed with CVBS input path, and enabled/disabled through > > > on-board switches SW-49, SW-50, SW-51 and SW-52. > > > > > > As the default board switches configuration connects CVBS input to VIN4, > > > leave the HDMI decoder unconnected in DTS. > > > > > > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > > > > I'm not sure we have a policy about describing hardware which can't be > > used without flipping switches. I have no opinion on if we should do > > that or not I leave that to others, but for the change itself. > > > > Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > > > > Thanks > > > I think it's good we describe it as it's part of the Draak board itself > > and not an expansion board which we have seen a lot of :-) Maybe even > > add a commented out line in the adv7612 port@2 which hints which VIN > > this is connected to if the switches are flipped? > > The only VIN instance that's on Draak, VIN4. > > I can add a comment that describes the switch settings that enables > the HDMI video capture path. That sounds like a good plan to me. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello, the second iteration of this series enables HDMI and CVBS video inputs for the Draak board. >From v1 series the description of VIN4 video interface for R8A77995 SoC has already been collected by Simon, thus I'm not resending it. This new version describes the HDMI input as v1 did, but does not connect it to the VIN4 interface, as the video input path is shared between HDMI and CVBS, and the default switches configuration selects CVBS. I've not been able to test CVBS capture as I don't have any CVBS video source here, but the devices shows up in the media controller graph as expected. ------------------------------------------------------------------------------- [root@alarm ~]# media-ctl -p -d /dev/media1 Media controller API version 4.17.0 Media device information ------------------------ driver rcar_vin model renesas,vin-r8a77995 serial bus info platform:e6ef4000.video hw revision 0x0 driver version 4.17.0 Device topology - entity 1: adv7180 0-0020 (1 pad, 1 link) type V4L2 subdev subtype Unknown flags 20004 device node name /dev/v4l-subdev6 pad0: Source [fmt:UYVY8_2X8/720x480 field:interlaced colorspace:smpte170m] -> "VIN4 output":0 [] - entity 5: VIN4 output (1 pad, 1 link) type Node subtype V4L flags 0 device node name /dev/video3 pad0: Sink <- "adv7180 0-0020":0 [] ------------------------------------------------------------------------------- Compared to Gen2 boards that use adv7180 (Lager, Alt, Koelsch, Porter, Gose and Silk) I have removed the 'bus-width' property as it is not parsed by the driver nor mentioned in the chip device tree binding description. Switching from CVBS to HDMI input requires connecting the HDMI decoder endpoint to VIN4, change the pin muxing to increase the VIN4 input bus width to 24 bits, and add the synchronism signal polarities to the vin endpoint, as the HDMI decoder uses BT.601 while the analog video decoder uses BT.656 unconditionally. The series has been developed on top of media-master tree but applies cleanly on top of latest renesas-driver. Patches for testing are available at: git://jmondi.org/linux d3/media-master/driver-v2 git://jmondi.org/linux d3/media-master/dts-v2 git://jmondi.org/vin-tests d3 Thanks j Jacopo Mondi (3): dt-bindings: media: rcar-vin: Add R8A77995 support arm64: dts: renesas: draak: Describe CVBS input arm64: dts: renesas: draak: Describe HDMI input .../devicetree/bindings/media/rcar_vin.txt | 1 + arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 74 ++++++++++++++++++++++ 2 files changed, 75 insertions(+) -- 2.7.4 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html