From patchwork Mon Mar 26 07:45:07 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hui Wang X-Patchwork-Id: 890793 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) by ozlabs.org (Postfix) with ESMTP id 408mQX3Fhjz9s1q; Mon, 26 Mar 2018 18:45:24 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1f0Moe-0006vR-A5; Mon, 26 Mar 2018 07:45:16 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.86_2) (envelope-from ) id 1f0Moc-0006vA-Tm for kernel-team@lists.ubuntu.com; Mon, 26 Mar 2018 07:45:14 +0000 Received: from [125.35.49.90] (helo=hwang4-Lenovo-V480c.bluefin) by youngberry.canonical.com with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.76) (envelope-from ) id 1f0Moc-0005PG-8K for kernel-team@lists.ubuntu.com; Mon, 26 Mar 2018 07:45:14 +0000 From: Hui Wang To: kernel-team@lists.ubuntu.com Subject: [SRU][Artful][OEM][PATCH 0/2] speaker can't output sound anymore after system resumes from S3 on a lenovo machine with alc257 Date: Mon, 26 Mar 2018 15:45:07 +0800 Message-Id: <1522050309-9046-1-git-send-email-hui.wang@canonical.com> X-Mailer: git-send-email 2.7.4 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" BugLink: https://bugs.launchpad.net/bugs/1758829 The 1st patch is already in the kernel 4.15 and the 2nd patch is already in the 4.15 stable-queue, so will not send them to bionic again here. [Impact] After booting up, the speaker works well. If we suspend the machine then resume it back, the speaker can't output sound, even rebooting can't make the speaker work, we need to power off the machine then power up the machine, the speaker can work again. [Fix] We need to add the basic support for the codec alc257 first (0001-xxx.patch), then add hooking function for this codec and clear the bit of 15 for register 0x57 (0002-xxx.patch). Both of these two patches come from mainline kernel. [Test Case] After booting up the system, suspend the machine, then resume the machine, test the speaker, the speaker can output sound. Repeat the testing steps many times, the speaker still can work. [Regression Potential] Very low, since the 1st patch just add the support for a new codec alc257, it will not affect other codecs. The 2nd patch just apply a fix for alc257, it doesn't affect other codecs too. And both of them come from mainline and realtek. Kailang Yang (2): ALSA: hda/realtek - New codec support for ALC257 ALSA: hda/realtek - Fix speaker no sound after system resume sound/pci/hda/patch_realtek.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) Acked-by: Aaron Ma Acked-by: Stefan Bader