| Message ID | 1520166031-22709-1-git-send-email-roid@mellanox.com |
|---|---|
| Headers | show |
| Series | TC offload dump fix and add frag | expand |
These seem reasonable enough to me. Who is the best person to review them? I guess that Paul Blakey is the largest contributor to this infrastructure. On Sun, Mar 04, 2018 at 02:20:29PM +0200, Roi Dayan wrote: > Hi, > > The first patch fixing error handling when parsing tc rules for dump flows. > The second patch adds support for frag=no when offloading to TC. > This of course also limits that frag first/later is not being > offloaded to TC and fallback to the OVS datapath. this is because TC > supports only yes/no for frag. > > Thanks, > Roi > > > Roi Dayan (2): > lib/tc: Handle error parsing action in nl_parse_single_action > netdev-tc-offloads: Add support for offloading ip frag no > > lib/netdev-tc-offloads.c | 13 ++++++++++++- > lib/tc.c | 45 +++++++++++++++++++++++++++++++++++++++------ > lib/tc.h | 1 + > 3 files changed, 52 insertions(+), 7 deletions(-) > > -- > 2.7.0 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 09/03/2018 21:18, Ben Pfaff wrote: > These seem reasonable enough to me. Who is the best person to review > them? I guess that Paul Blakey is the largest contributor to this > infrastructure. > sure. we also saw the new commit from Simon to TC to support frag-first so we'll update the code to support it. Thanks, Roi > On Sun, Mar 04, 2018 at 02:20:29PM +0200, Roi Dayan wrote: >> Hi, >> >> The first patch fixing error handling when parsing tc rules for dump flows. >> The second patch adds support for frag=no when offloading to TC. >> This of course also limits that frag first/later is not being >> offloaded to TC and fallback to the OVS datapath. this is because TC >> supports only yes/no for frag. >> >> Thanks, >> Roi >> >> >> Roi Dayan (2): >> lib/tc: Handle error parsing action in nl_parse_single_action >> netdev-tc-offloads: Add support for offloading ip frag no >> >> lib/netdev-tc-offloads.c | 13 ++++++++++++- >> lib/tc.c | 45 +++++++++++++++++++++++++++++++++++++++------ >> lib/tc.h | 1 + >> 3 files changed, 52 insertions(+), 7 deletions(-) >> >> -- >> 2.7.0 >> >> _______________________________________________ >> dev mailing list >> dev@openvswitch.org >> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmail.openvswitch.org%2Fmailman%2Flistinfo%2Fovs-dev&data=02%7C01%7Croid%40mellanox.com%7C0605cc2f6f264ab1ae7f08d585f295c3%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C636562199367861922&sdata=hX8h4JsKsjTMzsi6HHYDSLtmST5%2FzHokufpyM9r4MUk%3D&reserved=0