[00/19,Version,4] cifs: remove rfc1002 from smb2 requests
mbox series

Message ID 20171121000442.24888-1-lsahlber@redhat.com
Headers show
Series
  • cifs: remove rfc1002 from smb2 requests
Related show

Message

Ronnie Sahlberg Nov. 21, 2017, 12:04 a.m. UTC
Steve, All,

Please find an updated version of the patch series to get rid of the
rfc1002 header from all request structures in SMB2.

Version 2:
* changed SendReceive3 to smb2_send_recv
* fixed a Buffer[1] error that aaptel@xxxxxxxx reported

Version 3:
* Change SMB2_read() to use smb2_send_recv instead of cifs_send_recv
* Fix smb2_negotiate_req where we didnt update the total length to
accomodate smb2 contexts.
* Fix smb2_lease_ack where I forgot to bump total length by 12.

Version 4:
* Fix incorrect length in smb2_lockv

--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Pavel Shilovsky Nov. 21, 2017, 1:22 a.m. UTC | #1
2017-11-20 16:04 GMT-08:00 Ronnie Sahlberg <lsahlber@redhat.com>:
> Steve, All,
>
> Please find an updated version of the patch series to get rid of the
> rfc1002 header from all request structures in SMB2.
>
> Version 2:
> * changed SendReceive3 to smb2_send_recv
> * fixed a Buffer[1] error that aaptel@xxxxxxxx reported
>
> Version 3:
> * Change SMB2_read() to use smb2_send_recv instead of cifs_send_recv
> * Fix smb2_negotiate_req where we didnt update the total length to
> accomodate smb2 contexts.
> * Fix smb2_lease_ack where I forgot to bump total length by 12.
>
> Version 4:
> * Fix incorrect length in smb2_lockv
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Finished reviewing patches and testing with cthon and xfstests.

Reviewed-by: Pavel Shilovsky <pshilov@microsoft.com>

Aurelien, a lot of error messages like "CIFS VFS: ioctl error in
smb2_get_dfs_refer rc=-2" are being written into syslog. What do you
think about decreasing the log level of this message?

--
Best regards,
Pavel Shilovsky
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Aurelien Aptel Nov. 21, 2017, 11:15 a.m. UTC | #2
Pavel Shilovsky <piastryyy@gmail.com> writes:
> Aurelien, a lot of error messages like "CIFS VFS: ioctl error in
> smb2_get_dfs_refer rc=-2" are being written into syslog. What do you
> think about decreasing the log level of this message?

Sure, I've sent a patch.