mbox series

[SRU,Xenial,Zesty,0/2] Fixes for LP:1729637

Message ID cover.1509730158.git.joseph.salisbury@canonical.com
Headers show
Series Fixes for LP:1729637 | expand

Message

Joseph Salisbury Nov. 8, 2017, 8:44 p.m. UTC
BugLink: http://bugs.launchpad.net/bugs/1729637

== SRU Justification ==
This bug causes Samba mount and umounts in docker container to trigger 
a kernel Oops.  When running 2 docker containers, one as samba server and 
another one as samba client that mounts and umounts a smb share a kernel 
OOps can be triggered.  

This bug happens in Xenial and Zesty, and is fixed by the following two commits:
76da0704507b ("ipv6: only call ip6_route_dev_notify() once for NETDEV_UNREGISTER")
12d94a804946 ("ipv6: fix NULL dereference in ip6_route_dev_notify()")

Both commits are clean cherry picks.  76da0704507b is in mainline as of v4.12.
Commit 12d94a804946 is in mainline as of v4.13-rc6. 
    
== Fixes ==
commit 76da0704507bbc51875013f6557877ab308cfd0a
Author: WANG Cong <xiyou.wangcong@gmail.com>
Date:   Tue Jun 20 11:42:27 2017 -0700

    ipv6: only call ip6_route_dev_notify() once for NETDEV_UNREGISTER

commit 12d94a804946af291e24b80fc53ec86264765781
Author: Eric Dumazet <edumazet@google.com>
Date:   Tue Aug 15 04:09:51 2017 -0700

    ipv6: fix NULL dereference in ip6_route_dev_notify()

== Regression Potential ==
Both commits are specific to ipv6 and fix a regression introduced into Xenial and Zesty.

== Test Case ==
A test kernel was built with these patches and tested by the original bug reporter.
The bug reporter states the test kernel resolved the bug.
 


Eric Dumazet (1):
  ipv6: fix NULL dereference in ip6_route_dev_notify()

WANG Cong (1):
  ipv6: only call ip6_route_dev_notify() once for NETDEV_UNREGISTER

 include/net/addrconf.h | 10 ++++++++++
 net/ipv6/route.c       | 12 ++++++++----
 2 files changed, 18 insertions(+), 4 deletions(-)

Comments

Stefan Bader Nov. 15, 2017, 10:48 a.m. UTC | #1
On 08.11.2017 21:44, Joseph Salisbury wrote:
> BugLink: http://bugs.launchpad.net/bugs/1729637
> 
> == SRU Justification ==
> This bug causes Samba mount and umounts in docker container to trigger 
> a kernel Oops.  When running 2 docker containers, one as samba server and 
> another one as samba client that mounts and umounts a smb share a kernel 
> OOps can be triggered.  
> 
> This bug happens in Xenial and Zesty, and is fixed by the following two commits:
> 76da0704507b ("ipv6: only call ip6_route_dev_notify() once for NETDEV_UNREGISTER")
> 12d94a804946 ("ipv6: fix NULL dereference in ip6_route_dev_notify()")
> 
> Both commits are clean cherry picks.  76da0704507b is in mainline as of v4.12.
> Commit 12d94a804946 is in mainline as of v4.13-rc6. 
>     
> == Fixes ==
> commit 76da0704507bbc51875013f6557877ab308cfd0a
> Author: WANG Cong <xiyou.wangcong@gmail.com>
> Date:   Tue Jun 20 11:42:27 2017 -0700
> 
>     ipv6: only call ip6_route_dev_notify() once for NETDEV_UNREGISTER
> 
> commit 12d94a804946af291e24b80fc53ec86264765781
> Author: Eric Dumazet <edumazet@google.com>
> Date:   Tue Aug 15 04:09:51 2017 -0700
> 
>     ipv6: fix NULL dereference in ip6_route_dev_notify()
> 
> == Regression Potential ==
> Both commits are specific to ipv6 and fix a regression introduced into Xenial and Zesty.
> 
> == Test Case ==
> A test kernel was built with these patches and tested by the original bug reporter.
> The bug reporter states the test kernel resolved the bug.
>  
> 
> 
> Eric Dumazet (1):
>   ipv6: fix NULL dereference in ip6_route_dev_notify()
> 
> WANG Cong (1):
>   ipv6: only call ip6_route_dev_notify() once for NETDEV_UNREGISTER
> 
>  include/net/addrconf.h | 10 ++++++++++
>  net/ipv6/route.c       | 12 ++++++++----
>  2 files changed, 18 insertions(+), 4 deletions(-)
> 
Acked-by: Stefan Bader <stefan.bader@canonical.com>
Kleber Sacilotto de Souza Nov. 15, 2017, 12:59 p.m. UTC | #2
On 11/08/17 21:44, Joseph Salisbury wrote:
> BugLink: http://bugs.launchpad.net/bugs/1729637
> 
> == SRU Justification ==
> This bug causes Samba mount and umounts in docker container to trigger 
> a kernel Oops.  When running 2 docker containers, one as samba server and 
> another one as samba client that mounts and umounts a smb share a kernel 
> OOps can be triggered.  
> 
> This bug happens in Xenial and Zesty, and is fixed by the following two commits:
> 76da0704507b ("ipv6: only call ip6_route_dev_notify() once for NETDEV_UNREGISTER")
> 12d94a804946 ("ipv6: fix NULL dereference in ip6_route_dev_notify()")
> 
> Both commits are clean cherry picks.  76da0704507b is in mainline as of v4.12.
> Commit 12d94a804946 is in mainline as of v4.13-rc6. 
>     
> == Fixes ==
> commit 76da0704507bbc51875013f6557877ab308cfd0a
> Author: WANG Cong <xiyou.wangcong@gmail.com>
> Date:   Tue Jun 20 11:42:27 2017 -0700
> 
>     ipv6: only call ip6_route_dev_notify() once for NETDEV_UNREGISTER
> 
> commit 12d94a804946af291e24b80fc53ec86264765781
> Author: Eric Dumazet <edumazet@google.com>
> Date:   Tue Aug 15 04:09:51 2017 -0700
> 
>     ipv6: fix NULL dereference in ip6_route_dev_notify()
> 
> == Regression Potential ==
> Both commits are specific to ipv6 and fix a regression introduced into Xenial and Zesty.
> 
> == Test Case ==
> A test kernel was built with these patches and tested by the original bug reporter.
> The bug reporter states the test kernel resolved the bug.
>  
> 
> 
> Eric Dumazet (1):
>   ipv6: fix NULL dereference in ip6_route_dev_notify()
> 
> WANG Cong (1):
>   ipv6: only call ip6_route_dev_notify() once for NETDEV_UNREGISTER
> 
>  include/net/addrconf.h | 10 ++++++++++
>  net/ipv6/route.c       | 12 ++++++++----
>  2 files changed, 18 insertions(+), 4 deletions(-)
> 

Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
Stefan Bader Nov. 20, 2017, 10:23 a.m. UTC | #3
On 08.11.2017 21:44, Joseph Salisbury wrote:
> BugLink: http://bugs.launchpad.net/bugs/1729637
> 
> == SRU Justification ==
> This bug causes Samba mount and umounts in docker container to trigger 
> a kernel Oops.  When running 2 docker containers, one as samba server and 
> another one as samba client that mounts and umounts a smb share a kernel 
> OOps can be triggered.  
> 
> This bug happens in Xenial and Zesty, and is fixed by the following two commits:
> 76da0704507b ("ipv6: only call ip6_route_dev_notify() once for NETDEV_UNREGISTER")
> 12d94a804946 ("ipv6: fix NULL dereference in ip6_route_dev_notify()")
> 
> Both commits are clean cherry picks.  76da0704507b is in mainline as of v4.12.
> Commit 12d94a804946 is in mainline as of v4.13-rc6. 
>     
> == Fixes ==
> commit 76da0704507bbc51875013f6557877ab308cfd0a
> Author: WANG Cong <xiyou.wangcong@gmail.com>
> Date:   Tue Jun 20 11:42:27 2017 -0700
> 
>     ipv6: only call ip6_route_dev_notify() once for NETDEV_UNREGISTER
> 
> commit 12d94a804946af291e24b80fc53ec86264765781
> Author: Eric Dumazet <edumazet@google.com>
> Date:   Tue Aug 15 04:09:51 2017 -0700
> 
>     ipv6: fix NULL dereference in ip6_route_dev_notify()
> 
> == Regression Potential ==
> Both commits are specific to ipv6 and fix a regression introduced into Xenial and Zesty.
> 
> == Test Case ==
> A test kernel was built with these patches and tested by the original bug reporter.
> The bug reporter states the test kernel resolved the bug.
>  
> 
> 
> Eric Dumazet (1):
>   ipv6: fix NULL dereference in ip6_route_dev_notify()
> 
> WANG Cong (1):
>   ipv6: only call ip6_route_dev_notify() once for NETDEV_UNREGISTER
> 
>  include/net/addrconf.h | 10 ++++++++++
>  net/ipv6/route.c       | 12 ++++++++----
>  2 files changed, 18 insertions(+), 4 deletions(-)
> 
Applied to Zesty/Xenial master-next. Thanks.