| Message ID | 20171108180119.26721-1-lukeshu@parabola.nu |
|---|---|
| Headers | show |
| Series | Fixup linux ttyname and ttyname_r [BZ #22145] | expand |
Hi Luke, Would you please resend the whole patch series bumping <idx> in [PATCH v<idx> m/n] for all patches? As it is right now it's a little confusing which v<idx> is the latest for each individual patch. Thanks! Christian
On Fri, 10 Nov 2017 11:06:00 -0500, Christian Brauner wrote: > Hi Luke, > > Would you please resend the whole patch series bumping > <idx> in [PATCH v<idx> m/n] for all patches? As it is right now it's a little > confusing which v<idx> is the latest for each individual patch. > > Thanks! > Christian Except for tst-ttyname (which is v5), everything else is v3. But I'll resubmit it all as v6.
The theme of this patchset is to fixup the changes made in 15e9a4f. Fix a bug [BZ #22145] introduced in the commit (and add tests for both the bug it fixed and the bug it introduced!), update documentation to reflect the behavior introduced in the commit. The FSF should have my copyright assignment paperwork on file (though I never received a confirmation from them that everything was in order). v2: - See individual commit messages v3: - Revise commit messages - Revise ChangeLog messages - Split one of the commits in to 2 separate commits - Fix style of comments (no "*" on continued lines, 2 spaces after trailing period) - Fix whitespace style in the definition of is_mytty Luke Shumaker (6): manual: Update to mention ENODEV for ttyname and ttyname_r linux ttyname: Update a reference to kernel docs for kernel 4.10 linux ttyname: Change return type of is_pty from int to bool linux ttyname and ttyname_r: Make the TTY equivalence checks consistent linux ttyname and ttyname_r: Don't bail prematurely [BZ #22145] linux ttyname and ttyname_r: Add tests ChangeLog | 26 ++ manual/terminal.texi | 5 + sysdeps/unix/sysv/linux/Makefile | 3 +- sysdeps/unix/sysv/linux/tst-ttyname.c | 582 ++++++++++++++++++++++++++++++++++ sysdeps/unix/sysv/linux/ttyname.c | 59 ++-- sysdeps/unix/sysv/linux/ttyname.h | 17 +- sysdeps/unix/sysv/linux/ttyname_r.c | 61 ++-- 7 files changed, 671 insertions(+), 82 deletions(-) create mode 100644 sysdeps/unix/sysv/linux/tst-ttyname.c