| Message ID | 1510144108-29563-1-git-send-email-j-keerthy@ti.com |
|---|---|
| Headers | show |
| Series | omap: dmtimer: Move driver out of plat-omap | expand |
On Wed, Nov 08, 2017 at 05:58:21PM +0530, Keerthy wrote: > The series moves dmtimer out of plat-omap to drivers/clocksource. > The series also does a bunch of changes to pwm-omap-dmtimer code > to adapt to the driver migration and clean up plat specific > pdata-quirks and use the dmtimer platform data. > > Boot tested on DRA7-EVM and AM437X-GP-EVM. Boot tested on IGEPv2 with DM3730 and OMAP3530 Tested-by: Ladislav Michl <ladis@linux-mips.org> > More testing would be of great help. > > No code changes in this v2 version. Only enhanced patch > statistics for renames. Btw, what are these pathes against. Here's how it ends against 4.14-rc8: Applying: clocksource: dmtimer: Remove all the exports Applying: arm: omap: Move dmtimer.h out of plat-omap Applying: arm: OMAP: Move dmtimer driver out of plat-omap to drivers under clocksource error: patch failed: drivers/clocksource/Kconfig:46 error: drivers/clocksource/Kconfig: patch does not apply Patch failed at 0003 arm: OMAP: Move dmtimer driver out of plat-omap to drivers under clocksource Test above was using your first serie which I manually fixed to apply. Given the fact there is no code change, I will not do this again :-) (and I'm happy someone is cleaning dm timer code, thank you) ladis > Keerthy (7): > clocksource: dmtimer: Remove all the exports > arm: omap: Move dmtimer.h out of plat-omap > arm: OMAP: Move dmtimer driver out of plat-omap to drivers under > clocksource > dmtimer: Add timer ops to the platform data structure > clocksource: dmtimer: Populate the timer ops to the pdata > pwm: pwm-omap-dmtimer: Adapt driver to utilize dmtimer pdata ops > arm: omap: pdata-quirks: Remove unused timer pdata > > arch/arm/mach-omap1/pm.c | 2 +- > arch/arm/mach-omap1/timer.c | 2 +- > arch/arm/mach-omap2/omap_hwmod_2420_data.c | 2 +- > arch/arm/mach-omap2/omap_hwmod_2430_data.c | 2 +- > arch/arm/mach-omap2/omap_hwmod_2xxx_ipblock_data.c | 2 +- > arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 2 +- > arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 2 +- > arch/arm/mach-omap2/omap_hwmod_54xx_data.c | 2 +- > arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 2 +- > arch/arm/mach-omap2/omap_hwmod_81xx_data.c | 2 +- > arch/arm/mach-omap2/pdata-quirks.c | 32 ------------- > arch/arm/mach-omap2/timer.c | 2 +- > arch/arm/plat-omap/Kconfig | 6 --- > arch/arm/plat-omap/Makefile | 1 - > drivers/clocksource/Kconfig | 6 +++ > drivers/clocksource/Makefile | 1 + > .../plat-omap => drivers/clocksource}/dmtimer.c | 54 +++++++++++----------- > drivers/pwm/pwm-omap-dmtimer.c | 39 +++++++++------- > .../include/plat => include/clocksource}/dmtimer.h | 0 > include/linux/platform_data/dmtimer-omap.h | 38 +++++++++++++++ > 20 files changed, 104 insertions(+), 95 deletions(-) > rename {arch/arm/plat-omap => drivers/clocksource}/dmtimer.c (95%) > rename {arch/arm/plat-omap/include/plat => include/clocksource}/dmtimer.h (100%) > > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-pwm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
* Keerthy <j-keerthy@ti.com> [171108 04:30]: > The series moves dmtimer out of plat-omap to drivers/clocksource. > The series also does a bunch of changes to pwm-omap-dmtimer code > to adapt to the driver migration and clean up plat specific > pdata-quirks and use the dmtimer platform data. > > Boot tested on DRA7-EVM and AM437X-GP-EVM. > > More testing would be of great help. > > No code changes in this v2 version. Only enhanced patch > statistics for renames. OK Cool. Thierry, can you please take a look at the driver code and see if you want other clean-ups done before moving this to drivers? For merging, I can set up an immutable branch for this against v4.15-rc1 when it's out and no more comments. That way we both can then merge it in as needed. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-pwm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wednesday 08 November 2017 06:21 PM, Ladislav Michl wrote: > On Wed, Nov 08, 2017 at 05:58:21PM +0530, Keerthy wrote: >> The series moves dmtimer out of plat-omap to drivers/clocksource. >> The series also does a bunch of changes to pwm-omap-dmtimer code >> to adapt to the driver migration and clean up plat specific >> pdata-quirks and use the dmtimer platform data. >> >> Boot tested on DRA7-EVM and AM437X-GP-EVM. > > Boot tested on IGEPv2 with DM3730 and OMAP3530 > Tested-by: Ladislav Michl <ladis@linux-mips.org> Thanks for Testing :-). > >> More testing would be of great help. >> >> No code changes in this v2 version. Only enhanced patch >> statistics for renames. > > Btw, what are these pathes against. Here's how it ends against 4.14-rc8: > Applying: clocksource: dmtimer: Remove all the exports > Applying: arm: omap: Move dmtimer.h out of plat-omap > Applying: arm: OMAP: Move dmtimer driver out of plat-omap to drivers under clocksource > error: patch failed: drivers/clocksource/Kconfig:46 > error: drivers/clocksource/Kconfig: patch does not apply > Patch failed at 0003 arm: OMAP: Move dmtimer driver out of plat-omap to drivers under clocksource > > Test above was using your first serie which I manually fixed to apply. > Given the fact there is no code change, I will not do this again :-) > (and I'm happy someone is cleaning dm timer code, thank you) I had rebased to latest next branch. Not sure what went wrong there. Let me check myself. I will rebase with all other comments fixed to the next branch and post v3. Thanks Ladis. > > ladis > >> Keerthy (7): >> clocksource: dmtimer: Remove all the exports >> arm: omap: Move dmtimer.h out of plat-omap >> arm: OMAP: Move dmtimer driver out of plat-omap to drivers under >> clocksource >> dmtimer: Add timer ops to the platform data structure >> clocksource: dmtimer: Populate the timer ops to the pdata >> pwm: pwm-omap-dmtimer: Adapt driver to utilize dmtimer pdata ops >> arm: omap: pdata-quirks: Remove unused timer pdata >> >> arch/arm/mach-omap1/pm.c | 2 +- >> arch/arm/mach-omap1/timer.c | 2 +- >> arch/arm/mach-omap2/omap_hwmod_2420_data.c | 2 +- >> arch/arm/mach-omap2/omap_hwmod_2430_data.c | 2 +- >> arch/arm/mach-omap2/omap_hwmod_2xxx_ipblock_data.c | 2 +- >> arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 2 +- >> arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 2 +- >> arch/arm/mach-omap2/omap_hwmod_54xx_data.c | 2 +- >> arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 2 +- >> arch/arm/mach-omap2/omap_hwmod_81xx_data.c | 2 +- >> arch/arm/mach-omap2/pdata-quirks.c | 32 ------------- >> arch/arm/mach-omap2/timer.c | 2 +- >> arch/arm/plat-omap/Kconfig | 6 --- >> arch/arm/plat-omap/Makefile | 1 - >> drivers/clocksource/Kconfig | 6 +++ >> drivers/clocksource/Makefile | 1 + >> .../plat-omap => drivers/clocksource}/dmtimer.c | 54 +++++++++++----------- >> drivers/pwm/pwm-omap-dmtimer.c | 39 +++++++++------- >> .../include/plat => include/clocksource}/dmtimer.h | 0 >> include/linux/platform_data/dmtimer-omap.h | 38 +++++++++++++++ >> 20 files changed, 104 insertions(+), 95 deletions(-) >> rename {arch/arm/plat-omap => drivers/clocksource}/dmtimer.c (95%) >> rename {arch/arm/plat-omap/include/plat => include/clocksource}/dmtimer.h (100%) >> >> -- >> 1.9.1 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-omap" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-pwm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thursday 09 November 2017 10:01 AM, Keerthy wrote: > > > On Wednesday 08 November 2017 06:21 PM, Ladislav Michl wrote: >> On Wed, Nov 08, 2017 at 05:58:21PM +0530, Keerthy wrote: >>> The series moves dmtimer out of plat-omap to drivers/clocksource. >>> The series also does a bunch of changes to pwm-omap-dmtimer code >>> to adapt to the driver migration and clean up plat specific >>> pdata-quirks and use the dmtimer platform data. >>> >>> Boot tested on DRA7-EVM and AM437X-GP-EVM. >> >> Boot tested on IGEPv2 with DM3730 and OMAP3530 >> Tested-by: Ladislav Michl <ladis@linux-mips.org> > > Thanks for Testing :-). > >> >>> More testing would be of great help. >>> >>> No code changes in this v2 version. Only enhanced patch >>> statistics for renames. >> >> Btw, what are these pathes against. Here's how it ends against 4.14-rc8: >> Applying: clocksource: dmtimer: Remove all the exports >> Applying: arm: omap: Move dmtimer.h out of plat-omap >> Applying: arm: OMAP: Move dmtimer driver out of plat-omap to drivers under clocksource >> error: patch failed: drivers/clocksource/Kconfig:46 >> error: drivers/clocksource/Kconfig: patch does not apply >> Patch failed at 0003 arm: OMAP: Move dmtimer driver out of plat-omap to drivers under clocksource >> >> Test above was using your first serie which I manually fixed to apply. >> Given the fact there is no code change, I will not do this again :-) >> (and I'm happy someone is cleaning dm timer code, thank you) > > I had rebased to latest next branch. Not sure what went wrong there. Let > me check myself. Ladis, I got the same error as you have got against 4.14-rc8. I should have mentioned in the series these patches are against the latest next branch. They apply cleanly against Latest next branch. Thanks, Keerthy > > I will rebase with all other comments fixed to the next branch and post v3. > > Thanks Ladis. > >> >> ladis >> >>> Keerthy (7): >>> clocksource: dmtimer: Remove all the exports >>> arm: omap: Move dmtimer.h out of plat-omap >>> arm: OMAP: Move dmtimer driver out of plat-omap to drivers under >>> clocksource >>> dmtimer: Add timer ops to the platform data structure >>> clocksource: dmtimer: Populate the timer ops to the pdata >>> pwm: pwm-omap-dmtimer: Adapt driver to utilize dmtimer pdata ops >>> arm: omap: pdata-quirks: Remove unused timer pdata >>> >>> arch/arm/mach-omap1/pm.c | 2 +- >>> arch/arm/mach-omap1/timer.c | 2 +- >>> arch/arm/mach-omap2/omap_hwmod_2420_data.c | 2 +- >>> arch/arm/mach-omap2/omap_hwmod_2430_data.c | 2 +- >>> arch/arm/mach-omap2/omap_hwmod_2xxx_ipblock_data.c | 2 +- >>> arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 2 +- >>> arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 2 +- >>> arch/arm/mach-omap2/omap_hwmod_54xx_data.c | 2 +- >>> arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 2 +- >>> arch/arm/mach-omap2/omap_hwmod_81xx_data.c | 2 +- >>> arch/arm/mach-omap2/pdata-quirks.c | 32 ------------- >>> arch/arm/mach-omap2/timer.c | 2 +- >>> arch/arm/plat-omap/Kconfig | 6 --- >>> arch/arm/plat-omap/Makefile | 1 - >>> drivers/clocksource/Kconfig | 6 +++ >>> drivers/clocksource/Makefile | 1 + >>> .../plat-omap => drivers/clocksource}/dmtimer.c | 54 +++++++++++----------- >>> drivers/pwm/pwm-omap-dmtimer.c | 39 +++++++++------- >>> .../include/plat => include/clocksource}/dmtimer.h | 0 >>> include/linux/platform_data/dmtimer-omap.h | 38 +++++++++++++++ >>> 20 files changed, 104 insertions(+), 95 deletions(-) >>> rename {arch/arm/plat-omap => drivers/clocksource}/dmtimer.c (95%) >>> rename {arch/arm/plat-omap/include/plat => include/clocksource}/dmtimer.h (100%) >>> >>> -- >>> 1.9.1 >>> >>> -- >>> To unsubscribe from this list: send the line "unsubscribe linux-omap" in >>> the body of a message to majordomo@vger.kernel.org >>> More majordomo info at http://vger.kernel.org/majordomo-info.html > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-pwm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
The series moves dmtimer out of plat-omap to drivers/clocksource. The series also does a bunch of changes to pwm-omap-dmtimer code to adapt to the driver migration and clean up plat specific pdata-quirks and use the dmtimer platform data. Boot tested on DRA7-EVM and AM437X-GP-EVM. More testing would be of great help. No code changes in this v2 version. Only enhanced patch statistics for renames. Keerthy (7): clocksource: dmtimer: Remove all the exports arm: omap: Move dmtimer.h out of plat-omap arm: OMAP: Move dmtimer driver out of plat-omap to drivers under clocksource dmtimer: Add timer ops to the platform data structure clocksource: dmtimer: Populate the timer ops to the pdata pwm: pwm-omap-dmtimer: Adapt driver to utilize dmtimer pdata ops arm: omap: pdata-quirks: Remove unused timer pdata arch/arm/mach-omap1/pm.c | 2 +- arch/arm/mach-omap1/timer.c | 2 +- arch/arm/mach-omap2/omap_hwmod_2420_data.c | 2 +- arch/arm/mach-omap2/omap_hwmod_2430_data.c | 2 +- arch/arm/mach-omap2/omap_hwmod_2xxx_ipblock_data.c | 2 +- arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 2 +- arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 2 +- arch/arm/mach-omap2/omap_hwmod_54xx_data.c | 2 +- arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 2 +- arch/arm/mach-omap2/omap_hwmod_81xx_data.c | 2 +- arch/arm/mach-omap2/pdata-quirks.c | 32 ------------- arch/arm/mach-omap2/timer.c | 2 +- arch/arm/plat-omap/Kconfig | 6 --- arch/arm/plat-omap/Makefile | 1 - drivers/clocksource/Kconfig | 6 +++ drivers/clocksource/Makefile | 1 + .../plat-omap => drivers/clocksource}/dmtimer.c | 54 +++++++++++----------- drivers/pwm/pwm-omap-dmtimer.c | 39 +++++++++------- .../include/plat => include/clocksource}/dmtimer.h | 0 include/linux/platform_data/dmtimer-omap.h | 38 +++++++++++++++ 20 files changed, 104 insertions(+), 95 deletions(-) rename {arch/arm/plat-omap => drivers/clocksource}/dmtimer.c (95%) rename {arch/arm/plat-omap/include/plat => include/clocksource}/dmtimer.h (100%)