mbox series

[v2,0/2] Improve NCSI driver logging

Message ID 20171108003533.13248-1-sam@mendozajonas.com
Headers show
Series Improve NCSI driver logging | expand

Message

Sam Mendoza-Jonas Nov. 8, 2017, 12:35 a.m. UTC 
The NCSI driver has next to no logging at all, with some of the only useful
logs actually coming from the ftgmac100 driver as link up/down messages.

Add a great deal more logging to the NCSI driver, tracking channel state and
selection, link events, and so on. Patch 1 has no functional changes, and
Patch 2 sends a Get-Parameters command during configuration to sanity check the
current channel.

A form of this will go upstream (the log levels probably need some tweaking),
but this iteration is being sent to OpenBMC to assist people currently
debugging a few network issues in the ftgmac100/NCSI/Broadcom area.

v2:
Adjusted log levels (many down to KERN_DEBUG). Patch 2 is the source of most
of the noise, and can probably be skipped - for upstream I'd intend to include
it with a way to manually request that information rather than retrieve it on
every configuration.

Samuel Mendoza-Jonas (2):
  net/ncsi: General state debugging
  net/ncsi: Query channel parameters during configuration

 net/ncsi/internal.h    |  1 +
 net/ncsi/ncsi-aen.c    | 15 +++++++++++++-
 net/ncsi/ncsi-manage.c | 56 +++++++++++++++++++++++++++++++++++++++++++-------
 net/ncsi/ncsi-rsp.c    | 33 ++++++++++++++++++++++++++++-
 4 files changed, 96 insertions(+), 9 deletions(-)