mbox series

[ovs-dev,0/3] Fixes while compiling with 1709 and VS2017

Message ID 20171106155157.12560-1-aserdean@ovn.org
Headers show
Series Fixes while compiling with 1709 and VS2017 | expand

Message

Alin-Gabriel Serdean Nov. 6, 2017, 3:51 p.m. UTC 
This series includes fixes that were found while compiling using
WDK 1709 and Visual Studio 2017.

Alin Gabriel Serdean (3):
  datapath-windows: Add directory to .gitignore
  datapath-windows: Change include type in Iphelper.h
  datapath-windows: Add include directory to ovsext project

 datapath-windows/.gitignore            | 1 +
 datapath-windows/ovsext/IpHelper.h     | 2 +-
 datapath-windows/ovsext/ovsext.vcxproj | 6 +++---
 3 files changed, 5 insertions(+), 4 deletions(-)

Comments

Ben Pfaff Nov. 6, 2017, 10:07 p.m. UTC | #1 
On Mon, Nov 06, 2017 at 05:51:54PM +0200, Alin Gabriel Serdean wrote:
> This series includes fixes that were found while compiling using
> WDK 1709 and Visual Studio 2017.
> 
> Alin Gabriel Serdean (3):
>   datapath-windows: Add directory to .gitignore
>   datapath-windows: Change include type in Iphelper.h
>   datapath-windows: Add include directory to ovsext project

All of these seem reasonable to me.
Ben Pfaff Jan. 4, 2018, 9:37 p.m. UTC | #2 
On Mon, Nov 06, 2017 at 02:07:15PM -0800, Ben Pfaff wrote:
> On Mon, Nov 06, 2017 at 05:51:54PM +0200, Alin Gabriel Serdean wrote:
> > This series includes fixes that were found while compiling using
> > WDK 1709 and Visual Studio 2017.
> > 
> > Alin Gabriel Serdean (3):
> >   datapath-windows: Add directory to .gitignore
> >   datapath-windows: Change include type in Iphelper.h
> >   datapath-windows: Add include directory to ovsext project
> 
> All of these seem reasonable to me.

Do you want to apply these?
Alin-Gabriel Serdean Jan. 5, 2018, 1:59 p.m. UTC | #3 
Sure. Do you mind if I add your acked-by on each one?

Thanks,
Alin.

> -----Original Message-----
> From: Ben Pfaff [mailto:blp@ovn.org]
> Sent: Thursday, January 4, 2018 11:37 PM
> To: Alin Gabriel Serdean <aserdean@ovn.org>
> Cc: dev@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH 0/3] Fixes while compiling with 1709 and
> VS2017
> 
> On Mon, Nov 06, 2017 at 02:07:15PM -0800, Ben Pfaff wrote:
> > On Mon, Nov 06, 2017 at 05:51:54PM +0200, Alin Gabriel Serdean wrote:
> > > This series includes fixes that were found while compiling using WDK
> > > 1709 and Visual Studio 2017.
> > >
> > > Alin Gabriel Serdean (3):
> > >   datapath-windows: Add directory to .gitignore
> > >   datapath-windows: Change include type in Iphelper.h
> > >   datapath-windows: Add include directory to ovsext project
> >
> > All of these seem reasonable to me.
> 
> Do you want to apply these?
Ben Pfaff Jan. 5, 2018, 3:14 p.m. UTC | #4 
OK.

Acked-by: Ben Pfaff <blp@ovn.org>


On Fri, Jan 05, 2018 at 03:59:02PM +0200, aserdean@ovn.org wrote:
> Sure. Do you mind if I add your acked-by on each one?
> 
> Thanks,
> Alin.
> 
> > -----Original Message-----
> > From: Ben Pfaff [mailto:blp@ovn.org]
> > Sent: Thursday, January 4, 2018 11:37 PM
> > To: Alin Gabriel Serdean <aserdean@ovn.org>
> > Cc: dev@openvswitch.org
> > Subject: Re: [ovs-dev] [PATCH 0/3] Fixes while compiling with 1709 and
> > VS2017
> > 
> > On Mon, Nov 06, 2017 at 02:07:15PM -0800, Ben Pfaff wrote:
> > > On Mon, Nov 06, 2017 at 05:51:54PM +0200, Alin Gabriel Serdean wrote:
> > > > This series includes fixes that were found while compiling using WDK
> > > > 1709 and Visual Studio 2017.
> > > >
> > > > Alin Gabriel Serdean (3):
> > > >   datapath-windows: Add directory to .gitignore
> > > >   datapath-windows: Change include type in Iphelper.h
> > > >   datapath-windows: Add include directory to ovsext project
> > >
> > > All of these seem reasonable to me.
> > 
> > Do you want to apply these?
>
Alin-Gabriel Serdean Jan. 8, 2018, 2:55 p.m. UTC | #5 
Thanks Ben! Applied on master.

> -----Original Message-----
> From: Ben Pfaff [mailto:blp@ovn.org]
> Sent: Friday, January 5, 2018 5:14 PM
> To: aserdean@ovn.org
> Cc: dev@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH 0/3] Fixes while compiling with 1709 and
> VS2017
> 
> OK.
> 
> Acked-by: Ben Pfaff <blp@ovn.org>
> 
> 
> On Fri, Jan 05, 2018 at 03:59:02PM +0200, aserdean@ovn.org wrote:
> > Sure. Do you mind if I add your acked-by on each one?
> >
> > Thanks,
> > Alin.
> >
> > > -----Original Message-----
> > > From: Ben Pfaff [mailto:blp@ovn.org]
> > > Sent: Thursday, January 4, 2018 11:37 PM
> > > To: Alin Gabriel Serdean <aserdean@ovn.org>
> > > Cc: dev@openvswitch.org
> > > Subject: Re: [ovs-dev] [PATCH 0/3] Fixes while compiling with 1709 and
> > > VS2017
> > >
> > > On Mon, Nov 06, 2017 at 02:07:15PM -0800, Ben Pfaff wrote:
> > > > On Mon, Nov 06, 2017 at 05:51:54PM +0200, Alin Gabriel Serdean
wrote:
> > > > > This series includes fixes that were found while compiling using
WDK
> > > > > 1709 and Visual Studio 2017.
> > > > >
> > > > > Alin Gabriel Serdean (3):
> > > > >   datapath-windows: Add directory to .gitignore
> > > > >   datapath-windows: Change include type in Iphelper.h
> > > > >   datapath-windows: Add include directory to ovsext project
> > > >
> > > > All of these seem reasonable to me.
> > >
> > > Do you want to apply these?
> >