mbox series

[v3,0/2] Correct Tegra20 FUSE driver DMA usage

Message ID cover.1508450681.git.digetx@gmail.com
Headers show
Series Correct Tegra20 FUSE driver DMA usage | expand

Message

Dmitry Osipenko Oct. 19, 2017, 10:08 p.m. UTC
Change log:

v3:
	- Addressed v2 review comments: added 'config.device_fc = false'
	  and utilize of_device_is_compatible() for dma-filter

v2:
	- Dropped DT patch as turned out it was incorrect and made things
	  work by luck.

	- Now FUSE driver requests DMA channel from the APB DMA driver
	  utilizing DMA channel filter.

	- This patchset now depends on the APB DMA driver patch that allows
	  DMA client to issue a non-flow controlled transfers. I haven't
	  included that patch to this patchset since DMA usage is broken
	  anyway right now. It will work once this patchset and APBDMA
	  patch get applied.

Dmitry Osipenko (2):
  soc/tegra: fuse: Fix reading registers using DMA on Tegra20
  soc/tegra: fuse: Explicitly request DMA channel from APB DMA driver

 drivers/soc/tegra/fuse/fuse-tegra.c   |  1 +
 drivers/soc/tegra/fuse/fuse-tegra20.c | 13 +++++++++++--
 2 files changed, 12 insertions(+), 2 deletions(-)

Comments

Dmitry Osipenko Nov. 14, 2017, 11:25 a.m. UTC | #1
On 20.10.2017 01:08, Dmitry Osipenko wrote:
> Change log:
> 
> v3:
> 	- Addressed v2 review comments: added 'config.device_fc = false'
> 	  and utilize of_device_is_compatible() for dma-filter
> 
> v2:
> 	- Dropped DT patch as turned out it was incorrect and made things
> 	  work by luck.
> 
> 	- Now FUSE driver requests DMA channel from the APB DMA driver
> 	  utilizing DMA channel filter.
> 
> 	- This patchset now depends on the APB DMA driver patch that allows
> 	  DMA client to issue a non-flow controlled transfers. I haven't
> 	  included that patch to this patchset since DMA usage is broken
> 	  anyway right now. It will work once this patchset and APBDMA
> 	  patch get applied.
> 
> Dmitry Osipenko (2):
>   soc/tegra: fuse: Fix reading registers using DMA on Tegra20
>   soc/tegra: fuse: Explicitly request DMA channel from APB DMA driver
> 
>  drivers/soc/tegra/fuse/fuse-tegra.c   |  1 +
>  drivers/soc/tegra/fuse/fuse-tegra20.c | 13 +++++++++++--
>  2 files changed, 12 insertions(+), 2 deletions(-)
> 

Thierry, why this patchset isn't in 'for 4.15' PR?
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Thierry Reding Nov. 14, 2017, 3:01 p.m. UTC | #2
On Tue, Nov 14, 2017 at 02:25:28PM +0300, Dmitry Osipenko wrote:
> On 20.10.2017 01:08, Dmitry Osipenko wrote:
> > Change log:
> > 
> > v3:
> > 	- Addressed v2 review comments: added 'config.device_fc = false'
> > 	  and utilize of_device_is_compatible() for dma-filter
> > 
> > v2:
> > 	- Dropped DT patch as turned out it was incorrect and made things
> > 	  work by luck.
> > 
> > 	- Now FUSE driver requests DMA channel from the APB DMA driver
> > 	  utilizing DMA channel filter.
> > 
> > 	- This patchset now depends on the APB DMA driver patch that allows
> > 	  DMA client to issue a non-flow controlled transfers. I haven't
> > 	  included that patch to this patchset since DMA usage is broken
> > 	  anyway right now. It will work once this patchset and APBDMA
> > 	  patch get applied.
> > 
> > Dmitry Osipenko (2):
> >   soc/tegra: fuse: Fix reading registers using DMA on Tegra20
> >   soc/tegra: fuse: Explicitly request DMA channel from APB DMA driver
> > 
> >  drivers/soc/tegra/fuse/fuse-tegra.c   |  1 +
> >  drivers/soc/tegra/fuse/fuse-tegra20.c | 13 +++++++++++--
> >  2 files changed, 12 insertions(+), 2 deletions(-)
> > 
> 
> Thierry, why this patchset isn't in 'for 4.15' PR?

Looking at the date, this was sent on the same day that I sent out the
pull requests. For ARM-SoC (and many other trees) the cut-off point is
-rc6 of the prior release cycle. This means that any work you'd like
to see go into a release needs to be on the list a couple of days
before that. I usually do pull requests on Thursday or Friday before
an -rc6 release and by that time I want things to have cooked in -next
for a day or two at least.

Thierry