mbox series

[linux,dev-4.13,0/6] SMC driver updates

Message ID 20171009134108.15860-1-clg@kaod.org
Headers show
Series SMC driver updates | expand

Message

Cédric Le Goater Oct. 9, 2017, 1:41 p.m. UTC 
Hello,

Here is a series bringing the Aspeed SMC driver to the level of what
we had in openbmc kernel 4.10. There are a couple of changes :

 - the DMA support is gone. It is not used, it only works for
   kmalloc'ed buffers and UBIFS uses vmalloc'ed buffers for instance.

 - the driver was slightly adapted to take into account the new clk
   driver.

Tested on a palmetto and an ast2500 eval boards.

Thanks,

C.

Cédric Le Goater (6):
  ARM: dts: aspeed: import OpenBMC flash layout
  mtd: spi-nor: aspeed: use command mode for reads
  mtd: spi-nor: aspeed: add support for SPI dual IO read mode
  ARM: dts: aspeed: add a AHB clock to the G4 SMC controllers
  mtd: spi-nor: aspeed: link controller with the ahb clock
  mtd: spi-nor: aspeed: optimize read mode

 arch/arm/boot/dts/aspeed-ast2500-evb.dts           |   1 +
 arch/arm/boot/dts/aspeed-bmc-opp-flash-layout.dtsi |  26 ++
 arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts      |   1 +
 arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts       |   2 +
 arch/arm/boot/dts/aspeed-g4.dtsi                   |   2 +
 drivers/mtd/spi-nor/aspeed-smc.c                   | 283 ++++++++++++++++++++-
 6 files changed, 303 insertions(+), 12 deletions(-)
 create mode 100644 arch/arm/boot/dts/aspeed-bmc-opp-flash-layout.dtsi

Comments

Joel Stanley Oct. 10, 2017, 3:04 a.m. UTC | #1 
Hello Cedric,

On Mon, Oct 9, 2017 at 11:11 PM, Cédric Le Goater <clg@kaod.org> wrote:
> Hello,
>
> Here is a series bringing the Aspeed SMC driver to the level of what
> we had in openbmc kernel 4.10. There are a couple of changes :
>
>  - the DMA support is gone. It is not used, it only works for
>    kmalloc'ed buffers and UBIFS uses vmalloc'ed buffers for instance.
>
>  - the driver was slightly adapted to take into account the new clk
>    driver.
>
> Tested on a palmetto and an ast2500 eval boards.

Thanks! I applied these to dev-4.13. They did not cleanly apply. Can
you double check that head of the remote you're using is
c0df354f409687d3565073e17fab75913755ed07?

I did them applied, but they appear to fail to probe on my evb:

[    1.901227] aspeed-smc 1e620000.flash-controller: mx25l25635e (32768 Kbytes)
[    1.908304] aspeed-smc 1e620000.flash-controller: CE0 window [
0x20000000 - 0x22000000 ] 32MB
[    1.916831] aspeed-smc 1e620000.flash-controller: CE1 window [
0x22000000 - 0x2a000000 ] 128MB
[    1.925540] aspeed-smc 1e620000.flash-controller: unsupported SPI read mode
[    1.932516] aspeed-smc 1e620000.flash-controller: Aspeed SMC probe failed -22
[    1.946376] aspeed-smc: probe of 1e620000.flash-controller failed
with error -22
[    1.955217] aspeed-smc 1e630000.flash-controller: w25q256 (32768 Kbytes)
[    1.961943] aspeed-smc 1e630000.flash-controller: CE0 window [
0x30000000 - 0x32000000 ] 32MB
[    1.970467] aspeed-smc 1e630000.flash-controller: CE1 window [
0x32000000 - 0x38000000 ] 96MB
[    1.978982] aspeed-smc 1e630000.flash-controller: unsupported SPI read mode
[    1.985941] aspeed-smc 1e630000.flash-controller: Aspeed SMC probe failed -22
[    1.995375] aspeed-smc: probe of 1e630000.flash-controller failed
with error -22
[    2.004072] aspeed-smc 1e631000.flash-controller: Aspeed SMC probe failed -19

Cheers,

Joel
Cédric Le Goater Oct. 10, 2017, 6:37 a.m. UTC | #2 
On 10/10/2017 05:04 AM, Joel Stanley wrote:
> Hello Cedric,
> 
> On Mon, Oct 9, 2017 at 11:11 PM, Cédric Le Goater <clg@kaod.org> wrote:
>> Hello,
>>
>> Here is a series bringing the Aspeed SMC driver to the level of what
>> we had in openbmc kernel 4.10. There are a couple of changes :
>>
>>  - the DMA support is gone. It is not used, it only works for
>>    kmalloc'ed buffers and UBIFS uses vmalloc'ed buffers for instance.
>>
>>  - the driver was slightly adapted to take into account the new clk
>>    driver.
>>
>> Tested on a palmetto and an ast2500 eval boards.
> 
> Thanks! I applied these to dev-4.13. They did not cleanly apply. Can
> you double check that head of the remote you're using is
> c0df354f409687d3565073e17fab75913755ed07?

yes it is. See my branch from yesterday :

	https://github.com/legoater/linux/commits/openbmc-4.13

curious.

> I did them applied, but they appear to fail to probe on my evb:
> 
> [    1.901227] aspeed-smc 1e620000.flash-controller: mx25l25635e (32768 Kbytes)
> [    1.908304] aspeed-smc 1e620000.flash-controller: CE0 window [
> 0x20000000 - 0x22000000 ] 32MB
> [    1.916831] aspeed-smc 1e620000.flash-controller: CE1 window [
> 0x22000000 - 0x2a000000 ] 128MB
> [    1.925540] aspeed-smc 1e620000.flash-controller: unsupported SPI read mode
> [    1.932516] aspeed-smc 1e620000.flash-controller: Aspeed SMC probe failed -22
> [    1.946376] aspeed-smc: probe of 1e620000.flash-controller failed
> with error -22
> [    1.955217] aspeed-smc 1e630000.flash-controller: w25q256 (32768 Kbytes)
> [    1.961943] aspeed-smc 1e630000.flash-controller: CE0 window [
> 0x30000000 - 0x32000000 ] 32MB
> [    1.970467] aspeed-smc 1e630000.flash-controller: CE1 window [
> 0x32000000 - 0x38000000 ] 96MB
> [    1.978982] aspeed-smc 1e630000.flash-controller: unsupported SPI read mode
> [    1.985941] aspeed-smc 1e630000.flash-controller: Aspeed SMC probe failed -22
> [    1.995375] aspeed-smc: probe of 1e630000.flash-controller failed
> with error -22
> [    2.004072] aspeed-smc 1e631000.flash-controller: Aspeed SMC probe failed -19

Looks ok on my side :

[    0.000000] Linux version 4.13.5-00039-gc0df354f4096-dirty (legoater@zorba.kaod.org) (gcc version 7.1.0 (Fedora 7.1.0-2.fc26)) #4 Mon Oct 9 12:58:44 CEST 2017
...
[    3.905220] aspeed-smc 1e620000.flash-controller: w25q256 (32768 Kbytes)
[    3.911980] aspeed-smc 1e620000.flash-controller: CE0 window [ 0x20000000 - 0x22000000 ] 32MB
[    3.920656] aspeed-smc 1e620000.flash-controller: CE1 window [ 0x22000000 - 0x2a000000 ] 128MB
[    3.929451] aspeed-smc 1e620000.flash-controller: read control register: 203b0641
[    3.962938] 5 ofpart partitions found on MTD device bmc
[    3.987941] Creating 5 MTD partitions on "bmc":
[    3.992642] 0x000000000000-0x000000060000 : "u-boot"
[    4.018345] 0x000000060000-0x000000080000 : "u-boot-env"
[    4.044080] 0x000000080000-0x0000004c0000 : "kernel"
[    4.069659] 0x0000004c0000-0x000001c00000 : "rofs"
[    4.095786] 0x000001c00000-0x000002000000 : "rwfs"
[    4.123717] aspeed-smc 1e630000.flash-controller: w25q256 (32768 Kbytes)
[    4.130625] aspeed-smc 1e630000.flash-controller: CE0 window [ 0x30000000 - 0x32000000 ] 32MB
[    4.139317] aspeed-smc 1e630000.flash-controller: CE1 window [ 0x32000000 - 0x38000000 ] 96MB
[    4.148031] aspeed-smc 1e630000.flash-controller: read control register: 203b0741
[    4.982664] aspeed-smc 1e631000.flash-controller: Aspeed SMC probe failed -19
[    5.019361] libphy: Fixed MDIO Bus: probed

are you sure we are using the same kernel ? 

Cheers,

C.