mbox series

[ovs-dev,v4,0/2] Add system service to delete transient ports on boot.

Message ID cover.1504871394.git.tredaelli@redhat.com
Headers show
Series Add system service to delete transient ports on boot. | expand

Message

Timothy Redaelli Sept. 13, 2017, 7:35 a.m. UTC
Add a systemd service file that is only executed the first time
ovsdb-server starts after boot and that removes all transient ports
(--delete-transient-ports).

This is important on certain environments where some ports are going to be
recreated after reboot, but other ports need to be persisted in the database.

v4:
    Changed approach to do not use run directory, but to use an
    additional systemd service instead.

v3:
    Added coverletter.
    Rebased and modified due to non-root user patchsets.

v2:
    Added --delete-transient-ports-on-boot flag to manpage.

Timothy Redaelli (2):
  ovs-ctl: Add delete-transient-ports command
  rhel: Add systemd support to delete transient ports only on boot

 rhel/automake.mk                                   |  1 +
 rhel/openvswitch-fedora.spec.in                    |  3 ++-
 ...stemd_system_ovs-delete-transient-ports.service | 10 +++++++++
 rhel/usr_lib_systemd_system_ovsdb-server.service   |  1 +
 utilities/ovs-ctl.8                                |  6 ++++++
 utilities/ovs-ctl.in                               | 24 +++++++++++++---------
 6 files changed, 34 insertions(+), 11 deletions(-)
 create mode 100644 rhel/usr_lib_systemd_system_ovs-delete-transient-ports.service

Comments

Flavio Leitner Sept. 22, 2017, 10:53 p.m. UTC | #1
On Wed, 13 Sep 2017 09:35:32 +0200
Timothy Redaelli <tredaelli@redhat.com> wrote:

> Add a systemd service file that is only executed the first time
> ovsdb-server starts after boot and that removes all transient ports
> (--delete-transient-ports).
> 
> This is important on certain environments where some ports are going to be
> recreated after reboot, but other ports need to be persisted in the database.
> 
> v4:
>     Changed approach to do not use run directory, but to use an
>     additional systemd service instead.
> 
> v3:
>     Added coverletter.
>     Rebased and modified due to non-root user patchsets.
> 
> v2:
>     Added --delete-transient-ports-on-boot flag to manpage.
> 
> Timothy Redaelli (2):
>   ovs-ctl: Add delete-transient-ports command
>   rhel: Add systemd support to delete transient ports only on boot
> 
>  rhel/automake.mk                                   |  1 +
>  rhel/openvswitch-fedora.spec.in                    |  3 ++-
>  ...stemd_system_ovs-delete-transient-ports.service | 10 +++++++++
>  rhel/usr_lib_systemd_system_ovsdb-server.service   |  1 +
>  utilities/ovs-ctl.8                                |  6 ++++++
>  utilities/ovs-ctl.in                               | 24 +++++++++++++---------
>  6 files changed, 34 insertions(+), 11 deletions(-)
>  create mode 100644 rhel/usr_lib_systemd_system_ovs-delete-transient-ports.service
> 

To the set
Acked-by: Flavio Leitner <fbl@sysclose.org>

This will help OVS to start fresh after a system crash or incomplete
shutdown.
Flavio Leitner Oct. 27, 2017, 12:39 p.m. UTC | #2
On Wed, 13 Sep 2017 09:35:32 +0200
Timothy Redaelli <tredaelli@redhat.com> wrote:

> Add a systemd service file that is only executed the first time
> ovsdb-server starts after boot and that removes all transient ports
> (--delete-transient-ports).
> 
> This is important on certain environments where some ports are going to be
> recreated after reboot, but other ports need to be persisted in the database.
> 
> v4:
>     Changed approach to do not use run directory, but to use an
>     additional systemd service instead.
> 
> v3:
>     Added coverletter.
>     Rebased and modified due to non-root user patchsets.
> 
> v2:
>     Added --delete-transient-ports-on-boot flag to manpage.
> 
> Timothy Redaelli (2):
>   ovs-ctl: Add delete-transient-ports command
>   rhel: Add systemd support to delete transient ports only on boot
> 
>  rhel/automake.mk                                   |  1 +
>  rhel/openvswitch-fedora.spec.in                    |  3 ++-
>  ...stemd_system_ovs-delete-transient-ports.service | 10 +++++++++
>  rhel/usr_lib_systemd_system_ovsdb-server.service   |  1 +
>  utilities/ovs-ctl.8                                |  6 ++++++
>  utilities/ovs-ctl.in                               | 24 +++++++++++++---------
>  6 files changed, 34 insertions(+), 11 deletions(-)
>  create mode 100644 rhel/usr_lib_systemd_system_ovs-delete-transient-ports.service

Acked-by: Flavio Leitner <fbl@sysclose.org>
Thanks!
fbl
Ben Pfaff Oct. 27, 2017, 4:07 p.m. UTC | #3
On Wed, Sep 13, 2017 at 09:35:32AM +0200, Timothy Redaelli wrote:
> Add a systemd service file that is only executed the first time
> ovsdb-server starts after boot and that removes all transient ports
> (--delete-transient-ports).
> 
> This is important on certain environments where some ports are going to be
> recreated after reboot, but other ports need to be persisted in the database.
> 
> v4:
>     Changed approach to do not use run directory, but to use an
>     additional systemd service instead.
> 
> v3:
>     Added coverletter.
>     Rebased and modified due to non-root user patchsets.
> 
> v2:
>     Added --delete-transient-ports-on-boot flag to manpage.

These seemed fine to me, so I applied both of them to master.