mbox series

[0/3] hw: More dma_memory_read/write() API cleanup

Message ID 20200221132550.22156-1-philmd@redhat.com
Headers show
Series hw: More dma_memory_read/write() API cleanup | expand

Message

Philippe Mathieu-Daudé Feb. 21, 2020, 1:25 p.m. UTC 
Following up "global exec/memory/dma APIs cleanup"
https://www.mail-archive.com/qemu-devel@nongnu.org/msg681475.html

Few more cleanups in PCNET & SCSI ESP devices.

Philippe Mathieu-Daudé (3):
  hw/dma/sparc32_dma: Make espdma_memory_[read/write] static
  hw/scsi/esp: Let ESPDMAMemoryReadWriteFunc take void pointer and
    size_t
  hw/net/pcnet: Let phys_mem_read/write take void pointer and boolean

 hw/net/pcnet.h                 |  4 ++--
 include/hw/scsi/esp.h          |  2 +-
 include/hw/sparc/sparc32_dma.h |  6 ++----
 hw/dma/sparc32_dma.c           |  8 ++++----
 hw/net/pcnet-pci.c             |  5 +++--
 hw/net/pcnet.c                 | 16 ++++++++--------
 hw/scsi/esp-pci.c              |  6 +++---
 7 files changed, 23 insertions(+), 24 deletions(-)

Comments

Paolo Bonzini Feb. 21, 2020, 4:34 p.m. UTC | #1 
On 21/02/20 14:25, Philippe Mathieu-Daudé wrote:
> Following up "global exec/memory/dma APIs cleanup"
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg681475.html
> 
> Few more cleanups in PCNET & SCSI ESP devices.

Can you send a pull request for everything?

Paolo
Mark Cave-Ayland Feb. 22, 2020, 7:39 p.m. UTC | #2 
On 21/02/2020 13:25, Philippe Mathieu-Daudé wrote:

> Following up "global exec/memory/dma APIs cleanup"
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg681475.html
> 
> Few more cleanups in PCNET & SCSI ESP devices.
> 
> Philippe Mathieu-Daudé (3):
>   hw/dma/sparc32_dma: Make espdma_memory_[read/write] static
>   hw/scsi/esp: Let ESPDMAMemoryReadWriteFunc take void pointer and
>     size_t
>   hw/net/pcnet: Let phys_mem_read/write take void pointer and boolean
> 
>  hw/net/pcnet.h                 |  4 ++--
>  include/hw/scsi/esp.h          |  2 +-
>  include/hw/sparc/sparc32_dma.h |  6 ++----
>  hw/dma/sparc32_dma.c           |  8 ++++----
>  hw/net/pcnet-pci.c             |  5 +++--
>  hw/net/pcnet.c                 | 16 ++++++++--------
>  hw/scsi/esp-pci.c              |  6 +++---
>  7 files changed, 23 insertions(+), 24 deletions(-)

LGTM.

Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>


ATB,

Mark.