| Message ID | 158155489850.3343782.2687127373754434980.stgit@dwillia2-desk3.amr.corp.intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | libnvdimm: Cross-arch compatible namespace alignment | expand |
Dan Williams <dan.j.williams@intel.com> writes: > --- > > Explicit review requests, but any other feedback is of course > appreciated: > > Patch1 needs an ack from ppc arch maintainers, and I'd like a tested-by > from Aneesh that this still works to solve the ppc issue. Jeff, does > this look good to you? OK, I've reviewed everything. Testing looks good with the change I mentioned (memremap_compat_align returning PAGE_SIZE). I made sure a 4k-aligned namespace created under an unpatched kernel would be accessible under a patched kernel. I also made sure that manually setting align would allow for creating of poorly aligned namespaces, and that those namespaces were then accessible on the unpatched kernel. Thanks, Dan! -Jeff
Changes since v1 [1]: - Fix build errors with the PowerPC override for memremap_compat_align() - Move the memremap_compat_align() override definition to arch/powerpc/mm/ioremap.c (Aneesh) [1]: http://lore.kernel.org/r/158041475480.3889308.655103391935006598.stgit@dwillia2-desk3.amr.corp.intel.com --- Explicit review requests, but any other feedback is of course appreciated: Patch1 needs an ack from ppc arch maintainers, and I'd like a tested-by from Aneesh that this still works to solve the ppc issue. Jeff, does this look good to you? --- Aneesh reports that PowerPC requires 16MiB alignment for the address range passed to devm_memremap_pages(), and Jeff reports that it is possible to create a misaligned namespace which blocks future namespace creation in that region. Both of these issues require namespace alignment to be managed at the region level rather than padding at the namespace level which has been a broken approach to date. Introduce memremap_compat_align() to indicate the hard requirements of an arch's memremap_pages() implementation. Use the maximum known memremap_compat_align() to set the default namespace alignment for libnvdimm. Consult that alignment when allocating free space. Finally, allow the default region alignment to be overridden to maintain the same namespace creation capability as previous kernels. The ndctl unit tests, which have some misaligned namespace assumptions, are updated to use the alignment override where necessary. Thanks to Aneesh for early feedback and testing on this improved alignment handling. --- Dan Williams (4): mm/memremap_pages: Introduce memremap_compat_align() libnvdimm/namespace: Enforce memremap_compat_align() libnvdimm/region: Introduce NDD_LABELING libnvdimm/region: Introduce an 'align' attribute arch/powerpc/Kconfig | 1 arch/powerpc/mm/ioremap.c | 12 +++ arch/powerpc/platforms/pseries/papr_scm.c | 2 drivers/acpi/nfit/core.c | 4 + drivers/nvdimm/dimm.c | 2 drivers/nvdimm/dimm_devs.c | 95 +++++++++++++++++---- drivers/nvdimm/namespace_devs.c | 21 ++++- drivers/nvdimm/nd.h | 3 - drivers/nvdimm/pfn_devs.c | 2 drivers/nvdimm/region_devs.c | 132 ++++++++++++++++++++++++++--- include/linux/libnvdimm.h | 2 include/linux/memremap.h | 8 ++ include/linux/mmzone.h | 1 lib/Kconfig | 3 + mm/memremap.c | 13 +++ 15 files changed, 260 insertions(+), 41 deletions(-) -- base-commit: 543506a2936aaced94bcc8731aae5d29d0442e90