[SRU,Focal,0/3] change the ASoC card name and card longname to meet the requirement of alsa-lib-1.2.1 (Focal)
mbox series

Message ID 20200211031252.6620-1-hui.wang@canonical.com
Headers show
Series
  • change the ASoC card name and card longname to meet the requirement of alsa-lib-1.2.1 (Focal)
Related show

Message

Hui Wang Feb. 11, 2020, 3:12 a.m. UTC
BugLink: http://bugs.launchpad.net/bugs/1862712

In the ubuntu-20.04, we integrate the alsa-lib-1.2.1.2, and from the
alsa-lib-1.2.1, the ucm is put into a standalone package alsa-ucm-conf,
and from the 1.2.1, the alsa-lib supports the ucm2.

In the alsa-ucm-conf-1.2.1.2, the ucm2 folders are named by new
card name or longname, kernel-v5.5-rc1 has patches to change those
names to new names. now we backport them to focal kernel.

[Impact]
booting with the focal kernel, the audio driver can't find the ucm2
confs, that is becuase alsa-lib-1.2.1 requires new cardname and long
name, but focal kernel provides the old card names.

[Fix]
backport 3 patches from v5.5-rc1.


[Test Case]
install the 20.04 daily build image, install the linux-firmware and
alsa-ucm-conf, booting with the kernel which have those 3 patches,
the alsa-lib could find the correct ucm2 confs.

[Regression Risk]
It is low risk to focal.
If users install focal kernel to bionic or disco, it will break
the audio since the ucm in the bionic and disco still follow the old
card name and longname, we need to link a new copy ucm named by new
cardname or longname in the bionic and disco.



Jaroslav Kysela (3):
  ASoC: improve the DMI long card code in asoc-core
  ASoC: DMI long name - avoid to add board name if matches with product
    name
  ASoC: intel - fix the card names

 .../intel/boards/kbl_rt5663_rt5514_max98927.c |  2 +-
 sound/soc/intel/boards/skl_hda_dsp_generic.c  |  2 +-
 sound/soc/intel/boards/sof_rt5682.c           |  2 +-
 sound/soc/soc-core.c                          | 67 +++++++------------
 4 files changed, 29 insertions(+), 44 deletions(-)

Comments

Seth Forshee Feb. 19, 2020, 7:28 p.m. UTC | #1
On Tue, Feb 11, 2020 at 11:12:49AM +0800, Hui Wang wrote:
> BugLink: http://bugs.launchpad.net/bugs/1862712
> 
> In the ubuntu-20.04, we integrate the alsa-lib-1.2.1.2, and from the
> alsa-lib-1.2.1, the ucm is put into a standalone package alsa-ucm-conf,
> and from the 1.2.1, the alsa-lib supports the ucm2.
> 
> In the alsa-ucm-conf-1.2.1.2, the ucm2 folders are named by new
> card name or longname, kernel-v5.5-rc1 has patches to change those
> names to new names. now we backport them to focal kernel.
> 
> [Impact]
> booting with the focal kernel, the audio driver can't find the ucm2
> confs, that is becuase alsa-lib-1.2.1 requires new cardname and long
> name, but focal kernel provides the old card names.
> 
> [Fix]
> backport 3 patches from v5.5-rc1.
> 
> 
> [Test Case]
> install the 20.04 daily build image, install the linux-firmware and
> alsa-ucm-conf, booting with the kernel which have those 3 patches,
> the alsa-lib could find the correct ucm2 confs.
> 
> [Regression Risk]
> It is low risk to focal.
> If users install focal kernel to bionic or disco, it will break
> the audio since the ucm in the bionic and disco still follow the old
> card name and longname, we need to link a new copy ucm named by new
> cardname or longname in the bionic and disco.

Applied to focal/master-next, thanks!