| Message ID | 20200203133026.22930-1-brgl@bgdev.pl |
|---|---|
| Headers | show |
| Series | gpiolib: fix a regression introduced by gpio_do_set_config() | expand |
On Mon, Feb 03, 2020 at 02:30:23PM +0100, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > These three patches fix a regression introduced by commit d90f36851d65 > ("gpiolib: have a single place of calling set_config()"). We first need > to revert patches that came on top of it, then apply the actual fix. Thank you for addressing this! It might be good to add Fixes / Depends-on to the first two, but I didn't look if they are in any of v5.5 or older release. > Bartosz Golaszewski (3): > Revert "gpiolib: Remove duplicated function gpio_do_set_config()" > Revert "gpiolib: remove set but not used variable 'config'" > gpiolib: fix gpio_do_set_config() > > drivers/gpio/gpiolib.c | 31 ++++++++++++++++++++++++++----- > 1 file changed, 26 insertions(+), 5 deletions(-) > > -- > 2.23.0 >
pon., 3 lut 2020 o 15:31 Andy Shevchenko <andriy.shevchenko@linux.intel.com> napisał(a): > > On Mon, Feb 03, 2020 at 02:30:23PM +0100, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > > > These three patches fix a regression introduced by commit d90f36851d65 > > ("gpiolib: have a single place of calling set_config()"). We first need > > to revert patches that came on top of it, then apply the actual fix. > > Thank you for addressing this! > > It might be good to add Fixes / Depends-on to the first two, but I didn't look > if they are in any of v5.5 or older release. > They're not - the patch in question was merged for v5.6 and then the "fixes" came on top of it once it got into next. We're fine here IMO. Bart
On Mon, Feb 03, 2020 at 03:35:41PM +0100, Bartosz Golaszewski wrote: > pon., 3 lut 2020 o 15:31 Andy Shevchenko > <andriy.shevchenko@linux.intel.com> napisał(a): > > > > On Mon, Feb 03, 2020 at 02:30:23PM +0100, Bartosz Golaszewski wrote: > > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > > > > > These three patches fix a regression introduced by commit d90f36851d65 > > > ("gpiolib: have a single place of calling set_config()"). We first need > > > to revert patches that came on top of it, then apply the actual fix. > > > > Thank you for addressing this! > > > > It might be good to add Fixes / Depends-on to the first two, but I didn't look > > if they are in any of v5.5 or older release. > > > > They're not - the patch in question was merged for v5.6 and then the > "fixes" came on top of it once it got into next. We're fine here IMO. Good to know. P.S. A bit of offtopic. Since you are going to send a PR for v5.6-rc2, perhaps you can include fixes for MAINTAINERS data base.
On Mon, Feb 03, 2020 at 02:30:23PM +0100, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > These three patches fix a regression introduced by commit d90f36851d65 > ("gpiolib: have a single place of calling set_config()"). We first need > to revert patches that came on top of it, then apply the actual fix. > > Bartosz Golaszewski (3): > Revert "gpiolib: Remove duplicated function gpio_do_set_config()" > Revert "gpiolib: remove set but not used variable 'config'" > gpiolib: fix gpio_do_set_config() > For the series: Tested-by: Guenter Roeck <linux@roeck-us.net> > drivers/gpio/gpiolib.c | 31 ++++++++++++++++++++++++++----- > 1 file changed, 26 insertions(+), 5 deletions(-) > > -- > 2.23.0 >
pon., 3 lut 2020 o 20:14 Guenter Roeck <linux@roeck-us.net> napisał(a): > > On Mon, Feb 03, 2020 at 02:30:23PM +0100, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > > > These three patches fix a regression introduced by commit d90f36851d65 > > ("gpiolib: have a single place of calling set_config()"). We first need > > to revert patches that came on top of it, then apply the actual fix. > > > > Bartosz Golaszewski (3): > > Revert "gpiolib: Remove duplicated function gpio_do_set_config()" > > Revert "gpiolib: remove set but not used variable 'config'" > > gpiolib: fix gpio_do_set_config() > > > > For the series: > > Tested-by: Guenter Roeck <linux@roeck-us.net> > Applied the patches. I'll send them to Linus W shortly. Bartosz
From: Bartosz Golaszewski <bgolaszewski@baylibre.com> These three patches fix a regression introduced by commit d90f36851d65 ("gpiolib: have a single place of calling set_config()"). We first need to revert patches that came on top of it, then apply the actual fix. Bartosz Golaszewski (3): Revert "gpiolib: Remove duplicated function gpio_do_set_config()" Revert "gpiolib: remove set but not used variable 'config'" gpiolib: fix gpio_do_set_config() drivers/gpio/gpiolib.c | 31 ++++++++++++++++++++++++++----- 1 file changed, 26 insertions(+), 5 deletions(-)