mbox series

[v2,net-next,0/3] sfc: refactor mcdi filtering code

Message ID bd446796-af44-148d-5cc2-23b0cd770494@solarflare.com
Headers show
Series sfc: refactor mcdi filtering code | expand

Message

Alex Maftei (amaftei) Jan. 24, 2020, 4:33 p.m. UTC 
Splitting final bits of the driver code into different files, which
will later be used in another driver for a new product.

This is a continuation to my previous patch series. (three of them)
Refactoring will be concluded with this series, for now.

As instructed, split the renaming and moving into different patches.
Minor refactoring was done with the renaming, as explained in the
patch.

Alexandru-Mihai Maftei (3):
  sfc: rename mcdi filtering functions/structs
  sfc: create header for mcdi filtering code
  sfc: move mcdi filtering code

 drivers/net/ethernet/sfc/Makefile       |    2 +-
 drivers/net/ethernet/sfc/ef10.c         | 2476 +----------------------
 drivers/net/ethernet/sfc/mcdi_filters.c | 2270 +++++++++++++++++++++
 drivers/net/ethernet/sfc/mcdi_filters.h |  159 ++
 4 files changed, 2505 insertions(+), 2402 deletions(-)
 create mode 100644 drivers/net/ethernet/sfc/mcdi_filters.c
 create mode 100644 drivers/net/ethernet/sfc/mcdi_filters.h

Comments

Martin Habets Jan. 24, 2020, 4:37 p.m. UTC | #1 
On 24/01/2020 16:33, Alex Maftei (amaftei) wrote:
> Splitting final bits of the driver code into different files, which
> will later be used in another driver for a new product.
> 
> This is a continuation to my previous patch series. (three of them)
> Refactoring will be concluded with this series, for now.
> 
> As instructed, split the renaming and moving into different patches.
> Minor refactoring was done with the renaming, as explained in the
> patch.
> 
> Alexandru-Mihai Maftei (3):
>   sfc: rename mcdi filtering functions/structs
>   sfc: create header for mcdi filtering code
>   sfc: move mcdi filtering code

For the series:
Reviewed-by: Martin Habets <mhabets@solarflare.com>

>  drivers/net/ethernet/sfc/Makefile       |    2 +-
>  drivers/net/ethernet/sfc/ef10.c         | 2476 +----------------------
>  drivers/net/ethernet/sfc/mcdi_filters.c | 2270 +++++++++++++++++++++
>  drivers/net/ethernet/sfc/mcdi_filters.h |  159 ++
>  4 files changed, 2505 insertions(+), 2402 deletions(-)
>  create mode 100644 drivers/net/ethernet/sfc/mcdi_filters.c
>  create mode 100644 drivers/net/ethernet/sfc/mcdi_filters.h
>
David Miller Jan. 25, 2020, 12:18 p.m. UTC | #2 
From: "Alex Maftei (amaftei)" <amaftei@solarflare.com>
Date: Fri, 24 Jan 2020 16:33:21 +0000

> Splitting final bits of the driver code into different files, which
> will later be used in another driver for a new product.
> 
> This is a continuation to my previous patch series. (three of them)
> Refactoring will be concluded with this series, for now.
> 
> As instructed, split the renaming and moving into different patches.
> Minor refactoring was done with the renaming, as explained in the
> patch.

'git' complains when I try to apply this series, please fix and respin.

Applying: sfc: rename mcdi filtering functions/structs
.git/rebase-apply/patch:651: space before tab in indent.
			     	    enum efx_filter_priority priority,
.git/rebase-apply/patch:652: space before tab in indent.
			     	    u32 filter_id, struct efx_filter_spec *spec)
.git/rebase-apply/patch:677: space before tab in indent.
			     	    enum efx_filter_priority priority)
warning: 3 lines add whitespace errors.
Applying: sfc: create header for mcdi filtering code
Applying: sfc: move mcdi filtering code