Message ID | 20200120201823.887937-1-antoine.tenart@bootlin.com |
---|---|
Headers | show |
Series | macsec: add offloading support | expand |
2020-01-20, 21:18:21 +0100, Antoine Tenart wrote: > If a mode isn't supported, `ip macsec offload` will report an issue > (-EOPNOTSUPP). > > One thing not supported in this series would be the ability to list all > supported modes (for now 'off' and 'phy') depending on the h/w interface > capabilities. This can come up in a later patch, as this is not critical > to get the feature used, but I would like this to be compatible with the > current series. I can think of 2 possibilities: either through > `ip macsec show` or through `ip macsec offload` (for example when no > argument is given). What are your thoughts on this? I don't think that's really helpful. The device could change between listing available modes and enabling offloading. The failure of "ip macsec offload blah" (or whatever the command ends up being) will do the same job anyway.