| Message ID | 20191209201025.5757-1-dmurphy@ti.com |
|---|---|
| Headers | show |
| Series | Fix Tx/Rx FIFO depth for DP83867 | expand |
From: Dan Murphy <dmurphy@ti.com> Date: Mon, 9 Dec 2019 14:10:23 -0600 > The DP83867 supports both the RGMII and SGMII modes. The Tx and Rx FIFO depths > are configurable in these modes but may not applicable for both modes. > > When the device is configured for RGMII mode the Tx FIFO depth is applicable > and for SGMII mode both Tx and Rx FIFO depth settings are applicable. When > the driver was originally written only the RGMII device was available and there > were no standard fifo-depth DT properties. > > The patchset converts the special ti,fifo-depth property to the standard > tx-fifo-depth property while still allowing the ti,fifo-depth property to be > set as to maintain backward compatibility. > > In addition to this change the rx-fifo-depth property support was added and only > written when the device is configured for SGMII mode. Series applied, thanks.
Hello The DP83867 supports both the RGMII and SGMII modes. The Tx and Rx FIFO depths are configurable in these modes but may not applicable for both modes. When the device is configured for RGMII mode the Tx FIFO depth is applicable and for SGMII mode both Tx and Rx FIFO depth settings are applicable. When the driver was originally written only the RGMII device was available and there were no standard fifo-depth DT properties. The patchset converts the special ti,fifo-depth property to the standard tx-fifo-depth property while still allowing the ti,fifo-depth property to be set as to maintain backward compatibility. In addition to this change the rx-fifo-depth property support was added and only written when the device is configured for SGMII mode. Dan Dan Murphy (2): dt-bindings: dp83867: Convert fifo-depth to common fifo-depth and make optional net: phy: dp83867: Add rx-fifo-depth and tx-fifo-depth .../devicetree/bindings/net/ti,dp83867.txt | 12 +++- drivers/net/phy/dp83867.c | 62 +++++++++++++++---- 2 files changed, 58 insertions(+), 16 deletions(-)