[v2,0/3] drm/tilcdc: Remove "ti,tilcdc,tfp410" and mark "ti,tilcdc,panel" obsolete
mbox series

Message ID cover.1575901747.git.jsarha@ti.com
Headers show
Series
  • drm/tilcdc: Remove "ti,tilcdc,tfp410" and mark "ti,tilcdc,panel" obsolete
Related show

Message

Jyri Sarha Dec. 9, 2019, 2:42 p.m. UTC
Since v1:
- Add Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
  to "drm/tilcdc: Remove obsolete bundled tilcdc tfp410 driver"
- Add "drm/tilcdc: panel: Add WARN() with a comment to tilcdc-panel probe"

Nobody should any more use the old tilcdc bundled drivers anymore. The
driver is fully capable of using the generic drm bridge and panel
drivers.  However, the obsolete "ti,tilcdc,panel" binding is still
widely used in many mainline supported platforms that I do not have
access to and who knows how many custom platforms. So I am afraid we
have to keep the old bundled tilcdc panel driver around.

I'll wait with merging the "ti,tilcdc,panel" patches until these
patches have been merged:
https://lists.freedesktop.org/archives/dri-devel/2019-December/247301.html
https://lists.freedesktop.org/archives/dri-devel/2019-December/247594.html
So I can refer to them as an example in the comments. 

But I'll merge "drm/tilcdc: Remove obsolete bundled tilcdc tfp410
driver" trough drm-misc in couple days if I do not hear any
objections.

Jyri Sarha (3):
  drm/tilcdc: Remove obsolete bundled tilcdc tfp410 driver
  dt-bindings: display: Add obsolete note to "ti,tilcdc,panel" binding
  drm/tilcdc: panel: Add WARN() with a comment to tilcdc-panel probe

 .../bindings/display/tilcdc/panel.txt         |   6 +
 .../bindings/display/tilcdc/tfp410.txt        |  21 -
 drivers/gpu/drm/tilcdc/Makefile               |   1 -
 drivers/gpu/drm/tilcdc/tilcdc_drv.c           |   3 -
 drivers/gpu/drm/tilcdc/tilcdc_panel.c         |  10 +
 drivers/gpu/drm/tilcdc/tilcdc_tfp410.c        | 379 ------------------
 drivers/gpu/drm/tilcdc/tilcdc_tfp410.h        |  15 -
 7 files changed, 16 insertions(+), 419 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/display/tilcdc/tfp410.txt
 delete mode 100644 drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
 delete mode 100644 drivers/gpu/drm/tilcdc/tilcdc_tfp410.h

Comments

Laurent Pinchart Dec. 9, 2019, 2:48 p.m. UTC | #1
Hi Jyri,

Thank you for the patch.

On Mon, Dec 09, 2019 at 04:42:16PM +0200, Jyri Sarha wrote:
> Add WARN() to the beginnig of tilcdc-panel probe. The obsolete

s/beginnig/beginning/

> tilcdc-panel driver should not be used anymore, since tilcdc is fully
> capable of using generic drm panels like panel-simple and panel-common
> binding.
> 
> Signed-off-by: Jyri Sarha <jsarha@ti.com>
> ---
>  drivers/gpu/drm/tilcdc/tilcdc_panel.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_panel.c b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> index 5584e656b857..cf8e2462a524 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> @@ -309,6 +309,16 @@ static int panel_probe(struct platform_device *pdev)
>  	struct pinctrl *pinctrl;
>  	int ret;
>  
> +	/*
> +	 * The obsolete tilcdc-panel driver should not be used
> +         * anymore, since tilcdc is fully capable of using generic drm
> +         * panels like panel-simple and panel-common binding.

Indentation should use tabs.

> +	 */
> +
> +	WARN(true,
> +	     "tilcdc-panel is obsolte and should not be used. Please update your configuration!\n",

s/obsolte/obsolete/ or deprecated ?

You may want to explicitly state what it should be updated to :-)

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> +	     dev_name(&pdev->dev));
> +
>  	/* bail out early if no DT data: */
>  	if (!node) {
>  		dev_err(&pdev->dev, "device-tree data is missing\n");