| Message ID | 20191129172537.31410-1-m.felsch@pengutronix.de |
|---|---|
| Headers | show |
| Series | DA9062 PMIC features | expand |
On Sat, 30 Nov 2019, at 03:55, Marco Felsch wrote: > During discussion [1] we decided to rename the gpio subsystem local > helper so the name is more meaningful for users outside the gpio > subsystem. Making the helper public is done by a 2nd patch. The > current users are the gpiolib itself and the aspeed gpio driver. > The renaming is done by the following command: > > find ./drivers/gpio -type f -exec sed -i > 's/gpio_chip_hwgpio/gpiod_to_offset/g' {} \; > > [1] https://lkml.org/lkml/2019/11/27/357 > > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> > --- > Changelog: > v3: > - new patch > > drivers/gpio/gpio-aspeed.c | 6 ++--- For the aspeed portion: Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
On Sat, 30 Nov 2019, at 03:55, Marco Felsch wrote: > Currently gpiod_to_offset() is a gpio-subsystem private function which > is used by the gpiolib itself and by the aspeed gpio driver. The time > has shown that there are other drivers as well which need this > information in some special cases e.g. MFD drivers. The patch makes the > function public but you need to explicit add the <linux/gpio/private.h> > include. See discussion [1] for more information. > > [1] https://lkml.org/lkml/2019/11/27/357 > > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> > --- > v3: > - former patch description was "gpio: add support to get local gpio number" > - adapt commit message and description to reflect new state > - don't add wrapper instead use the already existing gpiod_to_offset > - move gpiod_to_offset from gpiolib.h into gpiolib.c > - move declaration into linux/gpio/private.h > --- > drivers/gpio/gpio-aspeed.c | 11 +++++------ Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
On Fri, Nov 29, 2019 at 6:25 PM Marco Felsch <m.felsch@pengutronix.de> wrote: > this series address all comments made on [1]. Patch "gpio: add support > to get local gpio number" is splitted into: > - "gpio: treewide rename gpio_chip_hwgpio to gpiod_to_offset" > - "gpio: make gpiod_to_offset() available for other users" > Please check the discussion [1] for more information. You need to apply > [2] to test the new features. I am very happy with the shape of patches (1) and (2). I can apply these on an immutable branch and merge into the GPIO tree at v5.5-rc1 and offer to other subsystem maintainers to pull in so they can merge the rest of the patch series on top. Alternatively I can merge all the patches into the GPIO tree. I suppose this is not so much of a MFD business at this point so whatever the regulator maintainer prefers I suppose? Yours, Linus Walleij
On Mon, 02 Dec 2019, Linus Walleij wrote: > On Fri, Nov 29, 2019 at 6:25 PM Marco Felsch <m.felsch@pengutronix.de> wrote: > > > this series address all comments made on [1]. Patch "gpio: add support > > to get local gpio number" is splitted into: > > - "gpio: treewide rename gpio_chip_hwgpio to gpiod_to_offset" > > - "gpio: make gpiod_to_offset() available for other users" > > Please check the discussion [1] for more information. You need to apply > > [2] to test the new features. > > I am very happy with the shape of patches (1) and (2). > > I can apply these on an immutable branch and merge into the > GPIO tree at v5.5-rc1 and offer to other subsystem maintainers > to pull in so they can merge the rest of the patch series on > top. > > Alternatively I can merge all the patches into the GPIO tree. > > I suppose this is not so much of a MFD business at this > point so whatever the regulator maintainer prefers I suppose? Acked-by: Lee Jones <lee.jones@linaro.org>
Hi, this series address all comments made on [1]. Patch "gpio: add support to get local gpio number" is splitted into: - "gpio: treewide rename gpio_chip_hwgpio to gpiod_to_offset" - "gpio: make gpiod_to_offset() available for other users" Please check the discussion [1] for more information. You need to apply [2] to test the new features. [1] https://lore.kernel.org/lkml/20191127135932.7223-1-m.felsch@pengutronix.de/ [2] https://lore.kernel.org/linux-gpio/20191129165817.20426-1-m.felsch@pengutronix.de/T/#m3da1fb0d16a37979c74bbcebdb29f3da9e89a9ac Marco Felsch (6): gpio: treewide rename gpio_chip_hwgpio to gpiod_to_offset gpio: make gpiod_to_offset() available for other users dt-bindings: mfd: da9062: add regulator voltage selection documentation regulator: da9062: add voltage selection gpio support dt-bindings: mfd: da9062: add regulator gpio enable/disable documentation regulator: da9062: add gpio based regulator dis-/enable support .../devicetree/bindings/mfd/da9062.txt | 16 ++ drivers/gpio/gpio-aspeed.c | 15 +- drivers/gpio/gpiolib-sysfs.c | 9 +- drivers/gpio/gpiolib.c | 74 +++-- drivers/gpio/gpiolib.h | 8 - drivers/regulator/da9062-regulator.c | 258 ++++++++++++++++++ include/linux/gpio/private.h | 27 ++ 7 files changed, 361 insertions(+), 46 deletions(-) create mode 100644 include/linux/gpio/private.h