Message ID | 20191127063217.50105-1-vicamo.yang@canonical.com |
---|---|
Headers | show |
Series | intel_pmc_core: Add Comet Lake (CML) platform support | expand |
On Wed, Nov 27, 2019 at 02:32:13PM +0800, You-Sheng Yang wrote: > BugLink: https://bugs.launchpad.net/bugs/1847450 > > [Impact] > There is no way to access information under /sys/kernel/debug/pmc_core > on Comet Lake platforms. > > [Fix] > * https://lkml.org/lkml/2019/11/18/713 ("platform/x86: intel_pmc_core: Add Comet > Lake (CML) platform support to intel_pmc_core driver") > > [Test Case] > 1. install prebuilt kernels from ppa:vicamo/ppa-1847450 > 2. boot with installed kernel and check if /sys/kernel/debug/pmc_core is > then available. > > [Regression Potential] > Low. This only adds two new IDs to a model white list and doesn't change > behavior of existing systems. > > V2: add missed Signed-off signature > > Gayatri Kammela (1): > UBUNTU: SAUCE: platform/x86: intel_pmc_core: Add Comet Lake (CML) > platform support to intel_pmc_core driver > > drivers/platform/x86/intel_pmc_core.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) Acked-by: Anthony Wong <anthony.wong@canonical.com>
On 27.11.19 07:32, You-Sheng Yang wrote: > BugLink: https://bugs.launchpad.net/bugs/1847450 > > [Impact] > There is no way to access information under /sys/kernel/debug/pmc_core > on Comet Lake platforms. > > [Fix] > * https://lkml.org/lkml/2019/11/18/713 ("platform/x86: intel_pmc_core: Add Comet > Lake (CML) platform support to intel_pmc_core driver") > > [Test Case] > 1. install prebuilt kernels from ppa:vicamo/ppa-1847450 > 2. boot with installed kernel and check if /sys/kernel/debug/pmc_core is > then available. > > [Regression Potential] > Low. This only adds two new IDs to a model white list and doesn't change > behavior of existing systems. > > V2: add missed Signed-off signature > > Gayatri Kammela (1): > UBUNTU: SAUCE: platform/x86: intel_pmc_core: Add Comet Lake (CML) > platform support to intel_pmc_core driver > > drivers/platform/x86/intel_pmc_core.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > For Disco, note that it goes EOL in January. The change is simple enough but it will not last long. Acked-by: Stefan Bader <stefan.bader@canonical.com>
On 27.11.19 07:32, You-Sheng Yang wrote: > BugLink: https://bugs.launchpad.net/bugs/1847450 > > [Impact] > There is no way to access information under /sys/kernel/debug/pmc_core > on Comet Lake platforms. > > [Fix] > * https://lkml.org/lkml/2019/11/18/713 ("platform/x86: intel_pmc_core: Add Comet > Lake (CML) platform support to intel_pmc_core driver") > > [Test Case] > 1. install prebuilt kernels from ppa:vicamo/ppa-1847450 > 2. boot with installed kernel and check if /sys/kernel/debug/pmc_core is > then available. > > [Regression Potential] > Low. This only adds two new IDs to a model white list and doesn't change > behavior of existing systems. > > V2: add missed Signed-off signature > > Gayatri Kammela (1): > UBUNTU: SAUCE: platform/x86: intel_pmc_core: Add Comet Lake (CML) > platform support to intel_pmc_core driver > > drivers/platform/x86/intel_pmc_core.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > Hi Vicamo, I have applied this patch to Disco and Eoan. However, the BugLink needs to contain a link to a public bug report and #1847450 is still marked as private. Please either make this report public or point us to another public bug to replace this BigLink as soon as possible, otherwise this patch will need to be removed. Thanks, Kleber
On Wed, Nov 27, 2019 at 02:32:13PM +0800, You-Sheng Yang wrote: > BugLink: https://bugs.launchpad.net/bugs/1847450 > > [Impact] > There is no way to access information under /sys/kernel/debug/pmc_core > on Comet Lake platforms. > > [Fix] > * https://lkml.org/lkml/2019/11/18/713 ("platform/x86: intel_pmc_core: Add Comet > Lake (CML) platform support to intel_pmc_core driver") > > [Test Case] > 1. install prebuilt kernels from ppa:vicamo/ppa-1847450 > 2. boot with installed kernel and check if /sys/kernel/debug/pmc_core is > then available. > > [Regression Potential] > Low. This only adds two new IDs to a model white list and doesn't change > behavior of existing systems. Applied to unstable/master, thanks!