mbox series

[SRU,D/E/Unstable,0/3] Sync intel-lpss workaround with upstream version

Message ID 20191126050308.7225-1-kai.heng.feng@canonical.com
Headers show
Series Sync intel-lpss workaround with upstream version | expand

Message

Kai-Heng Feng Nov. 26, 2019, 5:03 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1851901

[Impact]
On new Intel SoC, blacklisting intel-lpss or noapic is needed to make
system boot. Touchpad doesn't work as a side effect.

[Fix]
Write-comining doesn't work for intel-lpss, force it to use uncachable
memory region.

[Test]
User confirmed with the patch series the noapic or blacklisting
intel-lpss can be removed. System boot with a working touchpad.

[Regression Potenial]
Low. Tested on several older Intel laptops, still work without any
issue.


Kai-Heng Feng (1):
  Revert "UBUNTU: SAUCE: mfd: intel-lpss: add quirk for Dell XPS 13 7390
    2-in-1"

Tuowen Zhao (2):
  lib: devres: add a helper function for ioremap_uc
  mfd: intel-lpss: Use devm_ioremap_uc for MMIO

 drivers/mfd/intel-lpss.c | 20 ++------------------
 lib/devres.c             |  3 +--
 2 files changed, 3 insertions(+), 20 deletions(-)

Comments

Anthony Wong Nov. 28, 2019, 12:26 p.m. UTC | #1
On Tue, Nov 26, 2019 at 01:03:03PM +0800, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1851901
> 
> [Impact]
> On new Intel SoC, blacklisting intel-lpss or noapic is needed to make
> system boot. Touchpad doesn't work as a side effect.
> 
> [Fix]
> Write-comining doesn't work for intel-lpss, force it to use uncachable
> memory region.
> 
> [Test]
> User confirmed with the patch series the noapic or blacklisting
> intel-lpss can be removed. System boot with a working touchpad.
> 
> [Regression Potenial]
> Low. Tested on several older Intel laptops, still work without any
> issue.
> 
> 
> Kai-Heng Feng (1):
>   Revert "UBUNTU: SAUCE: mfd: intel-lpss: add quirk for Dell XPS 13 7390
>     2-in-1"
> 
> Tuowen Zhao (2):
>   lib: devres: add a helper function for ioremap_uc
>   mfd: intel-lpss: Use devm_ioremap_uc for MMIO
> 
>  drivers/mfd/intel-lpss.c | 20 ++------------------
>  lib/devres.c             |  3 +--
>  2 files changed, 3 insertions(+), 20 deletions(-)

Essentially replacing a previous SAUCE patch with the same thing from upstream:

Acked-by: Anthony Wong <anthony.wong@canonical.com>
Andrea Righi Nov. 28, 2019, 1:54 p.m. UTC | #2
On Tue, Nov 26, 2019 at 01:03:03PM +0800, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1851901
> 
> [Impact]
> On new Intel SoC, blacklisting intel-lpss or noapic is needed to make
> system boot. Touchpad doesn't work as a side effect.
> 
> [Fix]
> Write-comining doesn't work for intel-lpss, force it to use uncachable
> memory region.
> 
> [Test]
> User confirmed with the patch series the noapic or blacklisting
> intel-lpss can be removed. System boot with a working touchpad.
> 
> [Regression Potenial]
> Low. Tested on several older Intel laptops, still work without any
> issue.
> 
> 
> Kai-Heng Feng (1):
>   Revert "UBUNTU: SAUCE: mfd: intel-lpss: add quirk for Dell XPS 13 7390
>     2-in-1"
> 
> Tuowen Zhao (2):
>   lib: devres: add a helper function for ioremap_uc
>   mfd: intel-lpss: Use devm_ioremap_uc for MMIO
> 
>  drivers/mfd/intel-lpss.c | 20 ++------------------
>  lib/devres.c             |  3 +--
>  2 files changed, 3 insertions(+), 20 deletions(-)
> 
> -- 
> 2.17.1

Looks good to me.

Acked-by: Andrea Righi <andrea.righi@canonical.com>
Andrea Righi Nov. 28, 2019, 1:56 p.m. UTC | #3
On Tue, Nov 26, 2019 at 01:03:03PM +0800, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1851901
> 
> [Impact]
> On new Intel SoC, blacklisting intel-lpss or noapic is needed to make
> system boot. Touchpad doesn't work as a side effect.
> 
> [Fix]
> Write-comining doesn't work for intel-lpss, force it to use uncachable
> memory region.
> 
> [Test]
> User confirmed with the patch series the noapic or blacklisting
> intel-lpss can be removed. System boot with a working touchpad.
> 
> [Regression Potenial]
> Low. Tested on several older Intel laptops, still work without any
> issue.
> 
> 
> Kai-Heng Feng (1):
>   Revert "UBUNTU: SAUCE: mfd: intel-lpss: add quirk for Dell XPS 13 7390
>     2-in-1"
> 
> Tuowen Zhao (2):
>   lib: devres: add a helper function for ioremap_uc
>   mfd: intel-lpss: Use devm_ioremap_uc for MMIO
> 
>  drivers/mfd/intel-lpss.c | 20 ++------------------
>  lib/devres.c             |  3 +--
>  2 files changed, 3 insertions(+), 20 deletions(-)
> 
> -- 
> 2.17.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
Khalid Elmously Dec. 2, 2019, 5:45 a.m. UTC | #4
On 2019-11-26 13:03:03 , Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1851901
> 
> [Impact]
> On new Intel SoC, blacklisting intel-lpss or noapic is needed to make
> system boot. Touchpad doesn't work as a side effect.
> 
> [Fix]
> Write-comining doesn't work for intel-lpss, force it to use uncachable
> memory region.
> 
> [Test]
> User confirmed with the patch series the noapic or blacklisting
> intel-lpss can be removed. System boot with a working touchpad.
> 
> [Regression Potenial]
> Low. Tested on several older Intel laptops, still work without any
> issue.
> 
> 
> Kai-Heng Feng (1):
>   Revert "UBUNTU: SAUCE: mfd: intel-lpss: add quirk for Dell XPS 13 7390
>     2-in-1"
> 
> Tuowen Zhao (2):
>   lib: devres: add a helper function for ioremap_uc
>   mfd: intel-lpss: Use devm_ioremap_uc for MMIO
> 
>  drivers/mfd/intel-lpss.c | 20 ++------------------
>  lib/devres.c             |  3 +--
>  2 files changed, 3 insertions(+), 20 deletions(-)
> 
> -- 
> 2.17.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team