| Message ID | 20191119101304.18488-1-vigneshr@ti.com |
|---|---|
| Headers | show |
| Series | spi: cadence-qspi: Move to spi-mem APIs | expand |
On Tue, Nov 19, 2019 at 11:12 AM Vignesh Raghavendra <vigneshr@ti.com> wrote: > > First patch moves driver over to spi-mem framework and implement > spi_mem_ops. This is require to support more SPI Flash opcodes like SFDP > parsing etc. Series is in prepartion to add Octal mode for support for > the same driver to support OSPI version of the controller. > > Second patch adds DAC mode that provide memory mapped access to flash. > This greatly increases the read throughput. > > Tested with mt25qu512 flash and s25fl512 flash > > Note: Depends on [1][2] that adds stubs for dma_memcpy() to be used on > platforms without CONFIG_DMA enabled. > > [1]http://patchwork.ozlabs.org/patch/1195557/ > [2]http://patchwork.ozlabs.org/patch/1195556/ > > > Vignesh Raghavendra (2): > spi: cadence_qspi: Move to spi-mem framework > spi: cadence-qspi: Add direct mode support I really got to find the time to test this on socfpga gen5, sorry for failing yet. Regards, Simon > > drivers/spi/cadence_qspi.c | 148 +++++++++++--------------- > drivers/spi/cadence_qspi.h | 24 +++-- > drivers/spi/cadence_qspi_apb.c | 185 ++++++++++++++++----------------- > 3 files changed, 164 insertions(+), 193 deletions(-) > > -- > 2.24.0 >
Hi, On 11/19/2019 3:43 PM, Vignesh Raghavendra wrote: > First patch moves driver over to spi-mem framework and implement > spi_mem_ops. This is require to support more SPI Flash opcodes like SFDP > parsing etc. Series is in prepartion to add Octal mode for support for > the same driver to support OSPI version of the controller. > > Second patch adds DAC mode that provide memory mapped access to flash. > This greatly increases the read throughput. > > Tested with mt25qu512 flash and s25fl512 flash > > Note: Depends on [1][2] that adds stubs for dma_memcpy() to be used on > platforms without CONFIG_DMA enabled. > > [1]http://patchwork.ozlabs.org/patch/1195557/ > [2]http://patchwork.ozlabs.org/patch/1195556/ > Gentle ping... This has been in the ML for quite sometime. Could this be considered for this merge window? Regards Vignesh > > Vignesh Raghavendra (2): > spi: cadence_qspi: Move to spi-mem framework > spi: cadence-qspi: Add direct mode support > > drivers/spi/cadence_qspi.c | 148 +++++++++++--------------- > drivers/spi/cadence_qspi.h | 24 +++-- > drivers/spi/cadence_qspi_apb.c | 185 ++++++++++++++++----------------- > 3 files changed, 164 insertions(+), 193 deletions(-) >
Vignesh Raghavendra <vigneshr@ti.com> schrieb am Di., 14. Jan. 2020, 16:03: > Hi, > > On 11/19/2019 3:43 PM, Vignesh Raghavendra wrote: > > First patch moves driver over to spi-mem framework and implement > > spi_mem_ops. This is require to support more SPI Flash opcodes like SFDP > > parsing etc. Series is in prepartion to add Octal mode for support for > > the same driver to support OSPI version of the controller. > > > > Second patch adds DAC mode that provide memory mapped access to flash. > > This greatly increases the read throughput. > > > > Tested with mt25qu512 flash and s25fl512 flash > > > > Note: Depends on [1][2] that adds stubs for dma_memcpy() to be used on > > platforms without CONFIG_DMA enabled. > > > > [1]http://patchwork.ozlabs.org/patch/1195557/ > > [2]http://patchwork.ozlabs.org/patch/1195556/ > > > > Gentle ping... This has been in the ML for quite sometime. Could this be > considered for this merge window? > Oh, sorry. I'll take that as a reminder to test remaining things tomorrow. Regards, Simon > Regards > Vignesh > > > > > Vignesh Raghavendra (2): > > spi: cadence_qspi: Move to spi-mem framework > > spi: cadence-qspi: Add direct mode support > > > > drivers/spi/cadence_qspi.c | 148 +++++++++++--------------- > > drivers/spi/cadence_qspi.h | 24 +++-- > > drivers/spi/cadence_qspi_apb.c | 185 ++++++++++++++++----------------- > > 3 files changed, 164 insertions(+), 193 deletions(-) > > >
Hi Jagan, On 19/11/19 3:43 pm, Vignesh Raghavendra wrote: > First patch moves driver over to spi-mem framework and implement > spi_mem_ops. This is require to support more SPI Flash opcodes like SFDP > parsing etc. Series is in prepartion to add Octal mode for support for > the same driver to support OSPI version of the controller. > > Second patch adds DAC mode that provide memory mapped access to flash. > This greatly increases the read throughput. > > Tested with mt25qu512 flash and s25fl512 flash > Could you please merge this series? > Note: Depends on [1][2] that adds stubs for dma_memcpy() to be used on > platforms without CONFIG_DMA enabled. > > [1]http://patchwork.ozlabs.org/patch/1195557/ > [2]http://patchwork.ozlabs.org/patch/1195556/ > > > Vignesh Raghavendra (2): > spi: cadence_qspi: Move to spi-mem framework > spi: cadence-qspi: Add direct mode support > > drivers/spi/cadence_qspi.c | 148 +++++++++++--------------- > drivers/spi/cadence_qspi.h | 24 +++-- > drivers/spi/cadence_qspi_apb.c | 185 ++++++++++++++++----------------- > 3 files changed, 164 insertions(+), 193 deletions(-) >