mbox series

[v2,0/3] fanotify musl fixes

Message ID 20191113005626.19585-1-petr.vorel@gmail.com
Headers show
Series fanotify musl fixes | expand

Message

Petr Vorel Nov. 13, 2019, 12:56 a.m. UTC 
Hi,

I generalized previous patch set a bit via autotools checks and also add
other cleanup (base decisions whether to define fallback definitions on
autotools checks).

BTW I tempted to use <linux/fanotify.h>, but not only we'd have to
define fanotify_mark(), but we'd also lost libc header testing.

https://travis-ci.org/pevik/ltp/builds/611138280
(openSUSE Tumbleweed failure is not related to this change)

Kind regards,
Petr

Petr Vorel (3):
  fanotify: Move __kernel_fsid_t definition to correct place
  fanotify: Rework checks for fallback definitions
  fanotify: Detect val vs. __val fanotify_event_info_fid.fsid member

 configure.ac                                  |  1 +
 m4/ltp-fanotify.m4                            |  8 +++++
 testcases/kernel/syscalls/fanotify/fanotify.h | 32 ++++++++++++-------
 .../kernel/syscalls/fanotify/fanotify13.c     |  8 ++---
 .../kernel/syscalls/fanotify/fanotify15.c     |  4 +--
 5 files changed, 35 insertions(+), 18 deletions(-)
 create mode 100644 m4/ltp-fanotify.m4

Comments

Jan Stancek Nov. 13, 2019, 5:58 a.m. UTC | #1 
----- Original Message -----
> Hi,
> 
> I generalized previous patch set a bit via autotools checks and also add
> other cleanup (base decisions whether to define fallback definitions on
> autotools checks).
> 
> BTW I tempted to use <linux/fanotify.h>, but not only we'd have to
> define fanotify_mark(), but we'd also lost libc header testing.
> 
> https://travis-ci.org/pevik/ltp/builds/611138280
> (openSUSE Tumbleweed failure is not related to this change)

Hi Petr,

looks good to me. 2/3 rework makes it easier to follow too.
I tried it on couple old/new RHEL distros with no issues.

Acked-by: Jan Stancek <jstancek@redhat.com>
Cyril Hrubis Nov. 13, 2019, 9:48 a.m. UTC | #2 
Hi!
This version looks good to me as well, acked.
Petr Vorel Nov. 14, 2019, 6:17 p.m. UTC | #3 
Hi Cyril, Jan,

> Hi!
> This version looks good to me as well, acked.

thanks both for your review, merged.

Kind regards,
Petr