[0/3] Improve libopenssl target arch selection
mbox series

Message ID 20191027102420.15560-1-thomas.petazzoni@bootlin.com
Headers show
Series
  • Improve libopenssl target arch selection
Related show

Message

Thomas Petazzoni Oct. 27, 2019, 10:24 a.m. UTC
Hello,

Reviewing commit 027c02660b8cd670eff0ba6fdd9e49253968517f
("package/libopenssl: set no-asm with generic architectures") from
Fabrice made me realize that the OpenSSL target architecture selection
logic was not very easy to read, and was missing a number of useful
cases.

So here is a small patch series that moves the target architecture
selection logic to Config.in, and then makes use of linux-generic64
and linux-x86 when appropriate.

Thomas

Thomas Petazzoni (3):
  package/libopenssl: move target arch selection to Config.in
  package/libopenssl: make use of linux-generic64 for 64-bit archs
  package/libopenssl: make use of linux-x86 for i386

 package/libopenssl/Config.in     | 31 ++++++++++++++++++++++++++++
 package/libopenssl/libopenssl.mk | 35 +-------------------------------
 package/openssl/Config.in        |  2 ++
 3 files changed, 34 insertions(+), 34 deletions(-)
 create mode 100644 package/libopenssl/Config.in

Comments

Yann E. MORIN Dec. 30, 2019, 12:48 p.m. UTC | #1
Thomas, All,

On 2019-10-27 11:24 +0100, Thomas Petazzoni spake thusly:
> Hello,
> 
> Reviewing commit 027c02660b8cd670eff0ba6fdd9e49253968517f
> ("package/libopenssl: set no-asm with generic architectures") from
> Fabrice made me realize that the OpenSSL target architecture selection
> logic was not very easy to read, and was missing a number of useful
> cases.
> 
> So here is a small patch series that moves the target architecture
> selection logic to Config.in, and then makes use of linux-generic64
> and linux-x86 when appropriate.
> 
> Thomas
> 
> Thomas Petazzoni (3):
>   package/libopenssl: move target arch selection to Config.in
>   package/libopenssl: make use of linux-generic64 for 64-bit archs
>   package/libopenssl: make use of linux-x86 for i386

I've applied all athree to master, thanks.

I'll reply further on patch 1, for some specific comments.

Regards,
Yann E. MORIN.

>  package/libopenssl/Config.in     | 31 ++++++++++++++++++++++++++++
>  package/libopenssl/libopenssl.mk | 35 +-------------------------------
>  package/openssl/Config.in        |  2 ++
>  3 files changed, 34 insertions(+), 34 deletions(-)
>  create mode 100644 package/libopenssl/Config.in
> 
> -- 
> 2.21.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot