[SRU,D/E/Unstable,0/3] Allow Nvidia HDA to be runtime suspended to save power
mbox series

Message ID 20191023142528.29234-1-kai.heng.feng@canonical.com
Headers show
Series
  • Allow Nvidia HDA to be runtime suspended to save power
Related show

Message

Kai Heng Feng Oct. 23, 2019, 2:25 p.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1840835

[Impact]
Some Nvidia graphics card has audio function in addition to video
function. When the video function is not bound to any driver, the audio
function can't be runtime suspended, hence preventing the power
resources from being turned off.

[Fix]
Allow Nvidia audio function to be runtime suspended.

[Test]
The user reported the fix works.

[Regression Potential]
Low. It only allows the audio function of discrete Nvidia GPU to be
runtime suspended. Regular audio or audio function with a discrete GPU
already bound to a driver are unaffected.

Kai-Heng Feng (2):
  PCI: Add a helper to check Power Resource Requirements _PR3 existence
  ALSA: hda: Allow HDA to be runtime suspended when dGPU is not bound to
    a driver

Takashi Iwai (1):
  PCI: Fix missing inline for pci_pr3_present()

 drivers/pci/pci.c         | 18 ++++++++++++++++++
 include/linux/pci.h       |  2 ++
 sound/pci/hda/hda_intel.c |  8 +++++++-
 3 files changed, 27 insertions(+), 1 deletion(-)

Comments

Seth Forshee Nov. 1, 2019, 12:42 p.m. UTC | #1
On Wed, Oct 23, 2019 at 10:25:24PM +0800, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1840835
> 
> [Impact]
> Some Nvidia graphics card has audio function in addition to video
> function. When the video function is not bound to any driver, the audio
> function can't be runtime suspended, hence preventing the power
> resources from being turned off.
> 
> [Fix]
> Allow Nvidia audio function to be runtime suspended.
> 
> [Test]
> The user reported the fix works.
> 
> [Regression Potential]
> Low. It only allows the audio function of discrete Nvidia GPU to be
> runtime suspended. Regular audio or audio function with a discrete GPU
> already bound to a driver are unaffected.

Acked-by: Seth Forshee <seth.forshee@canonical.com>

Applied to unstable/master, thanks!
Stefan Bader Nov. 7, 2019, 4:39 p.m. UTC | #2
On 23.10.19 16:25, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1840835
> 
> [Impact]
> Some Nvidia graphics card has audio function in addition to video
> function. When the video function is not bound to any driver, the audio
> function can't be runtime suspended, hence preventing the power
> resources from being turned off.
> 
> [Fix]
> Allow Nvidia audio function to be runtime suspended.
> 
> [Test]
> The user reported the fix works.
> 
> [Regression Potential]
> Low. It only allows the audio function of discrete Nvidia GPU to be
> runtime suspended. Regular audio or audio function with a discrete GPU
> already bound to a driver are unaffected.
> 
> Kai-Heng Feng (2):
>   PCI: Add a helper to check Power Resource Requirements _PR3 existence
>   ALSA: hda: Allow HDA to be runtime suspended when dGPU is not bound to
>     a driver
> 
> Takashi Iwai (1):
>   PCI: Fix missing inline for pci_pr3_present()
> 
>  drivers/pci/pci.c         | 18 ++++++++++++++++++
>  include/linux/pci.h       |  2 ++
>  sound/pci/hda/hda_intel.c |  8 +++++++-
>  3 files changed, 27 insertions(+), 1 deletion(-)
> 
Acked-by: Stefan Bader <stefan.bader@canonical.com>
Khaled Elmously Nov. 9, 2019, 7:10 a.m. UTC | #3
On 2019-10-23 22:25:24 , Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1840835
> 
> [Impact]
> Some Nvidia graphics card has audio function in addition to video
> function. When the video function is not bound to any driver, the audio
> function can't be runtime suspended, hence preventing the power
> resources from being turned off.
> 
> [Fix]
> Allow Nvidia audio function to be runtime suspended.
> 
> [Test]
> The user reported the fix works.
> 
> [Regression Potential]
> Low. It only allows the audio function of discrete Nvidia GPU to be
> runtime suspended. Regular audio or audio function with a discrete GPU
> already bound to a driver are unaffected.
> 
> Kai-Heng Feng (2):
>   PCI: Add a helper to check Power Resource Requirements _PR3 existence
>   ALSA: hda: Allow HDA to be runtime suspended when dGPU is not bound to
>     a driver
> 
> Takashi Iwai (1):
>   PCI: Fix missing inline for pci_pr3_present()
> 
>  drivers/pci/pci.c         | 18 ++++++++++++++++++
>  include/linux/pci.h       |  2 ++
>  sound/pci/hda/hda_intel.c |  8 +++++++-
>  3 files changed, 27 insertions(+), 1 deletion(-)
> 
> -- 
> 2.17.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team