mbox series

[v2,0/5] pinctrl: intel: Refactor register restoring on resume

Message ID 20191022100004.66532-1-andriy.shevchenko@linux.intel.com
Headers show
Series pinctrl: intel: Refactor register restoring on resume | expand

Message

Andy Shevchenko Oct. 22, 2019, 9:59 a.m. UTC
Refactor ->resume() path to be a bit smarter and less noisy.

In v2:
- add a patch to reduce a noise in kernel log
- drop warning to debug level for one message
- constify local pointers (Mika)

Andy Shevchenko (5):
  pinctrl: intel: Introduce intel_restore_padcfg() helper
  pinctrl: intel: Introduce intel_restore_hostown() helper
  pinctrl: intel: Introduce intel_restore_intmask() helper
  pinctrl: intel: Drop level from warning to debug in
    intel_restore_hostown()
  pinctrl: intel: Use helper to restore register values on ->resume()

 drivers/pinctrl/intel/pinctrl-intel.c | 115 ++++++++++++++------------
 1 file changed, 61 insertions(+), 54 deletions(-)

Comments

Mika Westerberg Oct. 23, 2019, 7:30 a.m. UTC | #1
On Tue, Oct 22, 2019 at 12:59:59PM +0300, Andy Shevchenko wrote:
> Refactor ->resume() path to be a bit smarter and less noisy.
> 
> In v2:
> - add a patch to reduce a noise in kernel log
> - drop warning to debug level for one message
> - constify local pointers (Mika)
> 
> Andy Shevchenko (5):
>   pinctrl: intel: Introduce intel_restore_padcfg() helper
>   pinctrl: intel: Introduce intel_restore_hostown() helper
>   pinctrl: intel: Introduce intel_restore_intmask() helper
>   pinctrl: intel: Drop level from warning to debug in
>     intel_restore_hostown()
>   pinctrl: intel: Use helper to restore register values on ->resume()

For the whole series,

Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Andy Shevchenko Oct. 23, 2019, 9:36 a.m. UTC | #2
On Wed, Oct 23, 2019 at 10:30:33AM +0300, Mika Westerberg wrote:
> On Tue, Oct 22, 2019 at 12:59:59PM +0300, Andy Shevchenko wrote:
> > Refactor ->resume() path to be a bit smarter and less noisy.
> > 
> > In v2:
> > - add a patch to reduce a noise in kernel log
> > - drop warning to debug level for one message
> > - constify local pointers (Mika)
> > 
> > Andy Shevchenko (5):
> >   pinctrl: intel: Introduce intel_restore_padcfg() helper
> >   pinctrl: intel: Introduce intel_restore_hostown() helper
> >   pinctrl: intel: Introduce intel_restore_intmask() helper
> >   pinctrl: intel: Drop level from warning to debug in
> >     intel_restore_hostown()
> >   pinctrl: intel: Use helper to restore register values on ->resume()
> 
> For the whole series,
> 
> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>

Pushed to my review and testing queue, thanks!