mbox series

[v5,0/2] mv88e6xxx: Allow config of ATU hash algorithm

Message ID 20191022013436.29635-1-andrew@lunn.ch
Headers show
Series mv88e6xxx: Allow config of ATU hash algorithm | expand

Message

Andrew Lunn Oct. 22, 2019, 1:34 a.m. UTC 
v2:

Pass a pointer for where the hash should be stored, return a plain
errno, or 0.

Document the parameter.

v3:

Document type of parameter, and valid range
Add break statements to default clause of switch
Directly use ctx->val.vu8

v4:

Consistently use devlink, not a mix of devlink and dl.
Fix allocation of devlink priv
Remove upper case from parameter name
Make mask 16 bit wide.

v5:
Back to using the parameter name ATU_hash

Andrew Lunn (2):
  net: dsa: Add support for devlink device parameters
  net: dsa: mv88e6xxx: Add devlink param for ATU hash algorithm.

 .../networking/devlink-params-mv88e6xxx.txt   |   7 +
 MAINTAINERS                                   |   1 +
 drivers/net/dsa/mv88e6xxx/chip.c              | 131 +++++++++++++++++-
 drivers/net/dsa/mv88e6xxx/chip.h              |   4 +
 drivers/net/dsa/mv88e6xxx/global1.h           |   3 +
 drivers/net/dsa/mv88e6xxx/global1_atu.c       |  32 +++++
 include/net/dsa.h                             |  23 +++
 net/dsa/dsa.c                                 |  48 +++++++
 net/dsa/dsa2.c                                |   7 +-
 9 files changed, 254 insertions(+), 2 deletions(-)
 create mode 100644 Documentation/networking/devlink-params-mv88e6xxx.txt

Comments

David Miller Oct. 24, 2019, 2:18 a.m. UTC | #1 
Andrew, this only applies to 'net' but it feels more like a feature
to me.

Please give me some guidance and use [PATCH net-next .. ] in the future.

Thanks.
Andrew Lunn Oct. 24, 2019, 2:42 a.m. UTC | #2 
On Wed, Oct 23, 2019 at 07:18:30PM -0700, David Miller wrote:
> 
> Andrew, this only applies to 'net' but it feels more like a feature
> to me.

Hi David

It was intended for net-next. Sorry. It could be that Viviens port
list patches got in the middle so that these did not cleanly apply to
net-next.

> Please give me some guidance and use [PATCH net-next .. ] in the future.

I wonder if we could get checkpatch to warn about this?

  Andrew
David Miller Oct. 24, 2019, 10:06 p.m. UTC | #3 
From: Andrew Lunn <andrew@lunn.ch>
Date: Thu, 24 Oct 2019 04:42:56 +0200

> It was intended for net-next. Sorry. It could be that Viviens port
> list patches got in the middle so that these did not cleanly apply to
> net-next.

Please respin, thank you.

>> Please give me some guidance and use [PATCH net-next .. ] in the future.
> 
> I wonder if we could get checkpatch to warn about this?

I'm sure it's possible.