mbox series

[net-next,0/4] ICMP flow improvements

Message ID 20191021200948.23775-1-mcroce@redhat.com
Headers show
Series ICMP flow improvements | expand

Message

Matteo Croce Oct. 21, 2019, 8:09 p.m. UTC 
This series improves the flow inspector handling of ICMP packets:
The first two patches just add some comments in the code which would have saved
me a few minutes of time, and refactor a piece of code.
The third one adds to the flow inspector the capability to extract the
Identifier field, if present, so echo requests and replies are classified
as part of the same flow.
The fourth patch uses the function introduced earlier to the bonding driver,
so echo replies can be balanced across bonding slaves.

Matteo Croce (4):
  flow_dissector: add meaningful comments
  flow_dissector: skip the ICMP dissector for non ICMP packets
  flow_dissector: extract more ICMP information
  bonding: balance ICMP echoes in layer3+4 mode

 drivers/net/bonding/bond_main.c | 22 ++++++--
 include/net/flow_dissector.h    | 11 +++-
 net/core/flow_dissector.c       | 98 +++++++++++++++++++++++----------
 3 files changed, 95 insertions(+), 36 deletions(-)

Comments

David Miller Oct. 24, 2019, 10:05 p.m. UTC | #1 
From: Matteo Croce <mcroce@redhat.com>
Date: Mon, 21 Oct 2019 22:09:44 +0200

> This series improves the flow inspector handling of ICMP packets:
> The first two patches just add some comments in the code which would have saved
> me a few minutes of time, and refactor a piece of code.
> The third one adds to the flow inspector the capability to extract the
> Identifier field, if present, so echo requests and replies are classified
> as part of the same flow.
> The fourth patch uses the function introduced earlier to the bonding driver,
> so echo replies can be balanced across bonding slaves.

Simon has unaddressed feedback for patch #3, and this has been sitting in that
state for several days.

Please repost this series when everything is sorted, thank you.