mbox series

[net-next,0/4] r8169: remove fiddling with the PCIe max read request size

Message ID c4f2e4fc-9cbe-2ba1-b0b2-1e734032b550@gmail.com
Headers show
Series r8169: remove fiddling with the PCIe max read request size | expand

Message

Heiner Kallweit Oct. 21, 2019, 7:21 p.m. UTC 
The attempt to improve performance by changing the PCIe max read request
size was added in the vendor driver more than 10 years back and copied
to r8169 driver. In the vendor driver this has been removed long ago.
Obviously it had no effect, also in my tests I didn't see any
difference. Typically the max payload size is less than 512 bytes
anyway, and the PCI core takes care that the maximum supported value
is set. So let's remove fiddling with PCIe max read request size from
r8169 too. This change allows to simplify the driver in the subsequent
three patches of this series.

Heiner Kallweit (4):
  r8169: remove fiddling with the PCIe max read request size
  r8169: simplify setting PCI_EXP_DEVCTL_NOSNOOP_EN
  r8169: remove rtl_hw_start_8168dp
  r8169: remove rtl_hw_start_8168bef

 drivers/net/ethernet/realtek/r8169_main.c | 90 ++++-------------------
 1 file changed, 15 insertions(+), 75 deletions(-)

Comments

Jakub Kicinski Oct. 22, 2019, 6:36 p.m. UTC | #1 
On Mon, 21 Oct 2019 21:21:23 +0200, Heiner Kallweit wrote:
> The attempt to improve performance by changing the PCIe max read request
> size was added in the vendor driver more than 10 years back and copied
> to r8169 driver. In the vendor driver this has been removed long ago.
> Obviously it had no effect, also in my tests I didn't see any
> difference. Typically the max payload size is less than 512 bytes
> anyway, and the PCI core takes care that the maximum supported value
> is set. So let's remove fiddling with PCIe max read request size from
> r8169 too. This change allows to simplify the driver in the subsequent
> three patches of this series.

Applied, thanks!