mbox series

[net-next,0/6] DPAA Ethernet changes

Message ID 1571660862-18313-1-git-send-email-madalin.bucur@nxp.com
Headers show
Series DPAA Ethernet changes | expand

Message

Madalin Bucur Oct. 21, 2019, 12:27 p.m. UTC 
Here's a series of changes for the DPAA Ethernet, addressing minor
or unapparent issues in the codebase, adding probe ordering based on
a recently added DPAA QMan API, removing some redundant code.

Laurentiu Tudor (3):
  fsl/fman: don't touch liodn base regs reserved on non-PAMU SoCs
  dpaa_eth: defer probing after qbman
  fsl/fman: add API to get the device behind a fman port

Madalin Bucur (3):
  dpaa_eth: remove redundant code
  dpaa_eth: change DMA device
  fsl/fman: remove unused struct member

 drivers/net/ethernet/freescale/dpaa/dpaa_eth.c  | 128 +++++++++++++++---------
 drivers/net/ethernet/freescale/dpaa/dpaa_eth.h  |   8 +-
 drivers/net/ethernet/freescale/fman/fman.c      |   6 +-
 drivers/net/ethernet/freescale/fman/fman_port.c |  17 +++-
 drivers/net/ethernet/freescale/fman/fman_port.h |   2 +
 5 files changed, 108 insertions(+), 53 deletions(-)

Comments

Jakub Kicinski Oct. 22, 2019, 4:26 a.m. UTC | #1 
On Mon, 21 Oct 2019 12:27:51 +0000, Madalin-cristian Bucur wrote:
> Here's a series of changes for the DPAA Ethernet, addressing minor
> or unapparent issues in the codebase, adding probe ordering based on
> a recently added DPAA QMan API, removing some redundant code.

Hi Madalin!

Patch 2 looks like it may be a bug fix but I gather it has a dependency
in net-next so it can't go to net?

More importantly - I think your From: line on this posting is 

Madalin-cristian Bucur <madalin.bucur@nxp.com>

While the sign-off on the patches you wrote is:

Madalin Bucur <madalin.bucur@nxp.com>

I think these gotta be identical otherwise the bots which ensure the
author added his sign-off may scream at us.
Madalin Bucur Oct. 22, 2019, 6:43 a.m. UTC | #2 
> -----Original Message-----
> From: Jakub Kicinski <jakub.kicinski@netronome.com>
> Sent: Tuesday, October 22, 2019 7:26 AM
> To: Madalin-cristian Bucur <madalin.bucur@nxp.com>
> Cc: davem@davemloft.net; netdev@vger.kernel.org; Roy Pledge
> <roy.pledge@nxp.com>; Laurentiu Tudor <laurentiu.tudor@nxp.com>
> Subject: Re: [PATCH net-next 0/6] DPAA Ethernet changes
> 
> On Mon, 21 Oct 2019 12:27:51 +0000, Madalin-cristian Bucur wrote:
> > Here's a series of changes for the DPAA Ethernet, addressing minor
> > or unapparent issues in the codebase, adding probe ordering based on
> > a recently added DPAA QMan API, removing some redundant code.
> 
> Hi Madalin!
> 
> Patch 2 looks like it may be a bug fix but I gather it has a dependency
> in net-next so it can't go to net?

It's a fix for a theoretical issue that is not reproducing with the current
code base. Future changes related to the IOMMU support may make this issue
visible.

> More importantly - I think your From: line on this posting is
> 
> Madalin-cristian Bucur <madalin.bucur@nxp.com>
> 
> While the sign-off on the patches you wrote is:
> 
> Madalin Bucur <madalin.bucur@nxp.com>
> 
> I think these gotta be identical otherwise the bots which ensure the
> author added his sign-off may scream at us.

The formatted patches look like this:

From 55a524a41099fa9b2f5fbbb9f3a87108437942bb Mon Sep 17 00:00:00 2001
From: Madalin Bucur <madalin.bucur@nxp.com>
Date: Mon, 21 Oct 2019 15:21:26 +0300
Subject: [PATCH net-next 0/6] DPAA Ethernet changes
Content-Type: text/plain; charset="us-ascii"
Reply-to: madalin.bucur@nxp.com

but then there are some MS servers trying to be helpful and the message
ends up like this:

From: Madalin-cristian Bucur <madalin.bucur@nxp.com>
To: "davem@davemloft.net" <davem@davemloft.net>, "netdev@vger.kernel.org"
	<netdev@vger.kernel.org>
CC: Roy Pledge <roy.pledge@nxp.com>, Laurentiu Tudor
	<laurentiu.tudor@nxp.com>, Madalin-cristian Bucur <madalin.bucur@nxp.com>
Subject: [PATCH net-next 0/6] DPAA Ethernet changes
Thread-Topic: [PATCH net-next 0/6] DPAA Ethernet changes
Thread-Index: AQHViAr0ehww7MPYPUqedXDa00qudg==
X-MS-Exchange-MessageSentRepresentingType: 1
Date: Mon, 21 Oct 2019 12:27:51 +0000
Message-ID: <1571660862-18313-1-git-send-email-madalin.bucur@nxp.com>
Reply-To: Madalin-cristian Bucur <madalin.bucur@nxp.com>
<snip>
Return-Path: madalin.bucur@nxp.com

It's probably a good time to think about pull requests...